upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-05-28 04:12:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MEDIUM: peers: No longer ack updates during a full resync

Browse source 
ACK messages received by a peer sending updates during a full resync are
ignored. So, on the other side, there is no reason to still send these ACK
messages. Let's skip them.

In addition, the received updates during this stage are not considered as to
be acked. It is important to be sure to properly emit ACK messages once the
full sync finished.
This commit is contained in:
Christopher Faulet 2025-09-29 15:49:44 +02:00
parent 383bf11306
commit 590c5ff2ed
1 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/peers.c
View file

@ -1821,6 +1821,7 @@ int peer_treat_updatemsg(struct appctx *appctx, struct peer *p, int updt, int ex
expire = MS_TO_TICKS(table->expire); expire = MS_TO_TICKS(table->expire);
if (p->learnstate != PEER_LR_ST_PROCESSING) {
if (updt) { if (updt) {
if (msg_len < sizeof(update)) { if (msg_len < sizeof(update)) {
TRACE_ERROR("malformed update message: message too small", PEERS_EV_SESS_IO|PEERS_EV_RX_MSG|PEERS_EV_PROTO_ERR, appctx, p, st); TRACE_ERROR("malformed update message: message too small", PEERS_EV_SESS_IO|PEERS_EV_RX_MSG|PEERS_EV_PROTO_ERR, appctx, p, st);
@ -1834,6 +1835,7 @@ int peer_treat_updatemsg(struct appctx *appctx, struct peer *p, int updt, int ex
else { else {
st->last_get++; st->last_get++;
} }
}
if (exp) { if (exp) {
size_t expire_sz = sizeof expire; size_t expire_sz = sizeof expire;