upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-20 00:10:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

Revert "BUG/MINOR: resolvers: Only renew TTL for SRV records with an additional record"

Browse source 
This reverts commit a331a1e8eb.

This commit fixes a real bug, but it also reveals some hidden bugs, mostly
because of some design issues. Thus, in itself, it create more problem than
it solves. So revert it for now. All known bugs will be addressed in next
commits.

This patch should be backported as far as 2.2.
This commit is contained in:
Christopher Faulet 2021-03-10 15:54:14 +01:00
parent 736adef511
commit 5037c06d91
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/resolvers.c
View file

@ -1046,8 +1046,7 @@ static int resolv_validate_dns_response(unsigned char *resp, unsigned char *bufe
}
if (found == 1) {
if (tmp_record->type != DNS_RTYPE_SRV || tmp_record->ar_item != NULL)
tmp_record->last_seen = now.tv_sec;
tmp_record->last_seen = now.tv_sec;
pool_free(resolv_answer_item_pool, answer_record);
answer_record = NULL;
}
@ -1239,7 +1238,6 @@ static int resolv_validate_dns_response(unsigned char *resp, unsigned char *bufe
if (tmp_record->ar_item)
pool_free(resolv_answer_item_pool, tmp_record->ar_item);
tmp_record->ar_item = answer_record;
tmp_record->last_seen = answer_record->last_seen;
answer_record = NULL;
break;
}