upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-21 06:06:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

MEDIUM: fcgi: remove conn from session on detach

Browse source 
FCGI mux is marked with HOL blocking. On safe reuse mode, the connection
using it are placed on the sessions instead of the available lists to
avoid sharing it with several clients. On detach, if they are no more
streams, remove the connection from the session before adding it to the
idle list. If there is still used streams, do not add it to available
list as it should be already on the session list.
This commit is contained in:
Amaury Denoyelle 2020-10-14 18:17:11 +02:00 committed by Christopher Faulet
parent 6b8daef56b
commit 46f041d7f8
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/mux_fcgi.c
View file

@ -3578,6 +3578,14 @@ static void fcgi_detach(struct conn_stream *cs)
}
else {
if (eb_is_empty(&fconn->streams_by_id)) {
/* If the connection is owned by the session, first remove it
* from its list
*/
if (fconn->conn->owner) {
session_unown_conn(fconn->conn->owner, fconn->conn);
fconn->conn->owner = NULL;
}
if (!srv_add_to_idle_list(objt_server(fconn->conn->target), fconn->conn, 1)) {
/* The server doesn't want it, let's kill the connection right away */
fconn->conn->mux->destroy(fconn);
@ -3592,7 +3600,8 @@ static void fcgi_detach(struct conn_stream *cs)
return;
}
else if (MT_LIST_ISEMPTY(&fconn->conn->list) &&
fcgi_avail_streams(fconn->conn) > 0 && objt_server(fconn->conn->target)) {
fcgi_avail_streams(fconn->conn) > 0 && objt_server(fconn->conn->target) &&
!LIST_ADDED(&fconn->conn->session_list)) {
LIST_ADD(&__objt_server(fconn->conn->target)->available_conns[tid], mt_list_to_list(&fconn->conn->list));
}
}