upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-15 21:59:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MINOR: log/cbor: _lf_cbor_encode_byte() explicitly requires non-NULL ctx (again)

Browse source 
The BUG_ON() statement that was added in 9bdea51 ("MINOR: log/cbor:
_lf_cbor_encode_byte() explicitly requires non-NULL ctx") isn't
sufficient as Coverity still thinks the lf_buildctx itself may be NULL
as shown in GH #2554. In fact the original reports complains about the
lf_buildctx itself and I didn't understand it properly, let's add another
check in the BUG_ON() to ensure both cbor_ctx and cbor_ctx->ctx are not
NULL since it is not expected if used properly.
This commit is contained in:
Aurelien DARRAGON 2024-04-30 08:55:13 +02:00
parent 9931a62c3f
commit 41d7e82e0f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/log.c
View file

@ -1794,7 +1794,7 @@ static char *_lf_cbor_encode_byte(struct cbor_encode_ctx *cbor_ctx,
{
struct lf_buildctx *ctx;
BUG_ON(!cbor_ctx);
BUG_ON(!cbor_ctx || !cbor_ctx->e_fct_ctx);
ctx = cbor_ctx->e_fct_ctx;
if (ctx->options & LOG_OPT_BIN) {