upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-20 00:10:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

[STATS] frontend requests were not accounted for failed requests

Browse source 
But failed requests were accounted for, resulting in more failures
than requests.
This commit is contained in:
Willy Tarreau 2010-03-04 23:02:38 +01:00
parent ae52678444
commit 3e1b6d1ed0
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/proto_http.c
View file

@ -2429,8 +2429,10 @@ int http_wait_for_request(struct session *s, struct buffer *req, int an_bit)
/*
* First, let's catch bad requests.
*/
if (unlikely(msg->msg_state == HTTP_MSG_ERROR))
if (unlikely(msg->msg_state == HTTP_MSG_ERROR)) {
proxy_inc_fe_req_ctr(s->fe);
goto return_bad_req;
}
/* 1: Since we are in header mode, if there's no space
* left for headers, we won't be able to free more
@ -2441,6 +2443,7 @@ int http_wait_for_request(struct session *s, struct buffer *req, int an_bit)
/* FIXME: check if URI is set and return Status
* 414 Request URI too long instead.
*/
proxy_inc_fe_req_ctr(s->fe);
goto return_bad_req;
}
@ -2458,6 +2461,7 @@ int http_wait_for_request(struct session *s, struct buffer *req, int an_bit)
msg->msg_state = HTTP_MSG_ERROR;
req->analysers = 0;
proxy_inc_fe_req_ctr(s->fe);
s->fe->counters.failed_req++;
if (s->listener->counters)
s->listener->counters->failed_req++;
@ -2483,6 +2487,7 @@ int http_wait_for_request(struct session *s, struct buffer *req, int an_bit)
msg->msg_state = HTTP_MSG_ERROR;
req->analysers = 0;
proxy_inc_fe_req_ctr(s->fe);
s->fe->counters.failed_req++;
if (s->listener->counters)
s->listener->counters->failed_req++;
@ -2507,6 +2512,7 @@ int http_wait_for_request(struct session *s, struct buffer *req, int an_bit)
msg->msg_state = HTTP_MSG_ERROR;
req->analysers = 0;
proxy_inc_fe_req_ctr(s->fe);
s->fe->counters.failed_req++;
if (s->listener->counters)
s->listener->counters->failed_req++;