upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-08 18:36:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

BUG/MAJOR: http: fix bug in parse_qvalue() when selecting compression algo

Browse source 
Commit ad90351 ("MINOR: http: Add the "language" converter to for use with accept-language")
introduced a typo in parse_qvalue :

	if (*end)
		*end = qvalue;

while it should be :

	if (end)
		*end = qvalue;

Since end is tested for being NULL. This crashes when selecting the
compression algorithm since end is NULL here. No backport is needed,
this is just in latest 1.5-dev.
This commit is contained in:
Willy Tarreau 2014-04-22 23:32:05 +02:00
parent c006dab8be
commit 38b3aa5646
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/proto_http.c
View file

@ -2151,7 +2151,7 @@ int parse_qvalue(const char *qvalue, const char **end)
out:
if (q > 1000)
q = 1000;
if (*end)
if (end)
*end = qvalue;
return q;
}