upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-20 00:10:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

BUG/MEDIUM: stream: Don't forget to free s->unique_id in stream_free().

Browse source 
In stream_free(), free s->unique_id. We may still have one, because it's
allocated in log.c::strm_log() no matter what, even if it's a TCP connection
and thus it won't get free'd by http_end_txn().
Failure to do so leads to a memory leak.

This should probably be backported to all maintained branches.
This commit is contained in:
Olivier Houchard 2019-02-01 18:10:46 +01:00 committed by Willy Tarreau
parent 053c15750b
commit 32211a17eb
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/stream.c
View file

@ -386,6 +386,8 @@ static void stream_free(struct stream *s)
offer_buffers(NULL, tasks_run_queue);
}
pool_free(pool_head_uniqueid, s->unique_id);
hlua_ctx_destroy(s->hlua);
s->hlua = NULL;
if (s->txn)