From 0bf22b86d0f36ade8dacfe399b5e3331b629bb69 Mon Sep 17 00:00:00 2001 From: Ilia Shipitsin Date: Sun, 31 May 2026 09:19:21 +0200 Subject: [PATCH] CLEANUP: admin/halog: improve handling of memory allocation errors Found via cppcheck --force --enable=all --output-file=haproxy.log : admin/halog/halog.c:1805:2: warning: If memory allocation fails, then there is a possible null pointer dereference: ustat [nullPointerOutOfMemory] admin/halog/halog.c:1806:2: warning: If memory allocation fails, then there is a possible null pointer dereference: ustat [nullPointerOutOfMemory] admin/halog/halog.c:1809:2: warning: If memory allocation fails, then there is a possible null pointer dereference: ustat [nullPointerOutOfMemory] admin/halog/halog.c:1810:2: warning: If memory allocation fails, then there is a possible null pointer dereference: ustat [nullPointerOutOfMemory] admin/halog/halog.c:1814:2: warning: If memory allocation fails, then there is a possible null pointer dereference: ustat [nullPointerOutOfMemory] --- admin/halog/halog.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/admin/halog/halog.c b/admin/halog/halog.c index 5b6296033..52986849f 100644 --- a/admin/halog/halog.c +++ b/admin/halog/halog.c @@ -1801,6 +1801,8 @@ void filter_count_ip(const char *source_field, const char *accept_field, const c */ if (unlikely(!ustat)) ustat = calloc(1, sizeof(*ustat)); + if (!ustat) + return; ustat->nb_err = err; ustat->nb_req = 1;