upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-05-28 04:12:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MINOR: mux-h1: only check h1s if not NULL

Browse source 
Since we can emit glitches during an H2 upgrade, we no longer have a
guaranteed h1s, so _h1_report_glitch() must check h1s before
dereferencing it. No backport is needed as this arrived in 3.4-dev11
with commit 72fd357814 ("MEDIUM: mux-h1: Return an error on h2 upgrade
attempts if not allowed").
This commit is contained in:
Willy Tarreau 2026-05-11 14:44:12 +02:00
parent d7f8a25db1
commit 009c32d863
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/mux_h1.c
View file

@ -536,7 +536,8 @@ static inline int _h1_report_glitch(struct h1c *h1c, int increment)
/* at 75% of the threshold, we switch to close mode
* to force clients to periodically reconnect.
*/
h1c->h1s->flags = (h1c->h1s->flags & ~H1S_F_WANT_MSK) | H1S_F_WANT_CLO;
if (h1c->h1s)
h1c->h1s->flags = (h1c->h1s->flags & ~H1S_F_WANT_MSK) | H1S_F_WANT_CLO;
/* at 100% of the threshold and excess of CPU usage we also
* actively kill the connection.