Mathieu Fenniak 33723dbdfd feat: add foreign keys to table pull_request (#9832) ... Adds foreign keys to the table pull_request which are covered by the doctor's db consistency check: - issue_id -> issue - base_repo_id -> repository Note that other fields that look like references -- `head_repo_id` and `merger` -- are not covered by the db consistency check and therefore out-of-scope for the first phase of foreign keys. They're on my list for future more detailed evaluation. In addition to running automated tests (and making a few tweaks to get them to pass), I performed manual testing of: - Deleting the base repo of a pull request -- the repo is deleted without error and the pull request is deleted as well. - Deleting the issue behind a PR via an issue delete API call -- this code-path handles deleting a PR correctly. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9832 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>		2025-10-24 18:02:14 +02:00
..
install
paginator
collation.go
common.go
consistency.go
context.go
context_committer_test.go
context_test.go
convert.go
engine.go
engine_test.go
error.go
foreign_keys.go
index.go
index_test.go
iterate.go
iterate_test.go
list.go
list_test.go
log.go
main_test.go
name.go
search.go
sequence.go
sql_postgres_with_schema.go
table_names_test.go