From bfef19d39dd82d7b4d7b3b92fd7fb2e4d27c9d15 Mon Sep 17 00:00:00 2001 From: 0ko <0ko@noreply.codeberg.org> Date: Sun, 18 Jan 2026 05:39:28 +0100 Subject: [PATCH] chore(ui): remove obsolete var --color-nav-text (#10898) This variable isn't needed because all themes are setting it to `--color-text`, but the relevant UI elements are already inheriting it from `body`. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10898 Reviewed-by: Gusted --- web_src/css/modules/navbar.css | 4 ---- web_src/css/themes/theme-forgejo-dark.css | 1 - web_src/css/themes/theme-forgejo-light.css | 1 - web_src/css/themes/theme-gitea-dark.css | 1 - web_src/css/themes/theme-gitea-light.css | 1 - 5 files changed, 8 deletions(-) diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css index b725b54182..ab905196a8 100644 --- a/web_src/css/modules/navbar.css +++ b/web_src/css/modules/navbar.css @@ -33,10 +33,6 @@ display: flex; } -#navbar > .menu > .item { - color: var(--color-nav-text); -} - #navbar .dropdown .item { justify-content: stretch; } diff --git a/web_src/css/themes/theme-forgejo-dark.css b/web_src/css/themes/theme-forgejo-dark.css index 40fb093665..1c5466b3c8 100644 --- a/web_src/css/themes/theme-forgejo-dark.css +++ b/web_src/css/themes/theme-forgejo-dark.css @@ -265,7 +265,6 @@ --color-tooltip-bg: #000000f0; --color-nav-bg: var(--steel-900); --color-nav-hover-bg: var(--steel-600); - --color-nav-text: var(--color-text); --color-secondary-nav-bg: var(--color-body); --color-label-text: #fff; --color-label-bg: var(--steel-600); diff --git a/web_src/css/themes/theme-forgejo-light.css b/web_src/css/themes/theme-forgejo-light.css index b4ad8f1649..be94290f5c 100644 --- a/web_src/css/themes/theme-forgejo-light.css +++ b/web_src/css/themes/theme-forgejo-light.css @@ -263,7 +263,6 @@ --color-tooltip-bg: #000000f0; --color-nav-bg: var(--zinc-100); --color-nav-hover-bg: var(--zinc-300); - --color-nav-text: var(--color-text); --color-secondary-nav-bg: var(--color-body); --color-label-text: var(--color-text); --color-label-bg: #cacaca7b; diff --git a/web_src/css/themes/theme-gitea-dark.css b/web_src/css/themes/theme-gitea-dark.css index 0fbe7ba4ec..31cf57b7c9 100644 --- a/web_src/css/themes/theme-gitea-dark.css +++ b/web_src/css/themes/theme-gitea-dark.css @@ -224,7 +224,6 @@ --color-tooltip-bg: #000017f0; --color-nav-bg: #16191c; --color-nav-hover-bg: var(--color-secondary-light-1); - --color-nav-text: var(--color-text); --color-secondary-nav-bg: #181c20; --color-label-text: var(--color-text); --color-label-bg: #73828e4b; diff --git a/web_src/css/themes/theme-gitea-light.css b/web_src/css/themes/theme-gitea-light.css index c9ca759472..74272c738e 100644 --- a/web_src/css/themes/theme-gitea-light.css +++ b/web_src/css/themes/theme-gitea-light.css @@ -224,7 +224,6 @@ --color-tooltip-bg: #000017f0; --color-nav-bg: #f6f7fa; --color-nav-hover-bg: var(--color-secondary-light-1); - --color-nav-text: var(--color-text); --color-secondary-nav-bg: #f9fafb; --color-label-text: var(--color-text); --color-label-bg: #949da64b;