From 8a72b70f5f879f808c7f3a6cbb55eaffe0e9fa1b Mon Sep 17 00:00:00 2001 From: 0ko <0ko@noreply.codeberg.org> Date: Wed, 27 May 2026 05:46:21 +0200 Subject: [PATCH] fix(ui): do not clip overflow in workflow dispatch menu (#12753) Fixes forgejo/forgejo#12090 Fixes forgejo/forgejo#12228 Fixes forgejo/forgejo#12743 Partially revert https://codeberg.org/forgejo/forgejo/src/commit/b5988efc85ca54e39459323775aef0bc20f145be/web_src/css/actions.css#L91-L94 from forgejo/forgejo!10563. This will cause overly long lists to overflow the viewport [like in this image](https://codeberg.org/forgejo/forgejo/attachments/b335c5b8-ad1a-44fc-bbd2-99c975c2a5e5), but will make the branch selector and select inputs usable again. In essence, replacing a serious bug with a less serious one. Note: max-height limit wasn't effective since it was clipping inline (x) axis instead of block (y) axis. So the menu was still higher than 500 px. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12753 Reviewed-by: Andreas Ahlenstorf --- web_src/css/actions.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web_src/css/actions.css b/web_src/css/actions.css index 82149378b9..e61fac84b7 100644 --- a/web_src/css/actions.css +++ b/web_src/css/actions.css @@ -177,8 +177,8 @@ white-space: nowrap; } #workflow_dispatch_dropdown .menu { + /* FIXME: max-height is ineffective without `overflow:`, but clipping overflow breaks dropdown menus */ max-height: 500px; - overflow-inline: auto; } @media (max-width: 640px) or (767.98px < width < 854px) { #workflow_dispatch_dropdown .menu {