From 68858a9de25f9efa2e1855044f3899756043cb77 Mon Sep 17 00:00:00 2001 From: oliverpool Date: Wed, 27 May 2026 20:44:44 +0200 Subject: [PATCH] fix: enable "Add more..." unit hint for new users (#12565) For new users, the `EnableRepoUnitHints` is set to false while I think that the original intent of #2221 was to set it to true (the migration set it to true for already existing users in `AddUserRepoUnitHintsSetting`). This PR sets its to true upon user creation. ![screenshot showing the `Add more...` hint - from the original PR](https://codeberg.org/forgejo/forgejo/attachments/dc654ddd-e7cb-4667-b0d3-3fac39776be3) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12565 Reviewed-by: limiting-factor Reviewed-by: 0ko <0ko@noreply.codeberg.org> --- models/user/user.go | 1 + tests/integration/signup_test.go | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/models/user/user.go b/models/user/user.go index 80843cfed9..ed47db0c0e 100644 --- a/models/user/user.go +++ b/models/user/user.go @@ -761,6 +761,7 @@ func createUser(ctx context.Context, u *User, createdByAdmin bool, overwriteDefa u.Theme = setting.UI.DefaultTheme u.IsRestricted = setting.Service.DefaultUserIsRestricted u.IsActive = !setting.Service.RegisterEmailConfirm && !setting.Service.RegisterManualConfirm + u.EnableRepoUnitHints = true // Ensure consistency of the dates. if u.UpdatedUnix < u.CreatedUnix { diff --git a/tests/integration/signup_test.go b/tests/integration/signup_test.go index eee022f7ab..f84b28b13f 100644 --- a/tests/integration/signup_test.go +++ b/tests/integration/signup_test.go @@ -36,6 +36,10 @@ func TestSignup(t *testing.T) { // should be able to view new user's page req = NewRequest(t, "GET", "/exampleUser") MakeRequest(t, req, http.StatusOK) + + // check default values + user := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "exampleUser"}) + assert.True(t, user.EnableRepoUnitHints) } func TestSignupAsRestricted(t *testing.T) {