mirror of
https://github.com/certbot/certbot.git
synced 2026-04-21 06:06:55 -04:00
f0f3cdad9c
in https://github.com/certbot/certbot/pull/9124 we had the problem of certbot-nginx's `Addr.fromstring` method possibly returning None which is not possible in the `Addr` method in the certbot base class or in certbot-apache. we fixed this by telling mypy the common `Addr.fromstring` method returns an `Optional[Addr]` (despite it actually always returning an `Addr`) and then unnecessarily complicating certbot-apache's code a bit. the need for extra complexity with this approach is going even further in https://github.com/certbot/certbot/pull/10151 where we have to use `cast` to assure mypy that the type isn't actually `Optional`. i personally don't like all this |
||
|---|---|---|
| .. | ||
| certbot_apache | ||
| LICENSE.txt | ||
| MANIFEST.in | ||
| README.rst | ||
| setup.py | ||
Apache plugin for Certbot