certbot/certbot-apache/certbot_apache/_internal
alexzorin 1e114b4ef8
apache: configure nameless vhosts during auth (#8898)
In the apache2 package on Debian-based distros, the default
000-default.conf virtual host does not include a ServerName.

Depending on the FQDN hostname of the machine and DNS setup, Apache
assigns a name to this unnamed vhost at runtime. As a result, the
Apache config end up with vhosts that have duplicative names.

Previously, Certbot did not identify that the nameless vhost could be
a match for the requested identifier, which would, depending on
configuration load order, cause the authenticator to fail.

This change causes Certbot to include all unnamed vhosts on top of
matched vhosts, during authentication. If no vhosts matched, the
existing behavior remains the same.

* apache: configure nameless vhosts during auth

* vhost is only unnamed if ServerName is not set

* also fix test to only match ServerName

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
2021-06-21 07:18:29 -04:00
..
augeas_lens Convert http links to https (#8287) 2020-09-23 19:36:55 +02:00
tls_configs Disable TLS session tickets in Apache (#7771) 2020-03-23 16:49:52 -07:00
__init__.py Make the contents of the apache plugin private (#7579) 2019-11-25 09:44:40 -08:00
apache_util.py Upgrade pylint (#8855) 2021-05-24 10:02:55 -07:00
apacheparser.py Use Python 3 style super (#8777) 2021-04-08 13:04:51 -07:00
assertions.py Upgrade pylint (#8855) 2021-05-24 10:02:55 -07:00
augeasparser.py Use Python 3 style super (#8777) 2021-04-08 13:04:51 -07:00
configurator.py Command-line UX overhaul (#8852) 2021-05-25 10:47:39 +10:00
constants.py Disable TLS session tickets in Apache (#7771) 2020-03-23 16:49:52 -07:00
display_ops.py Command-line UX overhaul (#8852) 2021-05-25 10:47:39 +10:00
dualparser.py Deprecate acme.typing_magic module, stop using it in certbot (#8643) 2021-03-09 16:12:32 -08:00
entrypoint.py certbot-apache: Add Void Linux overrides (#8891) 2021-06-12 17:02:16 +10:00
http_01.py apache: configure nameless vhosts during auth (#8898) 2021-06-21 07:18:29 -04:00
interfaces.py Use Python 3 style super (#8777) 2021-04-08 13:04:51 -07:00
obj.py Use Python 3 style super (#8777) 2021-04-08 13:04:51 -07:00
override_arch.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_centos.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_darwin.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_debian.py Command-line UX overhaul (#8852) 2021-05-25 10:47:39 +10:00
override_fedora.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_gentoo.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_suse.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
override_void.py certbot-apache: Add Void Linux overrides (#8891) 2021-06-12 17:02:16 +10:00
parser.py Define OS options by a dedicated object in Apache configurator (#8778) 2021-04-13 11:18:49 -07:00
parsernode_util.py Minor bugfixes (#7891) 2020-04-13 10:41:39 -07:00