certbot

mirror of https://github.com/certbot/certbot.git synced 2026-06-04 22:33:00 -04:00

History

Brad Warren c8828dab30 Move compatibility tests off of certbot-auto and Python 2 (#8248 ) Fixes https://github.com/certbot/certbot/issues/8162. I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Dockerfiles work. The most complicated changes here are in `testdata`. You can find a diff of the changes to `nginx.tar.gz` at https://gist.github.com/c7727db0cecf3f15f02439f085c73848. The first problem was that there were some complaints from the new Apache/nginx/OpenSSL version about the 1024 bit RSA key so I updated `empty_cert.pem` both inside and outside of the tarball as well as the corresponding private key in the tarball to use a 2048 bit key. The 2nd problem is trickier to understand. If you look at the output from nginx after loading the config from `lots/` you'll see it complaining about conflicting `server_name` directives for the directives I deleted. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2578&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e&t=9baa2014-9673-5e78-8f4f-7a463caf2bfa&l=1516. After switching the tests to Python 3, tests on that domain started failing. What I believe to be happening is we were just lucky these tests were passing to begin with. In both the Apache and Nginx plugin, if there are conflicting virtual hosts like this, we just arbitrarily pick one. The relevant code here for nginx is `575092d603/certbot-nginx/certbot_nginx/_internal/configurator.py (L455)` I played around with a debugger and confirmed that before I removed the conflicting server names, there were two exact matches for the domain we were searching for here. I think all that's going on is with the switch to Python 3, the vhost we happen to choose changes and "breaks" the test. I suspect this to be due to something like getting values out of a dict somewhere where the order of items in a dict while iterating over it is different between Python 2 and 3. I didn't track where this difference happens down, but I personally don't think it's a good use of time since I think the real problem here is that the nginx config being tested was invalid with conflicting `server` blocks. I removed all references to the `server_name` causing conflicts in that nginx configuration because both server blocks had other domains that are being tested, but I could add either back if you prefer. You can see the `nginx_compat` test passing with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=2587&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e. * update Dockerfile * Fix apache_compat on py3. * Update empty_cert.pem. The command used here was `openssl req -key certbot/certbot/tests/testdata/rsa2048_key.pem -new -subj '/CN=example.com' -x509 > certbot-compatibility-test/certbot_compatibility_test/testdata/empty_cert.pem`. * update nginx.tar.gz * Remove conflicting server_names		2020-09-09 15:16:52 -07:00
..
certbot_compatibility_test	Move compatibility tests off of certbot-auto and Python 2 (#8248 )	2020-09-09 15:16:52 -07:00
nginx	Reorganize imports (#7616 )	2019-12-09 15:50:20 -05:00
Dockerfile	Move compatibility tests off of certbot-auto and Python 2 (#8248 )	2020-09-09 15:16:52 -07:00
Dockerfile-apache	Add certbot-compatibility-test Dockerfiles	2016-08-10 16:08:30 -07:00
Dockerfile-nginx	Add certbot-compatibility-test Dockerfiles	2016-08-10 16:08:30 -07:00
LICENSE.txt	s/letsencrypt/certbot letsencrypt-compatibility-test	2016-04-13 16:58:21 -07:00
MANIFEST.in	Remove unused certbot-compatibility-test docs (#7577 )	2019-11-22 12:54:18 -08:00
README.rst	Rename misc files	2016-04-14 10:20:23 -07:00
setup.cfg	Tell the world we're Python 3 compatible (#4568 )	2017-04-28 16:06:45 -07:00
setup.py	Bump version to 1.9.0	2020-09-08 09:59:33 -07:00

README.rst

Compatibility tests for Certbot