Certificats Let's Encrypt
Find a file
Brad Warren b02deb339a
update actions in response to pull_request_target concerns (#10490)
this pr is in response to https://words.filippo.io/compromise-survey/.
ohemorange and i read this late on a friday to (speaking for myself at
least) much panic as it has some very strong words to say about the
github actions trigger pull_request_target which we use. looking into
the issue more, i also found that the popular static analysis tool
[zizmor](https://github.com/zizmorcore/zizmor) flags any github actions
workflow that uses the pull_request_target trigger with the message:

```
error[dangerous-triggers]: use of fundamentally insecure workflow trigger
pull_request_target is almost always used insecurely
```

this only added to my concern

the general problem with pull_request_target is that it runs with
additional privileges (e.g. potential write access, access to secrets)
in an environment containing values that can be set by an attacker.
these values include things such as references to the arbitrary code
contained in the triggering pr and pr titles which have been used to
perform shell injection attacks. not carefully treating these values
like the untrusted data it is while executing code in the privileged
environment given to pull_request_target has resulted in many supply
chain attacks

that's not to say that pull_request_target CAN'T be used securely.
zizmor even has [an
issue](https://github.com/zizmorcore/zizmor/issues/1168) brainstorming
how to not warn about all uses of the trigger as some are clearly fine
and the only way to accomplish what the user wants. i'm going to argue
that our uses of the trigger are ok

looking through the links provided by filippo's blog and [zizmor's
docs](https://docs.zizmor.sh/audits/#dangerous-triggers), i think we can
break down attacks used against pull_request_target into roughly 2
categories:

1. shell injection: "Nx S1ingularity" and "Ultralytics" from filippo's
blog
2. checking out and running a PR's code: "Kong Ingress Controller" and
"Rspack" from filippo's blog and https://ptrpa.ws/nixpkgs-actions-abuse
from zizmor docs

i think none of our pull_request_target workflows have these problems.
none of them use a shell (the [zizmor
issue](https://github.com/zizmorcore/zizmor/issues/1168) i linked
earlier suggests that any pull_request_target workflow that uses a run
block should always be flagged as insecure). instead, our workflows just
call action-mattermost-notify which can be [pretty easily
audited](https://github.com/mattermost/action-mattermost-notify/blob/2.0.0/src/main.js)
(as all the other files in the repo are boilerplate). passing possible
attacker controlled values directly to an action written in another
language is one of the approaches for mitigating script injection
[recommended by
github](https://docs.github.com/en/actions/reference/security/secure-use#use-an-action-instead-of-an-inline-script).
our workflows also do not check out the triggering pr's code

despite all that, i took this opportunity to cleanup and harden things a
bit. i reduced the permissions for each workflow and confirmed they each
still work on my fork. i also pinned the mattermost action to an exact
version and added some inline documentation

with these changes, our github workflows trigger few to no
warnings/errors when checked with zizmor,
[octoscan](https://github.com/synacktiv/octoscan), and [openssf
scorecard](https://github.com/ossf/scorecard)

if this pr is approved, i'll make similar changes to our josepy repo
2025-11-20 15:09:06 -08:00
.azure-pipelines Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
.github update actions in response to pull_request_target concerns (#10490) 2025-11-20 15:09:06 -08:00
acme Add san module (#10478) 2025-11-04 19:44:18 -08:00
certbot Initial IP address support: use san.SAN types internally (#10468) 2025-11-20 14:03:37 -08:00
certbot-apache Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-ci Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-compatibility-test Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-cloudflare Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-digitalocean Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-dnsimple Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-dnsmadeeasy Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-gehirn Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-google Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-linode Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-luadns Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-nsone Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-ovh Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-rfc2136 Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-route53 Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-dns-sakuracloud Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
certbot-nginx Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
letsencrypt-auto-source Restore le-auto, which should not be modified (#10351) 2025-06-24 21:07:55 +00:00
letstest Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
newsfragments Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
snap modify pyvenv.cfg instead of PYTHONPATH (#10384) 2025-08-01 11:55:38 -07:00
tests Rewrite lock_test.py (#9614) 2023-03-15 12:54:20 -07:00
tools Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
.coveragerc rewrite coverage tests (#9669) 2023-04-17 13:01:00 -07:00
.dockerignore Cleanup venv scripts (#8629) 2021-02-03 12:03:09 -08:00
.editorconfig Added an .editorconfig file. (#8297) 2020-09-19 11:39:13 +02:00
.gitattributes Merge pull request #2136 from tboegi/gitattributes_eol_overrideses_auto 2016-06-16 14:29:39 -07:00
.gitignore Drop in uv for pip (#10428) 2025-08-18 13:17:02 -07:00
.isort.cfg Add --use-pep517 flag to pip to silence warning in tools/venv.py, and switch codebase to src-layout (#10249) 2025-04-11 19:30:33 +00:00
.pylintrc Upgrade the pinned version of pylint (#9839) 2023-11-15 09:52:37 +01:00
AUTHORS.md Remove the dependency on pytz (#10350) 2025-07-28 08:00:16 -07:00
CHANGELOG.md Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
CODE_OF_CONDUCT.md Added a CODE_OF_CONDUCT.md file so Github doesn't complain 2019-04-17 11:36:26 -07:00
CONTRIBUTING.md [DOCS] Update CONTRIBUTING.md (#10220) 2025-03-04 19:01:39 -08:00
LICENSE.txt More stray ncrypt reference cleanup 2016-04-14 17:04:23 -07:00
linter_plugin.py Run ruff to fix test errors (#10398) 2025-08-07 22:10:02 +00:00
mypy.ini Run mypy with --strict on modules that are ready for it (#10166) 2025-01-30 23:11:31 +00:00
pytest.ini Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00
README.rst Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
ruff.toml use pep585 types everywhere and add a test (#10414) 2025-08-12 16:56:45 -07:00
SECURITY.md [REPO] Update SECURITY.md (#10253) 2025-05-06 10:57:50 -07:00
towncrier.toml Add towncrier for automatic changelog generation (#10379) 2025-07-31 07:12:56 -07:00
tox.ini Add python 3.14 support (#10481) 2025-11-04 10:49:51 -08:00

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

.. This file contains a series of comments that are used to include sections of this README in other files. Do not modify these comments unless you know what you are doing. tag:intro-begin

|build-status|

.. |build-status| image:: https://img.shields.io/azure-devops/build/certbot/ba534f81-a483-4b9b-9b4e-a60bec8fee72/5/main
   :target: https://dev.azure.com/certbot/certbot/_build?definitionId=5
   :alt: Azure Pipelines CI status

.. image:: https://raw.githubusercontent.com/EFForg/design/master/logos/certbot/eff-certbot-lockup.png
  :width: 200
  :alt: EFF Certbot Logo

Certbot is part of EFFs effort to encrypt the entire Internet. Secure communication over the Web relies on HTTPS, which requires the use of a digital certificate that lets browsers verify the identity of web servers (e.g., is that really google.com?). Web servers obtain their certificates from trusted third parties called certificate authorities (CAs). Certbot is an easy-to-use client that fetches a certificate from Lets Encrypt—an open certificate authority launched by the EFF, Mozilla, and others—and deploys it to a web server.

Anyone who has gone through the trouble of setting up a secure website knows what a hassle getting and maintaining a certificate is. Certbot and Lets Encrypt can automate away the pain and let you turn on and manage HTTPS with simple commands. Using Certbot and Let's Encrypt is free.

.. _installation:

Getting Started
---------------
The best way to get started is to use our `interactive guide <https://certbot.eff.org>`_. It generates instructions based on your configuration settings. In most cases, youll need `root or administrator access <https://certbot.eff.org/faq/#does-certbot-require-root-administrator-privileges>`_ to your web server to run Certbot.

Certbot is meant to be run directly on your web server on the command line, not on your personal computer. If youre using a hosted service and dont have direct access to your web server, you might not be able to use Certbot. Check with your hosting provider for documentation about uploading certificates or using certificates issued by Lets Encrypt.

Contributing
------------

If you'd like to contribute to this project please read `Developer Guide
<https://certbot.eff.org/docs/contributing.html>`_.

This project is governed by `EFF's Public Projects Code of Conduct <https://www.eff.org/pages/eppcode>`_.

Links
=====

.. Do not modify this comment unless you know what you're doing. tag:links-begin

Documentation: https://certbot.eff.org/docs

Software project: https://github.com/certbot/certbot

Changelog: https://github.com/certbot/certbot/blob/main/certbot/CHANGELOG.md

For Contributors: https://certbot.eff.org/docs/contributing.html

For Users: https://certbot.eff.org/docs/using.html

Main Website: https://certbot.eff.org

Let's Encrypt Website: https://letsencrypt.org

Community: https://community.letsencrypt.org

ACME spec: `RFC 8555 <https://tools.ietf.org/html/rfc8555>`_

ACME working area in github (archived): https://github.com/ietf-wg-acme/acme

.. Do not modify this comment unless you know what you're doing. tag:links-end

.. Do not modify this comment unless you know what you're doing. tag:intro-end

.. Do not modify this comment unless you know what you're doing. tag:features-begin

Current Features
=====================

* Supports multiple web servers:

  - Apache 2.4+
  - nginx/0.8.48+
  - webroot (adds files to webroot directories in order to prove control of
    domains and obtain certificates)
  - standalone (runs its own simple webserver to prove you control a domain)
  - other server software via `third party plugins <https://certbot.eff.org/docs/using.html#third-party-plugins>`_

* The private key is generated locally on your system.
* Can talk to the Let's Encrypt CA or optionally to other ACME
  compliant services.
* Can get domain-validated (DV) certificates.
* Can revoke certificates.
* Supports ECDSA (default) and RSA certificate private keys.
* Can optionally install a http -> https redirect, so your site effectively
  runs https only.
* Fully automated.
* Configuration changes are logged and can be reverted.

.. Do not modify this comment unless you know what you're doing. tag:features-end