mirror of
https://github.com/certbot/certbot.git
synced 2026-06-06 07:12:54 -04:00
7352727a65
It is about the exit codes that are returned from the various scripts in tools during tox execution. Indeed, tox relies on the non-zero exit code from a given script to know that something failed during the execution. Previously, theses scripts were in bash, and a bash script returns an exit code that is the higher code returned from any of the command executed by the script. So if any command return a non-zero (in particular pylint or pytest), then the script return also non-zero. Now that these scripts are converted into python, pylint and pytest are executed via subprocess, that returns the exit code as variables. But if theses codes are not handled explicitly, the python script itself will return zero if no python exception occured. As a consequence currently, Certbot CI system is unable to detect any test error or lint error, because there is no exception in this case, only exit codes from the binaries executed. This PR fixes that, by handling correctly the exit code from the most critical scripts, install_and_test.py and tox.cover.py, but also all the scripts that I converted into Python and that could be executed in the context of a shell (via tox or directly for instance). |
||
|---|---|---|
| .. | ||
| _release.sh | ||
| _venv_common.py | ||
| deactivate.py | ||
| deps.sh | ||
| dev_constraints.txt | ||
| docker-warning.sh | ||
| eff-pubkey.pem | ||
| half-sign.c | ||
| install_and_test.py | ||
| merge_requirements.py | ||
| offline-sigrequest.sh | ||
| oldest_constraints.txt | ||
| pip_install.py | ||
| pip_install_editable.py | ||
| readlink.py | ||
| release.sh | ||
| simple_http_server.py | ||
| sphinx-quickstart.sh | ||
| venv.py | ||
| venv3.py | ||