upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-08 08:12:15 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
certbot/acme
History
Brad Warren 5318945267 Hide exceptions that occur during session.close() (#4891) 
* Hide exceptions that occur during session.close()

This fixes #4840. Exceptions that are raised out of __del__ methods are caught
and printed to stderr. By catching any exceptions that occur, we now prevent
this from happening.

Alternative solutions to this would have been either not calling
session.close() at all or adding a close() method to acme.client.ClientNetwork,
acme.client.Client, and certbot.client.Client and using certbot.client.Client
in a context manager to ensure close() is called. The former means that users
of the ACME library never properly close their connections until their program
exits and the latter adds a lot of complexity and nesting of client code for
little benefit.

* Only catch Exceptions
2017-07-05 09:25:44 -04:00
..
acme Hide exceptions that occur during session.close() (#4891) 2017-07-05 09:25:44 -04:00
docs Remove the sphinxcontrib.programout [docs]dependency (#3830) 2016-11-30 10:47:10 -08:00
examples Remove Link rel=next for authzs and new-certs. (#4303) 2017-03-14 21:44:57 -07:00
LICENSE.txt Update Copyright notice in subpackages LICENSE. 2015-10-04 10:10:41 +00:00
MANIFEST.in MANIFEST: include examples dir for acme 2015-10-24 13:39:38 +00:00
README.rst Fix ACME module description 2015-10-21 17:06:35 -07:00
readthedocs.org.requirements.txt Per subpkg requirements.txt for RTD 2015-10-21 17:06:36 -07:00
setup.cfg Make wheel universal 2016-01-21 10:11:23 +01:00
setup.py Finish oldest tests (#4857) 2017-06-23 09:40:59 -07:00

README.rst 

ACME protocol implementation in Python