Certificats Let's Encrypt
Find a file
Adrien Ferrand 50fa04ba0c
Implement umask for Windows (#7967)
This PR gets its root from an observation I did on current version of Certbot (1.3.0): the `renewal-hooks` directory in Certbot configuration directory is created on Windows with write permissions to everybody.

I thought it was a critical bug since this directory contains hooks that are executed by Certbot, and you certainly do not want this folder to be open to any malicious hook that could be inserted by everyone, then executed with administrator privileges by Certbot.

Turns out for this specific problem that the bug is not critical for the hooks, because the scripts are expected to be in subdirectories of `renewal-hooks` (namely `pre`, `post` and `deploy`), and these subdirectories have proper permissions because we set them explicitly when Certbot is starting.

Still, there is a divergence here between Linux and Windows: on Linux all Certbot directories without explicit permissions have at maximum `0o755` permissions by default, while on Windows it is a `0o777` equivalent. It is not an immediate security risk, but it is definitly error-prone, not expected, and so a potential breach in the future if we forget about it.

Root cause is that umask is not existing in Windows. Indeed under Linux the umask defines the default permissions when you create a file or a directory. Python takes that into account, with an API for `os.open` and `os.mkdir` that expose a `mode` parameter with default value of `0o777`. In practice it is never `0o777` (either you the the `mode` explictly or left the default one) because the effective mode is masked by the current umask value in the system: on Linux it is `0o022`, so files/directories have a maximum mode of `0o755` if you did not set the umask explicitly, and it is what it is observed for Certbot.

However on Windows, the `mode` value passed (and got from default) to the `open` and `mkdir` of `certbot.compat.filesystem` module is taken verbatim, since umask does not exit, and then is used to calculate the DACL of the newly created file/directory. So if the mode is not set explicitly, we end up with files and directories with `0o777` permissions.

This PR fixes this problem by implementing a umask behavior in the `certbot.compat.filesystem` module, that will be applied to any file or directory created by Certbot since we forbid to use the `os` module directly.

The implementation is quite straight-forward. For Linux the behavior is not changed. On Windows a `mask` parameter is added to the function that calculates the DACL, to be invoked appropriately when file or directory are created. The actual value of the mask is taken from an internal class of the `filesystem` module: its default value is `0o755` to match default umasks on Linux, and can be changed with the new method `umask` that have the same behavior than the original `os.umask`. Of course `os.umask` becomes a forbidden function and `filesystem.umask` must be used instead.

Existing code that is impacted have been updated, and new unit tests are created for this new function.

* Implement umask for Windows

* Set umask at the beginning of tests

* Fix lint, update local oldest requirements

* Update certbot-apache/setup.py

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>

* Improve tests

* Adapt filesystem.makedirs for Windows

* Fix

* Update certbot-apache/setup.py

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>

* Changelog entries

* Fix lint

* Update certbot/CHANGELOG.md

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>

Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
2020-06-09 17:08:22 -07:00
.azure-pipelines Remove references to the apache-parser-v2 branch (#7925) 2020-04-21 13:06:30 -07:00
.github Improve issue closing behavior. (#7178) 2019-06-24 16:39:45 -07:00
acme Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot Implement umask for Windows (#7967) 2020-06-09 17:08:22 -07:00
certbot-apache Implement umask for Windows (#7967) 2020-06-09 17:08:22 -07:00
certbot-ci Run hooks with Powershell on Windows (#7800) 2020-04-27 09:38:30 -07:00
certbot-compatibility-test Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-cloudflare Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-cloudxns Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-digitalocean Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-dnsimple Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-dnsmadeeasy Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-gehirn Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-google Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-linode Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-luadns Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-nsone Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-ovh Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-rfc2136 Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-route53 Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-dns-sakuracloud Bump version to 1.6.0 2020-06-02 10:32:41 -07:00
certbot-nginx Add support for NetBSD (#8033) 2020-06-08 12:06:38 -07:00
letsencrypt-auto-source Upgrade Certbot dependencies (#8036) 2020-06-04 08:59:45 -07:00
snap Stop running snapcraft with sudo (#8063) 2020-06-09 14:46:11 -07:00
tests Fix TLS-ALPN tests with newer versions of OpenSSL (#8026) 2020-06-01 15:18:38 -07:00
tools Add comment about pyca's use of tools script (#8044) 2020-06-08 12:14:02 -07:00
windows-installer Minor bugfixes (#7891) 2020-04-13 10:41:39 -07:00
.coveragerc Get integration tests working on python 3.8 (#7372) 2019-09-16 14:14:26 -04:00
.dockerignore Update ignore files to remove shared tox.venv 2015-07-12 15:30:51 +00:00
.gitattributes Merge pull request #2136 from tboegi/gitattributes_eol_overrideses_auto 2016-06-16 14:29:39 -07:00
.gitignore Merge snap code into the Certbot repo 2020-04-24 13:47:36 -07:00
.isort.cfg Reorganize imports (#7616) 2019-12-09 15:50:20 -05:00
.pylintrc Lint certbot code on Python 3, and update Pylint to the latest version (#7551) 2019-12-10 14:12:50 -08:00
.travis.yml Merge pull request #7948 from certbot/snap-build-squashed 2020-04-24 14:13:09 -07:00
AUTHORS.md Fix certbot.compat.filesystem documentation (#8058) 2020-06-08 14:00:16 -07:00
certbot-auto Release 1.5.0 2020-06-02 10:32:38 -07:00
CHANGELOG.md Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
CODE_OF_CONDUCT.md Added a CODE_OF_CONDUCT.md file so Github doesn't complain 2019-04-17 11:36:26 -07:00
CONTRIBUTING.md Adding the EFF Public Projects Code of Conduct to the contributing guide 2019-04-16 16:28:32 -07:00
docker-compose.yml Cleanup dockerfile-dev (#5435) 2018-02-16 09:51:27 -08:00
Dockerfile-dev Lint certbot code on Python 3, and update Pylint to the latest version (#7551) 2019-12-10 14:12:50 -08:00
ISSUE_TEMPLATE.md Suggest people try the community forum. (#5561) 2018-02-09 16:41:05 -08:00
letsencrypt-auto Release 1.5.0 2020-06-02 10:32:38 -07:00
LICENSE.txt More stray ncrypt reference cleanup 2016-04-14 17:04:23 -07:00
linter_plugin.py Remove letshelp-certbot (#7761) 2020-02-14 17:19:19 -08:00
mypy.ini Remove letshelp-certbot (#7761) 2020-02-14 17:19:19 -08:00
pull_request_template.md Don't list adding type annotations as a PR req. (#7627) 2019-12-04 20:22:10 +01:00
pytest.ini Add warning about ignoring our own warnings (#7971) 2020-05-04 16:54:09 -07:00
README.rst Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
tox.cover.py drop min certbot coverage (#7972) 2020-05-05 09:38:20 -07:00
tox.ini Merge snap code into the Certbot repo 2020-04-24 13:47:36 -07:00

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

.. This file contains a series of comments that are used to include sections of this README in other files. Do not modify these comments unless you know what you are doing. tag:intro-begin

Certbot is part of EFFs effort to encrypt the entire Internet. Secure communication over the Web relies on HTTPS, which requires the use of a digital certificate that lets browsers verify the identity of web servers (e.g., is that really google.com?). Web servers obtain their certificates from trusted third parties called certificate authorities (CAs). Certbot is an easy-to-use client that fetches a certificate from Lets Encrypt—an open certificate authority launched by the EFF, Mozilla, and others—and deploys it to a web server.

Anyone who has gone through the trouble of setting up a secure website knows what a hassle getting and maintaining a certificate is. Certbot and Lets Encrypt can automate away the pain and let you turn on and manage HTTPS with simple commands. Using Certbot and Let's Encrypt is free, so theres no need to arrange payment.

How you use Certbot depends on the configuration of your web server. The best way to get started is to use our `interactive guide <https://certbot.eff.org>`_. It generates instructions based on your configuration settings. In most cases, youll need `root or administrator access <https://certbot.eff.org/faq/#does-certbot-require-root-administrator-privileges>`_ to your web server to run Certbot.

Certbot is meant to be run directly on your web server, not on your personal computer. If youre using a hosted service and dont have direct access to your web server, you might not be able to use Certbot. Check with your hosting provider for documentation about uploading certificates or using certificates issued by Lets Encrypt.

Certbot is a fully-featured, extensible client for the Let's
Encrypt CA (or any other CA that speaks the `ACME
<https://github.com/ietf-wg-acme/acme/blob/master/draft-ietf-acme-acme.md>`_
protocol) that can automate the tasks of obtaining certificates and
configuring webservers to use them. This client runs on Unix-based operating
systems.

To see the changes made to Certbot between versions please refer to our
`changelog <https://github.com/certbot/certbot/blob/master/certbot/CHANGELOG.md>`_.

Until May 2016, Certbot was named simply ``letsencrypt`` or ``letsencrypt-auto``,
depending on install method. Instructions on the Internet, and some pieces of the
software, may still refer to this older name.

Contributing
------------

If you'd like to contribute to this project please read `Developer Guide
<https://certbot.eff.org/docs/contributing.html>`_.

This project is governed by `EFF's Public Projects Code of Conduct <https://www.eff.org/pages/eppcode>`_.

.. _installation:

How to run the client
---------------------

The easiest way to install and run Certbot is by visiting `certbot.eff.org`_,
where you can find the correct instructions for many web server and OS
combinations.  For more information, see `Get Certbot
<https://certbot.eff.org/docs/install.html>`_.

.. _certbot.eff.org: https://certbot.eff.org/

Understanding the client in more depth
--------------------------------------

To understand what the client is doing in detail, it's important to
understand the way it uses plugins.  Please see the `explanation of
plugins <https://certbot.eff.org/docs/using.html#plugins>`_ in
the User Guide.

Links
=====

.. Do not modify this comment unless you know what you're doing. tag:links-begin

Documentation: https://certbot.eff.org/docs

Software project: https://github.com/certbot/certbot

Notes for developers: https://certbot.eff.org/docs/contributing.html

Main Website: https://certbot.eff.org

Let's Encrypt Website: https://letsencrypt.org

Community: https://community.letsencrypt.org

ACME spec: http://ietf-wg-acme.github.io/acme/

ACME working area in github: https://github.com/ietf-wg-acme/acme

|build-status|

.. |build-status| image:: https://travis-ci.com/certbot/certbot.svg?branch=master
   :target: https://travis-ci.com/certbot/certbot
   :alt: Travis CI status

.. Do not modify this comment unless you know what you're doing. tag:links-end

System Requirements
===================

See https://certbot.eff.org/docs/install.html#system-requirements.

.. Do not modify this comment unless you know what you're doing. tag:intro-end

.. Do not modify this comment unless you know what you're doing. tag:features-begin

Current Features
=====================

* Supports multiple web servers:

  - apache/2.x
  - nginx/0.8.48+
  - webroot (adds files to webroot directories in order to prove control of
    domains and obtain certs)
  - standalone (runs its own simple webserver to prove you control a domain)
  - other server software via `third party plugins <https://certbot.eff.org/docs/using.html#third-party-plugins>`_

* The private key is generated locally on your system.
* Can talk to the Let's Encrypt CA or optionally to other ACME
  compliant services.
* Can get domain-validated (DV) certificates.
* Can revoke certificates.
* Adjustable RSA key bit-length (2048 (default), 4096, ...).
* Can optionally install a http -> https redirect, so your site effectively
  runs https only (Apache only)
* Fully automated.
* Configuration changes are logged and can be reverted.
* Supports an interactive text UI, or can be driven entirely from the
  command line.
* Free and Open Source Software, made with Python.

.. Do not modify this comment unless you know what you're doing. tag:features-end

For extensive documentation on using and contributing to Certbot, go to https://certbot.eff.org/docs. If you would like to contribute to the project or run the latest code from git, you should read our `developer guide <https://certbot.eff.org/docs/contributing.html>`_.