mirror of
https://github.com/certbot/certbot.git
synced 2026-03-12 13:42:09 -04:00
2ac99fefe0
This PR is a part of the actions necessary to make Certbot-CI work on Windows, in order to execute the integration tests on this platform. Following #7156, this PR changes how the integration tests are setup against Pebble to not need Docker anymore. As a reminder, one can check #7156 and letsencrypt/pebble#240 to see the rationale about why using Docker is a problem to run the integration tests on Windows. Basically, this PR executes directly Pebble using its executable, since it is build using Go, and Go produces self-contained executable that can run without any installation on Linux and on Windows. During the integration tests setup, Certbot-CI will get the Pebble (and Challtestsrv) executables for the defined target version on the GitHub releases. The binaries are persisted on the filesystem, so it is not needed to download them again on the second integration tests execution. Nonetheless, we are talking about 20MB of executables. Since the setup needs to hold a state, I also took this occasion to refactor the acme_server, in order to use on object oriented approach and improve the readability/maintainability. Once this PR and #7156 are merged, Docker will not be needed anymore for the main integration tests usecase, that is to use Pebble. * Complete process * Fix nginx cert path * Check conditionnally docker * Update gitignore, fix apacheconftest * Full object * Carriage return * Move to official v2.1.0 of pebble * Fix name * Update acme_server.py * Relaunch CI * Update certbot-ci/certbot_integration_tests/utils/acme_server.py Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update certbot-ci/certbot_integration_tests/utils/acme_server.py Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update docstring * Update documentation * Configure a stdout to ACMEServer * Map all process through defined stdout * Remove unused variable * Handle using signals * Use failsafe entering context * Remove failsafe rmtree, that is not needed anymore |
||
|---|---|---|
| .. | ||
| augeas_lens | ||
| tests | ||
| __init__.py | ||
| apache_util.py | ||
| centos-options-ssl-apache.conf | ||
| configurator.py | ||
| constants.py | ||
| display_ops.py | ||
| entrypoint.py | ||
| http_01.py | ||
| obj.py | ||
| options-ssl-apache.conf | ||
| override_arch.py | ||
| override_centos.py | ||
| override_darwin.py | ||
| override_debian.py | ||
| override_fedora.py | ||
| override_gentoo.py | ||
| override_suse.py | ||
| parser.py | ||