Certificats Let's Encrypt
Find a file
ohemorange 035a6dcc39
Actually set FAILED_DOMAINS and RENEWED_DOMAINS variables when renewals fail (#10347)
Fixes https://github.com/certbot/certbot/issues/10259

This PR moves post-hook execution from `main.renew` to
`renewal.handle_renewal_request` so that failed and renewed domains
actually get passed into post-hook execution as promised, even when
failures happened.

I suspect the original PR was being overly cautious by putting the whole
thing into a try/finally so that post-hooks definitely happen, but
`handle_renewal_request` is already full of exception catching. I
understand the worry about executing a pre-hook and then failing to
execute its matching post-hook, but the code really is already
structured to make sure that that won't happen. And then when we added
`FAILED_DOMAINS` and `RENEWED_DOMAINS`, we both kept that
overly-cautious hooks execution location, but also kept the error so we
have a summary at the end...which meant that if failures happened, the
env vars were never set.

If we really want to keep the `hooks.run_saved_post_hooks` call on the
outside of everything in main, we can, but then we will have to do one
of the following:
- pass in the output lists to be filled out during execution. not my
favorite pattern
- throw the output lists in the error object or make a wrapper error,
not sure, haven't looked at `errors.py` too closely
- stop raising that final error where we report failures at the very
bottom. it's a little outdated maybe but I do like it and I think people
are used to it
- raise that error in main, returning the number of parse and renewal
failures. this is my favorite of the options, but I still like it less
than what I've implemented here.

Here's the integration/regression test failing on main:

https://dev.azure.com/certbot/certbot/_build/results?buildId=9237&view=logs&j=fca58cec-e7ce-563a-f36f-5c233894d750
You can see here that that branch just has the integration test without
the fix (and removing other tests for efficiency):
https://github.com/certbot/certbot/compare/main...test-fail-env-on-main

It's the default, but just to be clear, this should definitely have two
reviewers.
2025-06-20 07:42:20 -07:00
.azure-pipelines Remove manual mattermost notification on azure failure code (#10330) 2025-06-12 12:40:07 -07:00
.github Add template for code maintenance task (#10251) 2025-03-28 16:41:50 +00:00
acme Merge pull request #10341 from certbot/candidate-4.1.1 2025-06-12 13:40:50 -07:00
certbot Actually set FAILED_DOMAINS and RENEWED_DOMAINS variables when renewals fail (#10347) 2025-06-20 07:42:20 -07:00
certbot-apache Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-ci Actually set FAILED_DOMAINS and RENEWED_DOMAINS variables when renewals fail (#10347) 2025-06-20 07:42:20 -07:00
certbot-compatibility-test Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-cloudflare Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-digitalocean Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-dnsimple Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-dnsmadeeasy Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-gehirn Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-google Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-linode Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-luadns Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-nsone Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-ovh Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-rfc2136 Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-route53 Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-dns-sakuracloud Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
certbot-nginx Bump version to 5.0.0 2025-06-12 11:09:58 -07:00
letsencrypt-auto-source Add documentation about legacy cb-auto files (#9011) 2021-09-09 13:21:47 -07:00
letstest upgrade python-augeas (#10286) 2025-05-08 13:03:31 -07:00
snap Add --use-pep517 flag to pip to silence warning in tools/venv.py, and switch codebase to src-layout (#10249) 2025-04-11 19:30:33 +00:00
tests Rewrite lock_test.py (#9614) 2023-03-15 12:54:20 -07:00
tools upgrade python-augeas (#10286) 2025-05-08 13:03:31 -07:00
.coveragerc rewrite coverage tests (#9669) 2023-04-17 13:01:00 -07:00
.dockerignore Cleanup venv scripts (#8629) 2021-02-03 12:03:09 -08:00
.editorconfig Added an .editorconfig file. (#8297) 2020-09-19 11:39:13 +02:00
.gitattributes Merge pull request #2136 from tboegi/gitattributes_eol_overrideses_auto 2016-06-16 14:29:39 -07:00
.gitignore Ignore sublime project files (#10165) 2025-01-29 13:26:44 -08:00
.isort.cfg Add --use-pep517 flag to pip to silence warning in tools/venv.py, and switch codebase to src-layout (#10249) 2025-04-11 19:30:33 +00:00
.pylintrc Upgrade the pinned version of pylint (#9839) 2023-11-15 09:52:37 +01:00
AUTHORS.md added to authors 2024-12-16 15:30:42 -05:00
CHANGELOG.md Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
CODE_OF_CONDUCT.md Added a CODE_OF_CONDUCT.md file so Github doesn't complain 2019-04-17 11:36:26 -07:00
CONTRIBUTING.md [DOCS] Update CONTRIBUTING.md (#10220) 2025-03-04 19:01:39 -08:00
LICENSE.txt More stray ncrypt reference cleanup 2016-04-14 17:04:23 -07:00
linter_plugin.py Add --use-pep517 flag to pip to silence warning in tools/venv.py, and switch codebase to src-layout (#10249) 2025-04-11 19:30:33 +00:00
mypy.ini Run mypy with --strict on modules that are ready for it (#10166) 2025-01-30 23:11:31 +00:00
pytest.ini Deprecate parameter enforce_openssl_binary_usage (#10300) 2025-05-29 13:28:48 -07:00
README.rst Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
SECURITY.md [REPO] Update SECURITY.md (#10253) 2025-05-06 10:57:50 -07:00
tox.ini Add --use-pep517 flag to pip to silence warning in tools/venv.py, and switch codebase to src-layout (#10249) 2025-04-11 19:30:33 +00:00

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

.. This file contains a series of comments that are used to include sections of this README in other files. Do not modify these comments unless you know what you are doing. tag:intro-begin

|build-status|

.. |build-status| image:: https://img.shields.io/azure-devops/build/certbot/ba534f81-a483-4b9b-9b4e-a60bec8fee72/5/main
   :target: https://dev.azure.com/certbot/certbot/_build?definitionId=5
   :alt: Azure Pipelines CI status

.. image:: https://raw.githubusercontent.com/EFForg/design/master/logos/certbot/eff-certbot-lockup.png
  :width: 200
  :alt: EFF Certbot Logo

Certbot is part of EFFs effort to encrypt the entire Internet. Secure communication over the Web relies on HTTPS, which requires the use of a digital certificate that lets browsers verify the identity of web servers (e.g., is that really google.com?). Web servers obtain their certificates from trusted third parties called certificate authorities (CAs). Certbot is an easy-to-use client that fetches a certificate from Lets Encrypt—an open certificate authority launched by the EFF, Mozilla, and others—and deploys it to a web server.

Anyone who has gone through the trouble of setting up a secure website knows what a hassle getting and maintaining a certificate is. Certbot and Lets Encrypt can automate away the pain and let you turn on and manage HTTPS with simple commands. Using Certbot and Let's Encrypt is free.

.. _installation:

Getting Started
---------------
The best way to get started is to use our `interactive guide <https://certbot.eff.org>`_. It generates instructions based on your configuration settings. In most cases, youll need `root or administrator access <https://certbot.eff.org/faq/#does-certbot-require-root-administrator-privileges>`_ to your web server to run Certbot.

Certbot is meant to be run directly on your web server on the command line, not on your personal computer. If youre using a hosted service and dont have direct access to your web server, you might not be able to use Certbot. Check with your hosting provider for documentation about uploading certificates or using certificates issued by Lets Encrypt.

Contributing
------------

If you'd like to contribute to this project please read `Developer Guide
<https://certbot.eff.org/docs/contributing.html>`_.

This project is governed by `EFF's Public Projects Code of Conduct <https://www.eff.org/pages/eppcode>`_.

Links
=====

.. Do not modify this comment unless you know what you're doing. tag:links-begin

Documentation: https://certbot.eff.org/docs

Software project: https://github.com/certbot/certbot

Changelog: https://github.com/certbot/certbot/blob/main/certbot/CHANGELOG.md

For Contributors: https://certbot.eff.org/docs/contributing.html

For Users: https://certbot.eff.org/docs/using.html

Main Website: https://certbot.eff.org

Let's Encrypt Website: https://letsencrypt.org

Community: https://community.letsencrypt.org

ACME spec: `RFC 8555 <https://tools.ietf.org/html/rfc8555>`_

ACME working area in github (archived): https://github.com/ietf-wg-acme/acme

.. Do not modify this comment unless you know what you're doing. tag:links-end

.. Do not modify this comment unless you know what you're doing. tag:intro-end

.. Do not modify this comment unless you know what you're doing. tag:features-begin

Current Features
=====================

* Supports multiple web servers:

  - Apache 2.4+
  - nginx/0.8.48+
  - webroot (adds files to webroot directories in order to prove control of
    domains and obtain certificates)
  - standalone (runs its own simple webserver to prove you control a domain)
  - other server software via `third party plugins <https://certbot.eff.org/docs/using.html#third-party-plugins>`_

* The private key is generated locally on your system.
* Can talk to the Let's Encrypt CA or optionally to other ACME
  compliant services.
* Can get domain-validated (DV) certificates.
* Can revoke certificates.
* Supports ECDSA (default) and RSA certificate private keys.
* Can optionally install a http -> https redirect, so your site effectively
  runs https only.
* Fully automated.
* Configuration changes are logged and can be reverted.

.. Do not modify this comment unless you know what you're doing. tag:features-end