mirror of
https://github.com/certbot/certbot.git
synced 2026-06-07 15:52:08 -04:00
fc7e5e8e60
As pylint is evolving, it improves its accuracy, and several pylint error suppression (`# pylint: disable=ERROR) added in certbot codebase months or years ago are not needed anymore to make it happy. There is a (disabled by default) pylint error to detect the useless suppressions (pylint-ception: `useless-suppression`). It is not working perfectly (it has also false-positives ...) but it is a good start to clean the codebase. This PR removes several of these useless suppressions as detected by the current pylint version we use. * Remove useless suppress * Remove useless lines
41 lines
1.5 KiB
Python
41 lines
1.5 KiB
Python
"""Tests for letshelp_certbot.magic_typing."""
|
|
import sys
|
|
import unittest
|
|
|
|
import mock
|
|
|
|
|
|
class MagicTypingTest(unittest.TestCase):
|
|
"""Tests for letshelp_certbot.magic_typing."""
|
|
def test_import_success(self):
|
|
try:
|
|
import typing as temp_typing
|
|
except ImportError: # pragma: no cover
|
|
temp_typing = None # pragma: no cover
|
|
typing_class_mock = mock.MagicMock()
|
|
text_mock = mock.MagicMock()
|
|
typing_class_mock.Text = text_mock
|
|
sys.modules['typing'] = typing_class_mock
|
|
if 'letshelp_certbot.magic_typing' in sys.modules:
|
|
del sys.modules['letshelp_certbot.magic_typing'] # pragma: no cover
|
|
from letshelp_certbot.magic_typing import Text
|
|
self.assertEqual(Text, text_mock)
|
|
del sys.modules['letshelp_certbot.magic_typing']
|
|
sys.modules['typing'] = temp_typing
|
|
|
|
def test_import_failure(self):
|
|
try:
|
|
import typing as temp_typing
|
|
except ImportError: # pragma: no cover
|
|
temp_typing = None # pragma: no cover
|
|
sys.modules['typing'] = None
|
|
if 'letshelp_certbot.magic_typing' in sys.modules:
|
|
del sys.modules['letshelp_certbot.magic_typing'] # pragma: no cover
|
|
from letshelp_certbot.magic_typing import Text
|
|
self.assertTrue(Text is None)
|
|
del sys.modules['letshelp_certbot.magic_typing']
|
|
sys.modules['typing'] = temp_typing
|
|
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main() # pragma: no cover
|