mirror of
https://github.com/certbot/certbot.git
synced 2026-06-08 16:22:18 -04:00
* Implement certbot services * Various fixes * Local oldest requirements * Clean imports * Add unit tests for certbot.services * Clean code * Protect against nullity of global services * Fix CLI * Fix tests * Consistent test behavior * Define new ABC classes * Reimplement services with new ABC classes * Adapt plugins discovery and selection * Remove zope interfaces from plugins * Re-enable delegation for simplicity * Fix interfaces declaration * Remove interface implementer * Interfaces ordering * Extract zope logic from discovery * Cleanup imports * Fixing tests * Fix main_test * Finish certbot unit tests * Fix lint * Various fixes thanks to mypy * Fix lint * Order imports * Various fixes * Clean code * Remove reporter service, migrate display service in certbot.display.util. * Fix test * Fix apache compatibility test * Fix oldest test * Setup certbot.display.service module * Reintegrate in util * Fix imports * Fix tests and documentation * Refactor * Cleanup * Cleanup * Clean imports * Add unit tests * Borrow sphinx build fix from #8863 * Align zope interfaces on ABC * Various fixes * Fix type * Fix type * Some cleanup * Fix lint * Update certbot/certbot/_internal/configuration.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update certbot/certbot/_internal/configuration.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Fix imports * Fix Config contract (accounts_dir property) * Remove unnecessary interface * Set NamespaceConfig public, remove Config interface * Remove Display ABC and implementation of IDisplay * Clean lint * Cleanup old decorators * Contract on plugin constructor only * Update certbot/certbot/tests/util.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update certbot/certbot/configuration.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update certbot/certbot/interfaces.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Some corrections * Add changelog * Fix --authenticators and --installers flags on plugins subcommand * Fix multiheritance on the interface Plugin * Update certbot/certbot/_internal/plugins/manual.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update certbot/certbot/_internal/plugins/disco.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Add warnings in logger also * Add deprecation warnings also when plugins are verified. Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
108 lines
3.8 KiB
Python
108 lines
3.8 KiB
Python
"""Provides a common base for Apache proxies"""
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
from unittest import mock
|
|
|
|
import zope.interface
|
|
|
|
from certbot import errors as le_errors, configuration
|
|
from certbot import util as certbot_util
|
|
from certbot_apache._internal import entrypoint
|
|
from certbot_compatibility_test import errors
|
|
from certbot_compatibility_test import interfaces
|
|
from certbot_compatibility_test import util
|
|
from certbot_compatibility_test.configurators import common as configurators_common
|
|
|
|
|
|
@zope.interface.implementer(interfaces.IConfiguratorProxy)
|
|
class Proxy(configurators_common.Proxy):
|
|
"""A common base for Apache test configurators"""
|
|
|
|
def __init__(self, args):
|
|
"""Initializes the plugin with the given command line args"""
|
|
super().__init__(args)
|
|
self.le_config.apache_le_vhost_ext = "-le-ssl.conf"
|
|
|
|
self.modules = self.server_root = self.test_conf = self.version = None
|
|
patch = mock.patch(
|
|
"certbot_apache._internal.configurator.display_ops.select_vhost")
|
|
mock_display = patch.start()
|
|
mock_display.side_effect = le_errors.PluginError(
|
|
"Unable to determine vhost")
|
|
|
|
def load_config(self):
|
|
"""Loads the next configuration for the plugin to test"""
|
|
config = super().load_config()
|
|
self._all_names, self._test_names = _get_names(config)
|
|
|
|
server_root = _get_server_root(config)
|
|
shutil.rmtree("/etc/apache2")
|
|
shutil.copytree(server_root, "/etc/apache2", symlinks=True)
|
|
|
|
self._prepare_configurator()
|
|
|
|
try:
|
|
subprocess.check_call("apachectl -k restart".split())
|
|
except errors.Error:
|
|
raise errors.Error(
|
|
"Apache failed to load {0} before tests started".format(
|
|
config))
|
|
|
|
return config
|
|
|
|
def _prepare_configurator(self):
|
|
"""Prepares the Apache plugin for testing"""
|
|
for k in entrypoint.ENTRYPOINT.OS_DEFAULTS.__dict__.keys():
|
|
setattr(self.le_config, "apache_" + k,
|
|
getattr(entrypoint.ENTRYPOINT.OS_DEFAULTS, k))
|
|
|
|
self._configurator = entrypoint.ENTRYPOINT(
|
|
config=configuration.NamespaceConfig(self.le_config),
|
|
name="apache")
|
|
self._configurator.prepare()
|
|
|
|
def cleanup_from_tests(self):
|
|
"""Performs any necessary cleanup from running plugin tests"""
|
|
super().cleanup_from_tests()
|
|
mock.patch.stopall()
|
|
|
|
|
|
def _get_server_root(config):
|
|
"""Returns the server root directory in config"""
|
|
subdirs = [
|
|
name for name in os.listdir(config)
|
|
if os.path.isdir(os.path.join(config, name))]
|
|
|
|
if len(subdirs) != 1:
|
|
errors.Error("Malformed configuration directory {0}".format(config))
|
|
|
|
return os.path.join(config, subdirs[0].rstrip())
|
|
|
|
|
|
def _get_names(config):
|
|
"""Returns all and testable domain names in config"""
|
|
all_names = set()
|
|
non_ip_names = set()
|
|
with open(os.path.join(config, "vhosts")) as f:
|
|
for line in f:
|
|
# If parsing a specific vhost
|
|
if line[0].isspace():
|
|
words = line.split()
|
|
if words[0] == "alias":
|
|
all_names.add(words[1])
|
|
non_ip_names.add(words[1])
|
|
# If for port 80 and not IP vhost
|
|
elif words[1] == "80" and not util.IP_REGEX.match(words[3]):
|
|
all_names.add(words[3])
|
|
non_ip_names.add(words[3])
|
|
elif "NameVirtualHost" not in line:
|
|
words = line.split()
|
|
if (words[0].endswith("*") or words[0].endswith("80") and
|
|
not util.IP_REGEX.match(words[1]) and
|
|
words[1].find(".") != -1):
|
|
all_names.add(words[1])
|
|
return (
|
|
certbot_util.get_filtered_names(all_names),
|
|
certbot_util.get_filtered_names(non_ip_names)
|
|
)
|