mirror of
https://github.com/certbot/certbot.git
synced 2026-06-06 15:22:38 -04:00
Fixes #7007 Python 3.4 is [EOL](https://www.python.org/dev/peps/pep-0429/), and only Python 3.x version available for CentOS 6 through EPEL is this version, and so is used by `certbot-auto`, the only official way to install Certbot on this platform. This unpleasant situation becomes a little more uncomfortable, considering that the newest `pip` version (19.2) [just dropped Python 3.4 support](https://github.com/pypa/pip/issues/6685) and will refuse to start on this Python version. We can expect a lot of dependencies to follow this path now. One direct result of this situation is that a fix to support correctly the ARM platforms requires to upgrade `pip` to 19.2 for `certbot-auto`. So this is not possible right now. Then, let's upgrade Certbot instances on CentOS 6 to a supported version of Python 3. This PR proposes a new bootstrap approach for CentOS 6 platform, `BootstrapRpmPython3Legacy`, that will install Python 3.6 from [SCL](https://www.softwarecollections.org) (the latest one available for now on CentOS 6). In term of Python 3 specific bootstrap methods, I take the occasion here to completely separate the bootstrap of CentOS 6 as a legacy system, from the RPM-based newest systems (like Fedora 29+) that are simply dropping support for Python 2.x. This is in prevision of future migration for all systems on Python 3.x, that is a different problematic than supporting old systems. * Add logic * Rebuilt letsencrypt-auto * Fix logic * Focus on specific packages * Maintain PATH for further invocations of letsencrypt-auto after bootstrap. * Various corrections * Fix farm test for RHEL6 * Working centos6 letsencrypt-auto self tests * Fix test_sdist for CentOS 6 * Corrections * Work in progress * Working configuration * Fix typo * Remove EPEL. Add a test. * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Improvements after review * Improvements * Add a comment * Add a test * Update a test * Corrections * Update function return * Work in progress * Correct behavior on oracle linux 6. * Corrections * Rebuild script * Add letsencrypt-auto tests for oraclelinux6 * Update tox.ini Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Remove specific code for scientific linux * Change some variables names * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Various corrections * Fix tests * Add a comment * Update message * Fix test message * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update scripts * More focused assertion * Add back a test * Update script * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Check quiet mode * Add changelog * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
140 lines
4.8 KiB
Bash
140 lines
4.8 KiB
Bash
#!/bin/bash
|
|
# Start by making sure your system is up-to-date:
|
|
yum update -y >/dev/null
|
|
yum install -y centos-release-scl >/dev/null
|
|
yum install -y python27 >/dev/null 2>/dev/null
|
|
|
|
LE_AUTO_PY_34="certbot/letsencrypt-auto-source/letsencrypt-auto_py_34"
|
|
LE_AUTO="certbot/letsencrypt-auto-source/letsencrypt-auto"
|
|
|
|
# Last version of certbot-auto that was bootstraping Python 3.4 for CentOS 6 users
|
|
INITIAL_CERTBOT_VERSION_PY34="certbot 0.38.0"
|
|
|
|
# we're going to modify env variables, so do this in a subshell
|
|
(
|
|
. scl_source enable python27
|
|
|
|
# ensure python 3 isn't installed
|
|
python3 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -eq 0 ]; then
|
|
echo "ERROR: Python3 is already installed."
|
|
exit 1
|
|
fi
|
|
|
|
# ensure python2.7 is available
|
|
python2.7 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -ne 0 ]; then
|
|
echo "ERROR: Python2.7 is not available."
|
|
exit 1
|
|
fi
|
|
|
|
# bootstrap, but don't install python 3.
|
|
"$LE_AUTO" --no-self-upgrade -n >/dev/null 2>/dev/null
|
|
|
|
# ensure python 3 isn't installed
|
|
python3 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -eq 0 ]; then
|
|
echo "ERROR: letsencrypt-auto installed Python3 even though Python2.7 is present."
|
|
exit 1
|
|
fi
|
|
|
|
echo "PASSED: Did not upgrade to Python3 when Python2.7 is present."
|
|
)
|
|
|
|
# ensure python2.7 isn't available
|
|
python2.7 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -eq 0 ]; then
|
|
error "ERROR: Python2.7 is still available."
|
|
exit 1
|
|
fi
|
|
|
|
# Skip self upgrade due to Python 3 not being available.
|
|
if ! "$LE_AUTO" 2>&1 | grep -q "WARNING: couldn't find Python"; then
|
|
echo "ERROR: Python upgrade failure warning not printed!"
|
|
exit 1
|
|
fi
|
|
|
|
# bootstrap from the old letsencrypt-auto, this time installing python3.4
|
|
"$LE_AUTO_PY_34" --no-self-upgrade -n >/dev/null 2>/dev/null
|
|
|
|
# ensure python 3.4 is installed
|
|
python3.4 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -ne 0 ]; then
|
|
echo "ERROR: letsencrypt-auto failed to install Python3.4 using letsencrypt-auto < 0.37.0 when only Python2.6 is present."
|
|
exit 1
|
|
fi
|
|
|
|
echo "PASSED: Successfully upgraded to Python3.4 using letsencrypt-auto < 0.37.0 when only Python2.6 is present."
|
|
|
|
# As "certbot-auto" (so without implicit --non-interactive flag set), check that the script
|
|
# refuses to install SCL Python 3.6 when run in a non interactive shell (simulated here
|
|
# using | tee /dev/null) if --non-interactive flag is not provided.
|
|
cp "$LE_AUTO" /tmp/certbot-auto
|
|
# NB: Readline has an issue on all Python versions for CentOS 6, making `certbot --version`
|
|
# output an unprintable ASCII character on a new line at the end.
|
|
# So we take the second last line of the output.
|
|
version=$(/tmp/certbot-auto --version 2>/dev/null | tee /dev/null | tail -2 | head -1)
|
|
|
|
if [ "$version" != "$INITIAL_CERTBOT_VERSION_PY34" ]; then
|
|
echo "ERROR: certbot-auto upgraded certbot in a non-interactive shell with --non-interactive flag not set."
|
|
exit 1
|
|
fi
|
|
|
|
echo "PASSED: certbot-auto did not upgrade certbot in a non-interactive shell with --non-interactive flag not set."
|
|
|
|
if [ -f /opt/rh/rh-python36/enable ]; then
|
|
echo "ERROR: certbot-auto installed Python3.6 in a non-interactive shell with --non-interactive flag not set."
|
|
exit 1
|
|
fi
|
|
|
|
echo "PASSED: certbot-auto did not install Python3.6 in a non-interactive shell with --non-interactive flag not set."
|
|
|
|
# now bootstrap from current letsencrypt-auto, that will install python3.6 from SCL
|
|
"$LE_AUTO" --no-self-upgrade -n >/dev/null 2>/dev/null
|
|
|
|
# Following test is exectued in a subshell, to not leak any environment variable
|
|
(
|
|
# enable SCL rh-python36
|
|
. scl_source enable rh-python36
|
|
|
|
# ensure python 3.6 is installed
|
|
python3.6 --version >/dev/null 2>/dev/null
|
|
RESULT=$?
|
|
if [ $RESULT -ne 0 ]; then
|
|
echo "ERROR: letsencrypt-auto failed to install Python3.6 using current letsencrypt-auto when only Python2.6/Python3.4 are present."
|
|
exit 1
|
|
fi
|
|
|
|
echo "PASSED: Successfully upgraded to Python3.6 using current letsencrypt-auto when only Python2.6/Python3.4 are present."
|
|
)
|
|
|
|
# Following test is exectued in a subshell, to not leak any environment variable
|
|
(
|
|
export VENV_PATH=$(mktemp -d)
|
|
"$LE_AUTO" -n --no-bootstrap --no-self-upgrade --version >/dev/null 2>&1
|
|
if [ "$($VENV_PATH/bin/python -V 2>&1 | cut -d" " -f2 | cut -d. -f1-2)" != "3.6" ]; then
|
|
echo "ERROR: Python 3.6 wasn't used with --no-bootstrap!"
|
|
exit 1
|
|
fi
|
|
)
|
|
|
|
# Following test is exectued in a subshell, to not leak any environment variable
|
|
(
|
|
# enable SCL rh-python36
|
|
. scl_source enable rh-python36
|
|
|
|
# ensure everything works fine with certbot-auto bootstrap when python 3.6 is already enabled
|
|
export VENV_PATH=$(mktemp -d)
|
|
if ! "$LE_AUTO" --no-self-upgrade -n --version >/dev/null 2>/dev/null; then
|
|
echo "ERROR: Certbot-auto broke when Python 3.6 SCL is already enabled."
|
|
exit 1
|
|
fi
|
|
)
|
|
|
|
# test using python3
|
|
pytest -v -s certbot/letsencrypt-auto-source/tests
|