mirror of
https://github.com/certbot/certbot.git
synced 2026-06-08 00:02:14 -04:00
Fixes #7007 Python 3.4 is [EOL](https://www.python.org/dev/peps/pep-0429/), and only Python 3.x version available for CentOS 6 through EPEL is this version, and so is used by `certbot-auto`, the only official way to install Certbot on this platform. This unpleasant situation becomes a little more uncomfortable, considering that the newest `pip` version (19.2) [just dropped Python 3.4 support](https://github.com/pypa/pip/issues/6685) and will refuse to start on this Python version. We can expect a lot of dependencies to follow this path now. One direct result of this situation is that a fix to support correctly the ARM platforms requires to upgrade `pip` to 19.2 for `certbot-auto`. So this is not possible right now. Then, let's upgrade Certbot instances on CentOS 6 to a supported version of Python 3. This PR proposes a new bootstrap approach for CentOS 6 platform, `BootstrapRpmPython3Legacy`, that will install Python 3.6 from [SCL](https://www.softwarecollections.org) (the latest one available for now on CentOS 6). In term of Python 3 specific bootstrap methods, I take the occasion here to completely separate the bootstrap of CentOS 6 as a legacy system, from the RPM-based newest systems (like Fedora 29+) that are simply dropping support for Python 2.x. This is in prevision of future migration for all systems on Python 3.x, that is a different problematic than supporting old systems. * Add logic * Rebuilt letsencrypt-auto * Fix logic * Focus on specific packages * Maintain PATH for further invocations of letsencrypt-auto after bootstrap. * Various corrections * Fix farm test for RHEL6 * Working centos6 letsencrypt-auto self tests * Fix test_sdist for CentOS 6 * Corrections * Work in progress * Working configuration * Fix typo * Remove EPEL. Add a test. * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Improvements after review * Improvements * Add a comment * Add a test * Update a test * Corrections * Update function return * Work in progress * Correct behavior on oracle linux 6. * Corrections * Rebuild script * Add letsencrypt-auto tests for oraclelinux6 * Update tox.ini Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Remove specific code for scientific linux * Change some variables names * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Various corrections * Fix tests * Add a comment * Update message * Fix test message * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update scripts * More focused assertion * Add back a test * Update script * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Update letsencrypt-auto-source/letsencrypt-auto.template Co-Authored-By: Brad Warren <bmw@users.noreply.github.com> * Check quiet mode * Add changelog * Update letsencrypt-auto-source/tests/oraclelinux6_tests.sh Co-Authored-By: Brad Warren <bmw@users.noreply.github.com>
75 lines
2.3 KiB
Bash
75 lines
2.3 KiB
Bash
# If new packages are installed by BootstrapRpmPython3 below, this version
|
|
# number must be increased.
|
|
BOOTSTRAP_RPM_PYTHON3_LEGACY_VERSION=1
|
|
|
|
# Checks if rh-python36 can be installed.
|
|
Python36SclIsAvailable() {
|
|
InitializeRPMCommonBase >/dev/null 2>&1;
|
|
|
|
if "${TOOL}" list rh-python36 >/dev/null 2>&1; then
|
|
return 0
|
|
fi
|
|
if "${TOOL}" list centos-release-scl >/dev/null 2>&1; then
|
|
return 0
|
|
fi
|
|
return 1
|
|
}
|
|
|
|
# Try to enable rh-python36 from SCL if it is necessary and possible.
|
|
EnablePython36SCL() {
|
|
if "$EXISTS" python3.6 > /dev/null 2> /dev/null; then
|
|
return 0
|
|
fi
|
|
if ! scl --list 2>/dev/null | grep -q rh-python36; then
|
|
return 0
|
|
fi
|
|
set +e
|
|
. scl_source enable rh-python36
|
|
set -e
|
|
}
|
|
|
|
# This bootstrap concerns old RedHat-based distributions that do not ship by default
|
|
# with Python 2.7, but only Python 2.6. We bootstrap them by enabling SCL and installing
|
|
# Python 3.6. Some of these distributions are: CentOS/RHEL/OL/SL 6.
|
|
BootstrapRpmPython3Legacy() {
|
|
# Tested with:
|
|
# - CentOS 6
|
|
|
|
InitializeRPMCommonBase
|
|
|
|
if ! "${TOOL}" list rh-python36 >/dev/null 2>&1; then
|
|
echo "To use Certbot on this operating system, packages from the SCL repository need to be installed."
|
|
if ! "${TOOL}" list centos-release-scl >/dev/null 2>&1; then
|
|
error "Enable the SCL repository and try running Certbot again."
|
|
exit 1
|
|
fi
|
|
if [ "${ASSUME_YES}" = 1 ]; then
|
|
/bin/echo -n "Enabling the SCL repository in 3 seconds... (Press Ctrl-C to cancel)"
|
|
sleep 1s
|
|
/bin/echo -ne "\e[0K\rEnabling the SCL repository in 2 seconds... (Press Ctrl-C to cancel)"
|
|
sleep 1s
|
|
/bin/echo -e "\e[0K\rEnabling the SCL repository in 1 second... (Press Ctrl-C to cancel)"
|
|
sleep 1s
|
|
fi
|
|
if ! "${TOOL}" install "${YES_FLAG}" "${QUIET_FLAG}" centos-release-scl; then
|
|
error "Could not enable SCL. Aborting bootstrap!"
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
# CentOS 6 must use rh-python36 from SCL
|
|
if "${TOOL}" list rh-python36 >/dev/null 2>&1; then
|
|
python_pkgs="rh-python36-python
|
|
rh-python36-python-virtualenv
|
|
rh-python36-python-devel
|
|
"
|
|
else
|
|
error "No supported Python package available to install. Aborting bootstrap!"
|
|
exit 1
|
|
fi
|
|
|
|
BootstrapRpmCommonBase "${python_pkgs}"
|
|
|
|
# Enable SCL rh-python36 after bootstrapping.
|
|
EnablePython36SCL
|
|
}
|