mirror of
https://github.com/certbot/certbot.git
synced 2026-06-07 15:52:08 -04:00
d434b92945
Fixes #8041 This PR makes Azure Pipeline build the DNS plugins snaps for the 3 architectures during the CI. It leverages the existing logic for building the Certbot snap in order to deploy a QEMU environment with Docker, and leverages the local PyPI index to speed up the build when installing `cffi` and `cryptography`. All DNS plugins snaps are constructed in one unique docker container, in order to save the time required to install the system dependencies upon first start of `snapcraft`, and so speed up significantly the build. Finally, all `amd64` DNS plugins snaps are built within 6 minutes. For `arm64` and `armhf`, it is around 40 mins: this is quite fast in fact, considering that 14 DNS plugins snaps are built. However, this is still an extremely heavy task to make the full 3 architectures builds, even for Azure Pipelines and its 10 parallel jobs capability. That is why I make the `arm64` and `armhf` builds be skipped for the `full-test-suite`, and let them run only for `nightly` and `release`. This means however that these builds will not be done for the release branches. If this is a problem, I can put a more elaborate suspend condition to triggers the builds in this case. All snaps are stored in the pipeline artifacts storage, making them available for publication during a `release` pipeline. The PR is set as Draft for now, because I use temporarily `pr_test-suite` to validate the packaging jobs when commits are pushed. Once the PR is ready, I will revert it back to the normal configuration (run the standard tests). * Configure a script to build DNS snaps * Focus on packaging * Trigger all architectures * Add extra index * Prepare conditional suspend * Set final suspend logic * Set final suspend value * Loop for publication * Use python3 * Clean before build * Add a test * Add test job in Azure * Preserve env * Apply normal config for pipelines * Skip QEMU jobs only for test branches * Makes snap run tests depends also on the Certbot snap build * Update .azure-pipelines/templates/jobs/packaging-jobs.yml Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update .azure-pipelines/templates/stages/deploy-stage.yml Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * More accurate way to get the plugin snap name * Integrate DNS snap tests into certbot-ci * Fixes * Update certbot-ci/snap_integration_tests/conftest.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Update certbot-ci/snap_integration_tests/conftest.py Co-authored-by: Brad Warren <bmw@users.noreply.github.com> * Clean an _init_.py file Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
42 lines
1.6 KiB
Python
42 lines
1.6 KiB
Python
#!/usr/bin/env python3
|
|
import pytest
|
|
import subprocess
|
|
import glob
|
|
import os
|
|
import re
|
|
|
|
|
|
@pytest.fixture(autouse=True, scope="module")
|
|
def install_certbot_snap(request):
|
|
with pytest.raises(Exception):
|
|
subprocess.check_call(['certbot', '--version'])
|
|
try:
|
|
snap_path = glob.glob(os.path.join(request.config.getoption("snap_folder"),
|
|
'certbot_*.snap'))[0]
|
|
subprocess.check_call(['snap', 'install', '--classic', '--dangerous', snap_path])
|
|
subprocess.check_call(['certbot', '--version'])
|
|
yield
|
|
finally:
|
|
subprocess.call(['snap', 'remove', 'certbot'])
|
|
|
|
|
|
def test_dns_plugin_install(dns_snap_path):
|
|
"""
|
|
Test that each DNS plugin Certbot snap can be installed
|
|
and is usable with the Certbot snap.
|
|
"""
|
|
plugin_name = re.match(r'^certbot-(dns-\w+)_.*\.snap$',
|
|
os.path.basename(dns_snap_path)).group(1)
|
|
snap_name = 'certbot-{0}'.format(plugin_name)
|
|
assert plugin_name not in subprocess.check_output(['certbot', 'plugins', '--prepare'],
|
|
universal_newlines=True)
|
|
|
|
try:
|
|
subprocess.check_call(['snap', 'install', '--dangerous', dns_snap_path])
|
|
subprocess.check_call(['snap', 'set', 'certbot', 'trust-plugin-with-root=ok'])
|
|
subprocess.check_call(['snap', 'connect', 'certbot:plugin', snap_name])
|
|
|
|
assert plugin_name in subprocess.check_output(['certbot', 'plugins', '--prepare'],
|
|
universal_newlines=True)
|
|
finally:
|
|
subprocess.call(['snap', 'remove', 'plugin_name'])
|