mirror of
https://github.com/certbot/certbot.git
synced 2026-06-13 10:40:10 -04:00
Item 1 of https://github.com/certbot/certbot/issues/10600 Once this is merged, the [release instructions](https://github.com/EFForg/certbot-misc/wiki/The-Mystical-Release-Process) should be updated to no longer say "Make sure Certbot's virtual environment isn't activated." Why in `release.sh` instead of `_release.sh`? This seemed to be the "check the environment status" file. `venv/bin/activate` does several things. 1. create `deactivate` shell function 2. create `_OLD_VIRTUAL_PATH` and modify `PATH` to prepend `venv/bin` location. `_OLD_VIRTUAL_PATH` isn't exported. 3. unset `PYTHONHOME` and store the old `PYTHONHOME` in `_OLD_VIRTUAL_PYTHONHOME`, again not exported. 4. export `VIRTUAL_ENV_PROMPT` 5. call `hash -r 2> /dev/null` for some sort of edge case 6. set `VIRTUAL_ENV` 7. change the prompt appearance (PS1) 1, 4, and 7 don't need to be undone. 2, 4, and 6 are managed here manually. 3 is the hard one, since we don't have access to `_OLD_VIRTUAL_PYTHONHOME`, and there's not a great way of grabbing it from the shell. One thought I had was to modify `venv/bin/activate` in `venv.py` so that it is exported. That's possible, but at least for me, `PYTHONHOME` isn't set in the first place and so it doesn't seem worth doing that. Given that this script only needs to run on a few people's machines, I would say we can hold off on doing that if and until it becomes necessary. Added some prints and an `exit 0` after the relevant code in the script to test: ```bash $ RELEASE_GPG_KEY=dontmatter tools/release.sh 1.2.3 4.5.6 $ source venv/bin/activate (venv) $ RELEASE_GPG_KEY=dontmatter tools/release.sh 1.2.3 4.5.6 Deactivating venv... previous path: /Users/erica/certbot/venv/bin:/opt/homebrew/opt/coreutils/libexec/gnubin:[rest of path omitted] new path: /opt/homebrew/opt/coreutils/libexec/gnubin:[rest of path omitted] (venv) $ printenv PATH /Users/erica/certbot/venv/bin:/opt/homebrew/opt/coreutils/libexec/gnubin:[rest of path omitted] ``` --------- Co-authored-by: Brad Warren <bmw@users.noreply.github.com>
219 lines
7.1 KiB
Bash
Executable file
219 lines
7.1 KiB
Bash
Executable file
#!/bin/bash -xe
|
|
# Release packages to PyPI
|
|
|
|
if [ "$RELEASE_DIR" = "" ]; then
|
|
echo Please run this script through the tools/release.sh wrapper script or set the environment
|
|
echo variable RELEASE_DIR to the directory where the release should be built.
|
|
exit 1
|
|
fi
|
|
|
|
ExitWarning() {
|
|
exit_status="$?"
|
|
if [ "$exit_status" != 0 ]; then
|
|
# Don't print each command before executing it because it will disrupt
|
|
# the desired output.
|
|
set +x
|
|
echo '******************************'
|
|
echo '* *'
|
|
echo '* THE RELEASE SCRIPT FAILED! *'
|
|
echo '* *'
|
|
echo '******************************'
|
|
set -x
|
|
fi
|
|
exit "$exit_status"
|
|
}
|
|
|
|
trap ExitWarning EXIT
|
|
|
|
version="$1"
|
|
echo Releasing production version "$version"...
|
|
nextversion="$2"
|
|
RELEASE_BRANCH="candidate-$version"
|
|
|
|
if [ -n "$VIRTUAL_ENV" ]; then
|
|
if [[ "$PATH" != $VIRTUAL_ENV* ]]; then
|
|
echo "Unexpected PATH and VIRTUAL_ENV value. Please deactivate any"
|
|
echo "Python virtual environments and try running this script again."
|
|
exit 1
|
|
fi
|
|
echo "Deactivating venv..."
|
|
export PATH="${PATH#*:}"
|
|
hash -r 2> /dev/null
|
|
unset VIRTUAL_ENV
|
|
fi
|
|
|
|
if [ "$(git branch --show-current)" != "$RELEASE_BRANCH" ]; then
|
|
echo "Creating $RELEASE_BRANCH branch..."
|
|
git switch -c "$RELEASE_BRANCH"
|
|
fi
|
|
|
|
# If RELEASE_GPG_KEY isn't set, determine the key to use.
|
|
if [ "$RELEASE_GPG_KEY" = "" ]; then
|
|
TRUSTED_KEYS="
|
|
BF6BCFC89E90747B9A680FD7B6029E8500F7DB16
|
|
86379B4F0AF371B50CD9E5FF3402831161D1D280
|
|
20F201346BF8F3F455A73F9A780CC99432A28621
|
|
F2871B4152AE13C49519111F447BF683AA3B26C3
|
|
"
|
|
for key in $TRUSTED_KEYS; do
|
|
if gpg --with-colons --card-status | grep -q "$key"; then
|
|
RELEASE_GPG_KEY="$key"
|
|
break
|
|
fi
|
|
done
|
|
if [ "$RELEASE_GPG_KEY" = "" ]; then
|
|
echo A trusted PGP key was not found on your PGP card.
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
# Needed to fix problems with git signatures and pinentry
|
|
export GPG_TTY=$(tty)
|
|
|
|
# port for a local Python Package Index (used in testing)
|
|
PORT=${PORT:-1234}
|
|
|
|
# subpackages to be released (the way the script thinks about them)
|
|
SUBPKGS_NO_CERTBOT="acme certbot-apache certbot-nginx certbot-dns-cloudflare \
|
|
certbot-dns-digitalocean certbot-dns-dnsimple certbot-dns-dnsmadeeasy \
|
|
certbot-dns-gehirn certbot-dns-google certbot-dns-linode certbot-dns-luadns \
|
|
certbot-dns-nsone certbot-dns-ovh certbot-dns-rfc2136 certbot-dns-route53 \
|
|
certbot-dns-sakuracloud"
|
|
SUBPKGS="certbot $SUBPKGS_NO_CERTBOT"
|
|
# certbot_compatibility_test is not packaged because:
|
|
# - it is not meant to be used by anyone else than Certbot devs
|
|
# - it causes problems when running pytest - the latter tries to
|
|
# run everything that matches test*, while there are no unittests
|
|
# there
|
|
|
|
tag="v$version"
|
|
built_package_dir="packages"
|
|
if [ -d "$built_package_dir" ]; then
|
|
echo "there shouldn't already be a $built_package_dir directory!"
|
|
echo "if it's not important, maybe delete it and try running the script again?"
|
|
exit 1
|
|
fi
|
|
git tag --delete "$tag" || true
|
|
|
|
tmpvenv=$(mktemp -d)
|
|
python3 -m venv "$tmpvenv"
|
|
. $tmpvenv/bin/activate
|
|
# update packaging tools to their pinned versions
|
|
tools/pip_install.py build towncrier uv virtualenv
|
|
|
|
root_without_le="$version.$$"
|
|
root="$RELEASE_DIR/le.$root_without_le"
|
|
|
|
echo "Cloning into fresh copy at $root" # clean repo = no artifacts
|
|
git clone . $root
|
|
git rev-parse HEAD
|
|
cd $root
|
|
git checkout "$RELEASE_BRANCH"
|
|
|
|
# Update changelog. `--yes` automatically clears out older newsfragments,
|
|
# and all of towncrier's changes are staged for commit when it's done
|
|
towncrier build --version "$version" --yes
|
|
git commit -m "Update changelog for $version release"
|
|
|
|
SetVersion() {
|
|
ver="$1"
|
|
# bumping Certbot's version number is done differently
|
|
for pkg_dir in $SUBPKGS_NO_CERTBOT certbot-compatibility-test certbot-ci letstest
|
|
do
|
|
setup_file="$pkg_dir/setup.py"
|
|
if [ $(grep -c '^version' "$setup_file") != 1 ]; then
|
|
echo "Unexpected count of version variables in $setup_file"
|
|
exit 1
|
|
fi
|
|
sed -i "s/^version.*/version = '$ver'/" $pkg_dir/setup.py
|
|
done
|
|
init_file="certbot/src/certbot/__init__.py"
|
|
if [ $(grep -c '^__version' "$init_file") != 1 ]; then
|
|
echo "Unexpected count of __version variables in $init_file"
|
|
exit 1
|
|
fi
|
|
sed -i "s/^__version.*/__version__ = '$ver'/" "$init_file"
|
|
|
|
git add $SUBPKGS certbot-compatibility-test certbot-ci letstest
|
|
}
|
|
|
|
SetVersion "$version"
|
|
|
|
# Unset CERTBOT_OLDEST to prevent wheels from being built improperly due to
|
|
# conditionals like the one found in certbot-dns-dnsimple's setup.py file.
|
|
unset CERTBOT_OLDEST
|
|
echo "Preparing sdists and wheels"
|
|
for pkg_dir in $SUBPKGS
|
|
do
|
|
cd $pkg_dir
|
|
|
|
rm -rf build dist
|
|
# It's not strictly necessary, but using uv to install build dependencies speeds things up a
|
|
# little bit.
|
|
python -m build --installer uv
|
|
|
|
cd -
|
|
done
|
|
|
|
mkdir "$built_package_dir"
|
|
for pkg_dir in $SUBPKGS
|
|
do
|
|
mv "$pkg_dir"/dist/* "$built_package_dir"
|
|
done
|
|
|
|
|
|
cd "$built_package_dir"
|
|
echo "Generating checksum file and signing it"
|
|
sha256sum *.tar.gz > SHA256SUMS
|
|
gpg -u "$RELEASE_GPG_KEY" --detach-sign --armor --sign --digest-algo sha256 SHA256SUMS
|
|
git add *.tar.gz SHA256SUMS*
|
|
|
|
echo "Installing packages to generate documentation"
|
|
# cd .. is NOT done on purpose: we make sure that all subpackages are
|
|
# installed from local archives rather than current directory (repo root)
|
|
VIRTUALENV_NO_DOWNLOAD=1 virtualenv ../venv
|
|
. ../venv/bin/activate
|
|
pip install -U setuptools
|
|
pip install -U pip
|
|
|
|
# This creates a string like "acme==a.b.c certbot==a.b.c ..." which can be used
|
|
# with pip to ensure the correct versions of our packages installed.
|
|
subpkgs_with_version=""
|
|
for pkg in $SUBPKGS; do
|
|
subpkgs_with_version="$subpkgs_with_version $pkg==$version"
|
|
done
|
|
|
|
# Now, use our local archives. Disable cache so we get the correct packages even if
|
|
# we (or our dependencies) have conditional dependencies implemented with if
|
|
# statements in setup.py and we have cached wheels lying around that would cause
|
|
# those ifs to not be evaluated.
|
|
python ../tools/pip_install.py \
|
|
--no-cache-dir \
|
|
--find-links . \
|
|
$subpkgs_with_version
|
|
cd ~-
|
|
|
|
# get a snapshot of the CLI help for the docs
|
|
# We set CERTBOT_DOCS to use dummy values in example user-agent string.
|
|
CERTBOT_DOCS=1 certbot --help all > certbot/docs/cli-help.txt
|
|
jws --help > acme/docs/jws-help.txt
|
|
|
|
deactivate
|
|
|
|
|
|
git add certbot/docs/cli-help.txt
|
|
while ! git commit --gpg-sign="$RELEASE_GPG_KEY" -m "Release $version"; do
|
|
echo "Unable to sign the release commit using git."
|
|
echo "You may have to configure git to use gpg by running:"
|
|
echo 'git config --global gpg.program $(command -v gpg)'
|
|
read -p "Press enter to try signing again."
|
|
done
|
|
git tag --local-user "$RELEASE_GPG_KEY" --sign --message "Release $version" "$tag"
|
|
|
|
git rm --cached -r "$built_package_dir"
|
|
git commit -m "Remove built packages from git"
|
|
|
|
if [ "$RELEASE_BRANCH" = candidate-"$version" ] ; then
|
|
SetVersion "$nextversion".dev0
|
|
git commit -m "Bump version to $nextversion"
|
|
fi
|