upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-07 07:42:08 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
certbot/acme
History
Brad Warren 99b1538d0a
Fix spurious pylint errors. (#7780) 
This fixes (part of) the problem identified in https://github.com/certbot/certbot/pull/7657#issuecomment-586506340.

When I tested our pylint setup on Python 3.5.9, 3.6.9, or 3.6.10, tests failed with:
```
************* Module acme.challenges
acme/acme/challenges.py:57:15: E1101: Instance of 'UnrecognizedChallenge' has no 'jobj' member (no-member)
************* Module acme.jws
acme/acme/jws.py:28:16: E1101: Class 'Signature' has no '_orig_slots' member (no-member)
```
These errors did not occur for me on Python 3.6.7 or Python 3.7+.

You also cannot run our lint setup on Python 2.7 because our pinned version of pylint's dependency `asteroid` does not support Python 2. Because of this, `pylint` is not installed in the virtual environment created by `tools/venv.py` and our [`lint` environment in tox specifies that Python 3 should be used](fd64c8c33b/tox.ini (L132)).

I tried updating pylint and its dependencies to fix the problem, but they still occur so I think adding back these disable checks on these lines again is the best fix for now.
2020-02-18 11:55:48 -08:00
..
acme Fix spurious pylint errors. (#7780) 2020-02-18 11:55:48 -08:00
docs Don't display todo comments in docs (#7753) 2020-02-06 15:39:47 -08:00
examples Reorganize imports (#7616) 2019-12-09 15:50:20 -05:00
tests Merge branch 'master' of https://github.com/certbot/certbot 2020-02-06 15:14:17 +00:00
LICENSE.txt Update Copyright notice in subpackages LICENSE. 2015-10-04 10:10:41 +00:00
MANIFEST.in Refactor tests out of packaged module for acme plugin (#7600) 2019-11-26 15:25:41 -08:00
pytest.ini Fixes #6085. (#6091) 2018-06-12 17:31:22 -07:00
README.rst Fix ACME module description 2015-10-21 17:06:35 -07:00
readthedocs.org.requirements.txt Refactor certbot/ and certbot/tests/ to use the same structure as the other packages (#7544) 2019-11-25 14:28:05 -08:00
setup.cfg Make wheel universal 2016-01-21 10:11:23 +01:00
setup.py Bump version to 1.3.0 2020-02-04 14:01:04 -08:00

README.rst 

ACME protocol implementation in Python