upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-03-23 19:03:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
5959 commits 856 branches 154 tags 125 MiB
Commit graph

37 commits

Author SHA1 Message Date
Benjamin Neff
1390c96e65 handle permission denied during cleanup 
if the .well-known/acme-challenge was created before and the user has no
permissions to delete it, it failed at cleanup.
 2016-03-16 14:52:51 +01:00
Roy Wellington Ⅳ
e9d981aceb Change zope's classProvides to be a class decorator. 
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:

    TypeError: Class advice impossible in Python3.  Use the @provider
    class decorator instead.

Following the listed advice seems to function in Python 3.
 2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6 Change zope's implements to be a class decorator. 
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:

    TypeError: Class advice impossible in Python3.  Use the @implementer
    class decorator instead.

Following the listed advice seems to function in Python 3.
 2016-02-20 00:37:40 -08:00
Filip Ochnik
4d9f487e89 Handle rmdir failure 2016-02-17 17:04:10 +08:00
Filip Ochnik
9b5ff7bcd7 Remove acme-challenge after cleaning up all challenges 2016-02-16 20:46:42 +08:00
Filip Ochnik
780c9ce2ae Refactor path logic in webroot plugin 2016-02-16 20:36:46 +08:00
Peter Eckersley
a774922f8f Revert "Revert "Allow webroot-map and --csr to exist together."" 
This reverts commit d65a3c65c2.
 2016-02-08 18:14:55 -08:00
Peter Eckersley
d65a3c65c2 Revert "Allow webroot-map and --csr to exist together." 2016-02-08 17:25:47 -08:00
Peter Eckersley
6df94bf68d Better webroot configuration error 
Fixes: #2377
 2016-02-06 13:48:09 -08:00
Filip Ochnik
2a6d3bedb6 Fix missing --webroot-path handling in webroot plugin 2016-01-15 11:37:20 +07:00
Brad Warren
d45865a601 Cleanup 2015-12-11 19:14:23 -08:00
Brad Warren
2d52559466 Cleanup comment 2015-12-11 18:12:46 -08:00
Brad Warren
74927613e9 Fixed lint issues 2015-12-11 18:03:52 -08:00
Luca Beltrame
2b942d97b2 Address review comments 
- move the umask call before the try/except block
- move comment in _prepare_single to the umask call

Simplify the code comments, too.

Tests still pass.
 2015-12-07 11:17:29 +01:00
Luca Beltrame
edf3a4ed73 Make webroot usable also when running as non-root (GH #1795) 
Thanks to @aburch's suggestions, the logic has been changed:

- Set umask before creating folders and files
- Leverage os.makedirs' mode option in conjunction with umask

The program still tries to change owner / group, but in case of errors
it continues gracefully.

Tests have been updated, and they pass.
 2015-12-07 10:49:24 +01:00
Peter Eckersley
a191daf3ee Merge pull request #1597 from lbeltrame/fix-webroot-permissions 
Fix webroot permissions [mergeable, but enhancements also requested]
 2015-12-01 19:07:06 -08:00
Peter Eckersley
f4dd660403 Oops! 
- Finish a partial commit, providing what are perhaps excessively detailed and
  mystical errors in improbable cases.
 2015-12-01 16:50:39 -08:00
Peter Eckersley
06e273413b Fix nits and address review comments 2015-12-01 16:33:35 -08:00
Peter Eckersley
6c9ddf34e6 Merge remote-tracking branch 'origin/master' into webroot 2015-11-30 20:57:27 -08:00
Peter Eckersley
328f8cdc5b Document --webroot-path 2015-11-30 18:24:40 -08:00
Luca Beltrame
a58c939c8d Change ownership of the validation paths as well 
Match them with the parent directory they're in.
 2015-11-25 14:26:00 +01:00
Luca Beltrame
a71c3ed90c Fix issues from review 
- Put chmod argument to os.chmod (oops)
- Add permissions adjustments for challenge files, too
 2015-11-24 10:15:18 +01:00
Patrick Figel
c175ff955e Remove Content-Type checks from http-01 
Content-Type type restrictions were removed in ACME, see
69ac2baade

fixes #1595
 2015-11-24 09:54:33 +01:00
Luca Beltrame
768c7cd9c0 Fix webroot permissions 
Take them from the parent directory where the webroot is.Should fix issue #1389
 2015-11-22 15:16:50 +01:00
Peter Eckersley
f48ef6ded9 lint 2015-11-21 10:59:15 -08:00
Peter Eckersley
f2f9d33e03 Update _path_for_achall 
Borrowing from @grubberr's changes at:
https://github.com/letsencrypt/letsencrypt/pull/1284/files#diff-522ab130649a0ce14df40114d4ccd0b5L111
 2015-11-21 10:59:15 -08:00
Peter Eckersley
ffe6226edc Switch webroot.prepare() to use config.webroot_map 2015-11-21 10:59:15 -08:00
Peter Eckersley
e1f0fcca8f Move --webroot-path processing into cli.py 
Since it is now interdependent with --domains

(This is much more elegant than trying to APIify the interaction)
 2015-11-21 10:59:15 -08:00
Peter Eckersley
19f348b416 First implementation of -w for multi-webroot specification 
* Will need tests and cleanup
 2015-11-21 10:59:15 -08:00
Ward Vandewege
fc7dad116b Remove another reference to simplehttp 
Since the command `a2enconf letsencrypt` is listed on this page, make sure the config file is named accordingly.
 2015-11-04 21:07:04 -05:00
Jakub Warmuz
9e8ce90cea
Content-Type=text/plain for webroot snippets 2015-11-04 18:06:34 +00:00
bmw
15fa5af934 Merge pull request #1271 from kuba/http-01 
http-01
 2015-11-02 16:53:40 -08:00
Jakub Warmuz
e62490c051
http-01 for webroot 2015-11-01 11:01:22 +00:00
Jakub Warmuz
2a4ebb90ef
Contet-Type snippets for webroot 2015-10-31 20:31:32 +00:00
Brad Warren
98c74ddd14 Removed no_simple_http_tls 2015-10-19 12:26:59 -07:00
Jakub Warmuz
63c080b05f
--webroot-root -> --webroot-path 2015-10-04 09:30:39 +00:00
Jakub Warmuz
d88455a1b9
Rename simplefs to webroot 2015-10-04 09:30:39 +00:00
Renamed from letsencrypt/plugins/simplefs.py (Browse further)