Commit graph

48 commits

Author SHA1 Message Date
Roy Wellington Ⅳ
e9d981aceb Change zope's classProvides to be a class decorator.
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:

    TypeError: Class advice impossible in Python3.  Use the @provider
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6 Change zope's implements to be a class decorator.
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:

    TypeError: Class advice impossible in Python3.  Use the @implementer
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
bmw
bfb5f7ee9d Merge pull request #2352 from letsencrypt/2348
More helpful error messages if trying to renew with standalone and bound ports
2016-02-09 15:53:53 -08:00
Brad Warren
24a3b66b1c Use server_close() in standalone 2016-02-08 17:52:12 -08:00
Peter Eckersley
ccd58dea5b More helpful error when renewing with standalone 2016-02-02 16:47:42 -08:00
Brad Warren
20b3188c65 No kwargs plz 2015-12-16 19:46:56 -08:00
Joe Ranweiler
f4d499dbad Make help message indicate derived challenge preference 2015-12-11 18:07:25 -08:00
Joe Ranweiler
2f904a41e0 Derive preference order from supported_challenges order 2015-12-11 18:06:11 -08:00
Joe Ranweiler
c66c6bae1d Make supported_challenges return a list, not set 2015-12-11 18:00:33 -08:00
Joe Ranweiler
dbf181ebac Respect config when stating challenge preferences 2015-12-03 00:28:12 -08:00
Joe Ranweiler
d5511971aa Update plugin help string 2015-12-02 22:50:32 -08:00
Joe Ranweiler
fa55871598 Remove dead import 2015-12-02 22:14:32 -08:00
Joe Ranweiler
a0142dbe44 Don't randomize challenge preference 2015-12-02 22:13:05 -08:00
Joe Ranweiler
144a678473 Encode challenge preference order in constant 2015-12-02 22:12:18 -08:00
Jakub Warmuz
5e8ed2bbd2
--dvsni-port -> --tls-sni-01-port 2015-11-07 18:24:17 +00:00
Jakub Warmuz
2266baf775
Renames around DVSNIServer 2015-11-07 18:24:17 +00:00
Jakub Warmuz
93e69ef7de
tls-sni-01 for standalone 2015-11-07 18:24:17 +00:00
Jakub Warmuz
dd92e95290
Remove remaints of simpleHttp from standalone plugin 2015-11-07 14:24:43 +00:00
Jakub Warmuz
23d3c3b1e2
Rename --simple-http-port to --http-01-port 2015-11-01 11:01:23 +00:00
Jakub Warmuz
ea3611afe6
http-01 for standalone 2015-11-01 11:01:22 +00:00
Jakub Warmuz
4cc0610679
Remove serve_forever2/shutdown2 (reduces probability of #1085).
I'm not even sure why `serve_forever2` and `shutdown2` were introduced
in the first place... It probably follows from my misconception about
the SocketServer module. After having studied the module again, I come
to the conclusion that we can get rid of my crap, simultanously
reducing probability of #1085 (hopefully down to 0)!

`server_forever` is used throughout tests instead of `handle_request`,
because `shutdown`, following docs, "must be called while
serve_forever() is running in another thread, or it will deadlock",
and our `probe_sni` HTTP request is already enough to kill single
`handle_request`.

We don't need to use any busy waiting block or `sleep` between serve
and shutdown; studying CPython source code leads to the conclusion
that the following construction is non-blocking:

```python
import threading, SocketServer
s = SocketServer.TCPServer(("", 0), None)
t = threading.Thread(target=s.shutdown)
t.start()
s.serve_forever()  # returns immediately
t.join()  # returns immediately
```
2015-10-29 21:02:21 +00:00
Brad Warren
df2ba1ba46 standalone_description += pde_feedback 2015-10-28 19:13:41 -07:00
bmw
4f64a6bd81 Merge pull request #1079 from SwartzCr/issue_611
Fixed nits with plugin choice
2015-10-28 16:43:28 -07:00
Noah Swartz
358c7b11f4 changed Standalone description 2015-10-28 11:05:11 -07:00
Noah Swartz
e404961a76 took into account bmw's suggestions 2015-10-28 10:49:05 -07:00
Jakub Warmuz
5d11691de7
Standalone verifies ports for suported challenges only (fixes #1149). 2015-10-27 22:19:21 +00:00
Noah Swartz
788cb5fc99 moved info back to docstrings 2015-10-26 13:24:42 -07:00
Noah Swartz
dd1df820ad hid manual option 2015-10-22 16:09:47 -07:00
Noah Swartz
a385086e2e Fixed nits with plugin choice 2015-10-21 18:02:26 -07:00
Jakub Warmuz
e52922b11e
Fix getsockname usage with IPv6 2015-10-20 20:44:18 +00:00
Jakub Warmuz
11495c5820
Better logging for start/stop acme.standalone servers. 2015-10-20 20:16:12 +00:00
Jakub Warmuz
ec24641511
standalone2: run(): tls -> challenge_type. 2015-10-15 20:31:22 +00:00
Jakub Warmuz
6f44bcf117
standalone2: move alread_listening to perform 2015-10-15 18:01:14 +00:00
Jakub Warmuz
304414a214
Remove SimpleHTTP TLS from acme. 2015-10-08 21:10:12 +00:00
Jakub Warmuz
5afb0ebd1c
Remove SimpleHTTP TLS from standalone 2.0 2015-10-07 20:06:41 +00:00
Jakub Warmuz
7102f9ef4b
Don't expose threads from ServerManager. 2015-10-07 19:20:47 +00:00
Jakub Warmuz
1774ab64c4
Add SupportedChallengesValidatorTest. 2015-10-04 20:24:53 +00:00
Jakub Warmuz
4d25cabfe2
Add missing docstring 2015-10-04 19:27:47 +00:00
Jakub Warmuz
509af11a92
--standalone-supported-chalenges 2015-10-04 19:15:45 +00:00
Jakub Warmuz
1a0f8889ad
ServerManager.running returns dict 2015-10-04 19:15:04 +00:00
Jakub Warmuz
df04938f6a
Standalone 2.0: add detection for unsupported SimpleHTTP TLS platform. 2015-10-04 19:14:58 +00:00
Jakub Warmuz
517a74f432
standalone 2.0: lint, docs, cleanup. 2015-10-04 17:21:35 +00:00
Jakub Warmuz
bba0560c0e
Almost full coverage for plugins.standalone (perform2 left). 2015-10-04 13:24:30 +00:00
Jakub Warmuz
7687ecd6e3
100% coverage for standalone.ServerManager 2015-10-04 12:14:10 +00:00
Jakub Warmuz
22b1514f51
server_forever2/shutdown2 2015-10-04 12:14:10 +00:00
Jakub Warmuz
d1fcc422e0
Use ACME(TLS)Server in plugins.standalone 2015-10-04 11:31:52 +00:00
Jakub Warmuz
b0efc61f97
Add ServerManagerTest stub. 2015-10-04 10:58:31 +00:00
Jakub Warmuz
faa6cbdd71
Standalone 2.0 2015-09-26 17:43:59 +00:00