Commit graph

39 commits

Author SHA1 Message Date
Brad Warren
7e2e4192b4 Update add_parser_arguments comment 2016-03-31 20:11:53 -07:00
Joona Hoikkala
2927746c0e Added important check for IPv6 address and tests, improved readability 2016-03-25 18:36:05 +02:00
Joona Hoikkala
92a20d31cc Merge remote-tracking branch 'upstream/master' into 2478 2016-03-25 16:35:39 +02:00
Joona Hoikkala
0fd453fd5e Added code comments to clarify inner workings 2016-03-22 10:23:14 +02:00
Joona Hoikkala
7675d50f4c Cleaning up debugging leftovers 2016-03-20 22:29:01 +02:00
Joona Hoikkala
8fbe7de625 Added IPv6 normalization and comparison to Addr object 2016-03-20 18:09:43 +02:00
Joona Hoikkala
9ea8876898 Merge remote-tracking branch 'theboegl/master' into 2478 2016-03-20 11:30:56 +02:00
Peter Eckersley
388baa5a1e Start splitting renew.py out of cli.py 2016-03-11 12:29:31 -08:00
Roy Wellington Ⅳ
e9d981aceb Change zope's classProvides to be a class decorator.
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:

    TypeError: Class advice impossible in Python3.  Use the @provider
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6 Change zope's implements to be a class decorator.
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:

    TypeError: Class advice impossible in Python3.  Use the @implementer
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
Sebastian Bögl
9b08fd3964 correctly parse ipv6 address
This commit fixes the wrong used indexes for parsing the ipv6 address.
2016-02-19 23:40:44 +01:00
Sebastian Bögl
d48c560df1 correctly handle IPv6 and IPv4 addresses fix #1143
This commit correctly splits IPv6 addresses into the host and port
parts. This will work for normal IPv4 and IPv6 addresses appended by a
port number as well es for IPv6 addressess without a port, which should
be the normal IPv6 usage.
2016-02-15 23:11:13 +01:00
Peter Eckersley
9c7e99cbf5 Merge pull request #2397 from thanatos/future-pylint-fixes
Fix import ordering s.t. future versions of pylint won't warn on it.
2016-02-15 11:59:08 -08:00
Peter Eckersley
64600ff61c Place a signpost about default detection for plugin args 2016-02-09 17:52:30 -08:00
Roy Wellington Ⅳ
2369f1253b Fix import ordering s.t. future versions of pylint won't warn on it.
pylint gets more strict about import order in the future, so adjust it
now to make upgrading smoother. pylint is following the order from
PEP-8:

> Imports should be grouped in the following order:
>
> 1. standard library imports
> 2. related third party imports
> 3. local application/library specific imports
>
> You should put a blank line between each group of imports.
2016-02-07 12:58:35 -08:00
Erik Rose
e75dc96559 Stop calling things that don't implement IAuthenticator authenticators. 2015-11-25 12:44:17 -05:00
Erik Rose
9205b9c987 Remove remaining "DVSNI" wording, changing it to reference TLS-SNI-01, which it changed into. Close #1417.
Also make _get_addrs() private, since it's called only internally.
2015-11-19 13:23:07 -05:00
Jakub Warmuz
937e3edfc1
tls-sni-01 in apache and nginx plugins 2015-11-07 18:35:41 +00:00
Brad Warren
69711e432f Merge branch 'simplefs' 2015-10-16 17:37:43 -07:00
Jakub Warmuz
94c6e307c9
Fix plugins.common.Dvsni._setup_challenge_cert. 2015-10-04 20:13:00 +00:00
Jakub Warmuz
5d54871ca2
Merge remote-tracking branch 'github/letsencrypt/master' into simplefs 2015-10-04 09:26:04 +00:00
Peter Eckersley
2a3a111d62 Disable pylint invalid-name
It's clearly making our code harder to read and write
2015-09-30 12:10:16 -07:00
Jakub Warmuz
57f6979f67
Add tests for SimpleFS plugin. 2015-09-06 14:03:21 +00:00
Jakub Warmuz
83185e5553
pep8 letsencrypt 2015-09-06 09:20:11 +00:00
Jakub Warmuz
03a9a2a89e
SimpleFS plugin (fixes #742) 2015-09-02 19:52:06 +00:00
Jakub Warmuz
b6eafe63b5
Normalize plugins.common.dest_namespace (fixes #689). 2015-08-17 19:50:36 +00:00
Brad Warren
cfabfa1a67 Merge remote-tracking branch 'kuba/update-challenges' into update-challenges 2015-08-04 16:57:53 -07:00
Jakub Warmuz
f96f059288
Remove nonce_domain remaints from core. 2015-07-31 22:54:25 +00:00
James Kasten
f71119681c Address most of first round of comments 2015-07-30 23:14:58 -07:00
Jakub Warmuz
7a79915f0c
Common plugin: export key to PKCS8, not OpenSSL. 2015-07-18 13:00:05 +00:00
Jakub Warmuz
735bd924bf
Update letsencrypt to DVSNI v03 (fixes #597). 2015-07-17 17:44:35 +00:00
Jakub Warmuz
c57cd239c3
Register key creation before writing out. 2015-07-10 07:25:29 +00:00
Jakub Warmuz
7aa749174b
Fix achall response key chmods security bug. 2015-07-09 11:26:27 +00:00
Jakub Warmuz
3e2d1c8abc
get_cert_file -> get_cert_path. 2015-07-09 10:51:21 +00:00
Jakub Warmuz
7dc64e0387
Rewrite acccounts and registration.
Save accounts to:

    /etc/letsencrypt/accounts/www.letsencrypt-dmeo.org/acme/new-reg/ \
    kuba.le.wtf@2015-07-04T14:04:10Z/ \
    {regr.json,meta.json,private_key.json}

Account now represents a combination of private key, Registration
Resource and client account metadata. `Account.id` based on the
account metadata (creation host and datetime). UI interface
(`cli._determine_account`) based on the `id`, and not on email as
previously.

Add `AccountStorage` interface and `AccountFileStorage`,
`AccountMemoryStorage` implementations (latter, in-memory, useful for
testing).

Create Account only after Registration Resource is received
(`register()` returns `Account`).

Allow `client.Client(..., acme=acme, ...)`: API client might reuse
acme.client.Client as returned by `register()`.

Move report_new_account to letsencrypt.account, client.Client.register
into client.register.

Use Registration.from_data acme API.

achallenges.AChallenge.key is now the `acme.jose.JWK`, not
`le_util.Key`. Plugins have to export PEM/DER as necessary
(c.f. `letsencrypt.plugins.common.Dvsni.get_key_path`)

Add --agree-tos, save --agree-eula to "args.eula". Prompt for EULA as
soon as client is launched, add prompt for TOS.

Remove unnecessary letsencrypt.network. Remove, now irrelevant,
`IConfig.account_keys_dir`.

Based on the draft from
https://github.com/letsencrypt/letsencrypt/pull/362#issuecomment-97946817.
2015-07-09 06:43:45 +00:00
Jakub Warmuz
46707406b5
Tests: don't cover plugins.common test functions. 2015-06-28 09:38:03 +00:00
Jakub Warmuz
8f4280c2df
Merge remote-tracking branch 'github/letsencrypt/master' into cli-config-fixes
Conflicts:
	letsencrypt_apache/tests/util.py
	letsencrypt_nginx/tests/util.py
2015-06-20 20:04:58 +00:00
Jakub Warmuz
8c6d1ad50a
letsencrypt_nginx should not depend on letsencrypt_apache. 2015-06-02 14:28:20 +00:00
Jakub Warmuz
41e86df252
Move letsencrypt.client to letsencrypt 2015-05-10 12:32:05 +00:00
Renamed from letsencrypt/client/plugins/common.py (Browse further)