Commit graph

79 commits

Author SHA1 Message Date
schoen
11772b8436 Merge pull request #2708 from letsencrypt/dselect
Add directory_select method to IDisplay
2016-03-25 13:32:34 -07:00
Brad Warren
f520ca2556 Address @schoen's review comments 2016-03-25 12:52:37 -07:00
Brad Warren
294ea4d1a6 Add directory_select to NoninteractiveDisplay 2016-03-23 15:29:02 -07:00
Brad Warren
9d70c4acfb Add directory_select method to FileDisplay 2016-03-23 15:11:36 -07:00
Brad Warren
7820c687f1 Use dummy_readline to prevent ImportErrors from readline breaking LE 2016-03-23 13:33:07 -07:00
Brad Warren
0c0687ca68 Add dummy_readline module 2016-03-23 11:27:20 -07:00
Brad Warren
f9ac7d789b Add support libedit readline 2016-03-23 11:15:37 -07:00
Brad Warren
49fefb08dd autocomplete -> complete 2016-03-23 10:35:38 -07:00
Brad Warren
74a7d2bed9 Added completer.py and tests for FileDisplay 2016-03-22 18:07:51 -07:00
Brad Warren
08232eef43 display.util pep8 cleanup 2016-03-21 16:22:15 -07:00
Brad Warren
432a85cd18 Add Ncurses directory_select 2016-03-21 16:19:57 -07:00
Peter Eckersley
1c652716a2 Start splitting out tests for plugins.selection 2016-03-11 15:37:24 -08:00
Peter Eckersley
c6fece8b40 Also move plugin selection logic from display.ops 2016-03-11 15:24:57 -08:00
Roy Wellington Ⅳ
b6142c13d6 Change zope's implements to be a class decorator.
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:

    TypeError: Class advice impossible in Python3.  Use the @implementer
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
Peter Eckersley
0ab54820c6 Non-interactive menus were broken if labelled with help... 2016-02-09 14:25:18 -08:00
Seth Schoen
61b714099d Centralize all domain sanity checking in one place 2016-02-01 19:27:47 -08:00
Roy Wellington Ⅳ
44585f3c4d Remove a double space before this URL. 2016-01-30 19:55:16 -08:00
Roy Wellington Ⅳ
9c28364477 Make exception syntax Python 3 compatible.
Translate all except and raise statements that are in the old form to
the Python 3 compatible format.
2016-01-30 19:53:50 -08:00
bmw
90c7a73146 Merge pull request #2078 from letsencrypt/non-interactive
Implement non-interactive mode for the client.
2016-01-25 18:51:56 -08:00
Peter Eckersley
9a1199ed24 Wrangle a lot of **_kwargs 2016-01-21 15:50:45 -08:00
Peter Eckersley
8c9757a062 Correct docstring 2016-01-20 17:55:45 -08:00
Peter Eckersley
410bd22793 As previously implemented, iDisplay.menu() returns an index, not a tag 2016-01-20 17:21:40 -08:00
Peter Eckersley
22dccf0adb Use sphinx backticks more consistently 2016-01-20 17:16:32 -08:00
Peter Eckersley
e112e2ce61 Remove pylint disable 2016-01-20 17:16:19 -08:00
Peter Eckersley
45f32f9cdc Do not say we've renewed a cert if it was reinstalled 2016-01-20 16:04:06 -08:00
Peter Eckersley
74f09fb7bd Never auto-select plugins in non-interactive mode
* We really want the user to pick one, so that the later addition of a
    second option doesn't cause -n mode to fail.
2016-01-09 15:43:58 -08:00
Peter Eckersley
96f704f577 Test cases for various error cases (and associtated bugfixes) 2016-01-01 15:29:34 -08:00
Peter Eckersley
b5828d92ad Test cases for NoninteractiveDisplay
(and one of the associated bugfixes :)
2015-12-30 16:07:25 -08:00
Peter Eckersley
d358c8d1c0 Correct docstrings & associated typing confusion 2015-12-30 15:52:51 -08:00
Peter Eckersley
548ba6b655 lint 2015-12-29 20:26:55 -08:00
Peter Eckersley
7daf773c73 Handle noninteractiv calls to iDisplay.checklist() 2015-12-29 20:23:23 -08:00
Peter Eckersley
5ed9ac5ae6 Handle non-interactivity of iDisplay.input() 2015-12-29 20:02:33 -08:00
Peter Eckersley
7626975248 Make iDisplay.menu() calls non-interactive where possible
- And provide helpful errors where they're not
2015-12-29 14:21:05 -08:00
Peter Eckersley
6daaa7a763 Add defaults / cli_flags for yesno() input 2015-12-29 00:03:57 -08:00
Peter Eckersley
d471169b6b Add default-handling to the iDisplay interface
(and the other iDisplay implementations)
2015-12-28 23:47:32 -08:00
Peter Eckersley
4f33a4dbb5 Noninteractive iDisplay basic implementation
(no tests or hooks, yet)
2015-12-27 15:24:52 -08:00
Peter Eckersley
c3c4c6c632 Begin work on a noninteractive iDisplay 2015-12-27 14:35:13 -08:00
Joona Hoikkala
1ee9435db7 PEP8 2015-12-09 15:18:04 +02:00
Joona Hoikkala
1d3cb57aef Display meaningful error messages in manual domain entry, and give user an option to retry 2015-12-09 10:36:22 +02:00
Peter Eckersley
da609a2577 Merge pull request #1814 from joohoi/domaincheck
Check domain list from plugin get_all_names() and remove wildcard, punycode etc. [needs tweak]
2015-12-08 12:52:55 -08:00
Joona Hoikkala
3c1c3c3e8d Import and non-classmethod fix 2015-12-08 09:31:47 +02:00
Joona Hoikkala
51a5d7ceb0 Move validation code to main client 2015-12-08 09:05:11 +02:00
j
a4396b89a7 Remove ! at end of url (fixes open url in gnome-terminal)
The ! at the end of the url is parsed as part of
the url if one uses "Open Link" in gnome-terminal.
2015-12-04 00:47:58 +01:00
Peter Eckersley
7901c59cd0 Merge pull request #1524 from letsencrypt/email
Better UI when asking for email
2015-11-20 19:16:02 -08:00
Peter Eckersley
c3e2c58272 Fix comment nits 2015-11-20 19:02:50 -08:00
Peter Eckersley
1a4d7c1445 Lintmonster 2015-11-20 19:02:50 -08:00
Peter Eckersley
ec267cf215 "Compute" the minimum height needed to reasonably display input 2015-11-20 19:02:50 -08:00
Brad Warren
350a07086f Remove confirmation in text display 2015-11-19 22:35:28 -08:00
Brad Warren
489e79d777 spacing 2015-11-19 22:13:04 -08:00
Brad Warren
2bdc60dfef Scoping rules are frustrating 2015-11-19 21:21:42 -08:00