Commit graph

287 commits

Author SHA1 Message Date
Joona Hoikkala
f2fc79fc55 Fixed test case 2016-03-25 19:12:48 +02:00
Joona Hoikkala
2927746c0e Added important check for IPv6 address and tests, improved readability 2016-03-25 18:36:05 +02:00
Joona Hoikkala
92a20d31cc Merge remote-tracking branch 'upstream/master' into 2478 2016-03-25 16:35:39 +02:00
Peter Eckersley
6da12cb6a7 Merge remote-tracking branch 'origin/master' into split-plugin-selection
Conflicts on "none" -> "None"
2016-03-24 18:03:26 -07:00
Peter Eckersley
7b434c5a88 Address review comments 2016-03-24 17:51:48 -07:00
Peter Eckersley
c1844b61c1 Merge remote-tracking branch 'origin/master' into split-plugin-selection 2016-03-23 17:24:17 -07:00
Joona Hoikkala
0fd453fd5e Added code comments to clarify inner workings 2016-03-22 10:23:14 +02:00
Peter Eckersley
dfc25d5c1e Merge remote-tracking branch 'origin/master' into split-renew 2016-03-21 11:17:20 -07:00
Joona Hoikkala
7675d50f4c Cleaning up debugging leftovers 2016-03-20 22:29:01 +02:00
Joona Hoikkala
8fbe7de625 Added IPv6 normalization and comparison to Addr object 2016-03-20 18:09:43 +02:00
Joona Hoikkala
9ea8876898 Merge remote-tracking branch 'theboegl/master' into 2478 2016-03-20 11:30:56 +02:00
Benjamin Neff
1390c96e65 handle permission denied during cleanup
if the .well-known/acme-challenge was created before and the user has no
permissions to delete it, it failed at cleanup.
2016-03-16 14:52:51 +01:00
Peter Eckersley
1c652716a2 Start splitting out tests for plugins.selection 2016-03-11 15:37:24 -08:00
Peter Eckersley
c6fece8b40 Also move plugin selection logic from display.ops 2016-03-11 15:24:57 -08:00
Peter Eckersley
50881cbb35 Start splitting plugins.selection out of cli 2016-03-11 14:49:12 -08:00
Peter Eckersley
4ca25828b2 Get tests passing 2016-03-11 13:46:37 -08:00
Peter Eckersley
388baa5a1e Start splitting renew.py out of cli.py 2016-03-11 12:29:31 -08:00
Roy Wellington Ⅳ
edf6d2db24 Make these print statements Python 3 compatible. 2016-02-26 22:02:16 -08:00
Roy Wellington Ⅳ
e9d981aceb Change zope's classProvides to be a class decorator.
When attempting to import any module that uses
zope.interface.classProvides in Python 3, a TypeError is raised; it
reads:

    TypeError: Class advice impossible in Python3.  Use the @provider
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:41:01 -08:00
Roy Wellington Ⅳ
b6142c13d6 Change zope's implements to be a class decorator.
When attempting to import any module that uses zope.interface.implements
in Python 3, a TypeError is raised; it reads:

    TypeError: Class advice impossible in Python3.  Use the @implementer
    class decorator instead.

Following the listed advice seems to function in Python 3.
2016-02-20 00:37:40 -08:00
Sebastian Bögl
9b08fd3964 correctly parse ipv6 address
This commit fixes the wrong used indexes for parsing the ipv6 address.
2016-02-19 23:40:44 +01:00
Sebastian Bögl
d2a96efa8e add test cases 2016-02-19 23:39:22 +01:00
Filip Ochnik
0554163ff9 Additional tests for webroot cleanup 2016-02-17 17:21:25 +08:00
Filip Ochnik
4d9f487e89 Handle rmdir failure 2016-02-17 17:04:10 +08:00
Filip Ochnik
9b5ff7bcd7 Remove acme-challenge after cleaning up all challenges 2016-02-16 20:46:42 +08:00
Filip Ochnik
780c9ce2ae Refactor path logic in webroot plugin 2016-02-16 20:36:46 +08:00
Filip Ochnik
69e1c62859 Add test for cleaning up acme-challenge 2016-02-16 20:33:22 +08:00
Sebastian Bögl
d48c560df1 correctly handle IPv6 and IPv4 addresses fix #1143
This commit correctly splits IPv6 addresses into the host and port
parts. This will work for normal IPv4 and IPv6 addresses appended by a
port number as well es for IPv6 addressess without a port, which should
be the normal IPv6 usage.
2016-02-15 23:11:13 +01:00
Peter Eckersley
9c7e99cbf5 Merge pull request #2397 from thanatos/future-pylint-fixes
Fix import ordering s.t. future versions of pylint won't warn on it.
2016-02-15 11:59:08 -08:00
Peter Eckersley
64600ff61c Place a signpost about default detection for plugin args 2016-02-09 17:52:30 -08:00
bmw
bfb5f7ee9d Merge pull request #2352 from letsencrypt/2348
More helpful error messages if trying to renew with standalone and bound ports
2016-02-09 15:53:53 -08:00
Peter Eckersley
54600409f8 Merge branch 'master' of ssh://github.com/letsencrypt/letsencrypt into webroot-map-and-flags 2016-02-08 20:46:51 -08:00
Peter Eckersley
362a9a239d Merge pull request #2404 from letsencrypt/renew-integration-v2
Renew integration tests v2
2016-02-08 19:45:24 -08:00
Peter Eckersley
a774922f8f Revert "Revert "Allow webroot-map and --csr to exist together.""
This reverts commit d65a3c65c2.
2016-02-08 18:14:55 -08:00
Brad Warren
4038be9816 Test manual prepare() 2016-02-08 18:06:56 -08:00
Brad Warren
77616a975b Allow non-interactive with test-mode 2016-02-08 17:59:30 -08:00
Brad Warren
24a3b66b1c Use server_close() in standalone 2016-02-08 17:52:12 -08:00
Peter Eckersley
d65a3c65c2 Revert "Allow webroot-map and --csr to exist together." 2016-02-08 17:25:47 -08:00
Roy Wellington Ⅳ
2369f1253b Fix import ordering s.t. future versions of pylint won't warn on it.
pylint gets more strict about import order in the future, so adjust it
now to make upgrading smoother. pylint is following the order from
PEP-8:

> Imports should be grouped in the following order:
>
> 1. standard library imports
> 2. related third party imports
> 3. local application/library specific imports
>
> You should put a blank line between each group of imports.
2016-02-07 12:58:35 -08:00
Peter Eckersley
6df94bf68d Better webroot configuration error
Fixes: #2377
2016-02-06 13:48:09 -08:00
Peter Eckersley
7bfe246c63 Merge remote-tracking branch 'origin/renew_verb' into 2348 2016-02-05 09:57:28 -08:00
Peter Eckersley
4d8dbc9d81 Lint this entire monstrosity
- Doing some of @schoen's refactoring homework for him :)
2016-02-03 18:55:06 -08:00
Noah Swartz
3697ca7e3e throw an error if manual is run non-interactively 2016-02-02 17:56:12 -08:00
Peter Eckersley
c2fa9b95c1 Pick a display height that works pretty well 2016-02-02 17:05:54 -08:00
Peter Eckersley
c084814c6f Attempt to display better... 2016-02-02 17:01:00 -08:00
Peter Eckersley
ccd58dea5b More helpful error when renewing with standalone 2016-02-02 16:47:42 -08:00
Peter Eckersley
bbb25c7d1b Merge remote-tracking branch 'origin/master' into non-interactive
(Merge conflict due to PEP8iness)
2016-01-15 16:04:38 -08:00
Filip Ochnik
b89d383ff4 Add tests for missing paths in webroot plugin 2016-01-15 11:38:21 +07:00
Filip Ochnik
2a6d3bedb6 Fix missing --webroot-path handling in webroot plugin 2016-01-15 11:37:20 +07:00
Brad Warren
8680a29c9d Merge branch 'master' into pyopenssl 2016-01-02 13:11:11 -05:00