Commit graph

9359 commits

Author SHA1 Message Date
Brad Warren
dc16013abe Correctly report when we skip hooks during renewal (#3977)
* Remove incorrect hook message

* Add generalized msg about skipping hooks

* Properly report when hooks were skipped

* Also print message about renew hook

* Change quotes to help OCD
2017-01-05 19:47:10 -05:00
Brad Warren
13ed5c06ea Merge pull request #3956 from certbot/ocsp
Further OCSP improvements
2017-01-05 16:05:19 -05:00
Peter Eckersley
e05d537ff5 Avoid code repetition 2017-01-05 12:16:03 -08:00
Peter Eckersley
707b27418f Explicitly handle "unknown" responses from openssl 2017-01-05 12:06:51 -08:00
Peter Eckersley
3c757aec9b Merge remote-tracking branch 'origin/ocsp' into ocsp 2017-01-05 11:57:28 -08:00
Peter Eckersley
abd062cb94 Handle warnings in "revoked" responses too 2017-01-05 11:55:19 -08:00
Brad Warren
2e23a295d3 Use sudo... 2017-01-05 11:47:28 -08:00
Peter Eckersley
bc2d875ce7 Merge pull request #3918 from certbot/save-more-hooks
Save --pre and --post hooks in renewal conf files, and run them in a sophisticated way
2017-01-05 11:43:03 -08:00
Brad Warren
3b460cea71 cleanup test scripts 2017-01-05 11:40:59 -08:00
Brad Warren
6923e2eb03 change != to -ne 2017-01-05 11:17:20 -08:00
Brad Warren
f6289dbba8 Correct path to venv 2017-01-05 11:12:36 -08:00
Peter Eckersley
b1be49c14f Openssl black magic
* With _some_ versions of openssl, when checking OCSP for staging certs
   only, we need this -trust_other flag
2017-01-05 11:04:01 -08:00
Peter Eckersley
4d312d8ffe Better logging 2017-01-05 11:03:53 -08:00
Peter Eckersley
3e7f64dfe8 Pre-release variant of OCSP testing 2017-01-04 17:53:41 -08:00
schoen
2cddd2f1b6 Merge pull request #3849 from thomaszbz/dev/3844-preserve-must-staple
Preserve --must-staple in configuration for renewal (#3844)
together with updated version of PR #3948 Save allow_subset_of_names in renewal conf files
2017-01-04 17:46:44 -08:00
Seth Schoen
f238781c10 Add must_staple config test to parallel allow_subset_of_names test 2017-01-04 17:30:34 -08:00
Peter Eckersley
7f686b15c7 Merge remote-tracking branch 'origin/subset-renewal' into dev/3844-preserve-must-staple 2017-01-04 17:22:09 -08:00
Brad Warren
05afb54522 Fix and cleanup CheckHooks 2017-01-04 13:39:46 -08:00
Brad Warren
7fb4e6627c HOOK_TEST++ 2017-01-04 13:12:50 -08:00
Brad Warren
beb5db805b Fix docstring 2017-01-04 12:59:43 -08:00
Brad Warren
dae9eee7d4 bool(len([])) == bool([]) 2017-01-04 12:58:59 -08:00
Brad Warren
458c7c8131 Use a set for pre_hook.already 2017-01-04 12:57:54 -08:00
Brad Warren
b748f1afe4 Undo changes to certbot.util 2017-01-04 12:55:55 -08:00
Brad Warren
d08cf89ad2 Remove all calls to which 2017-01-04 12:54:51 -08:00
Brad Warren
42b0188519 Merge branch 'master' into save-more-hooks 2017-01-04 12:24:53 -08:00
Erica Portnoy
3b233df2b1 Update docs/contributing.rst to match display behavior during release. (#3674) 2017-01-04 14:42:52 -05:00
Peter Eckersley
8794c4fd41 Document some particularities of the revoke subcommand (#3923)
* Document some particularities of the revoke subcommand

* Add --test-cert to "run" help topic
2017-01-03 13:49:59 -08:00
Spencer Bliven
1946af289f Minor typo fix (#3966) 2017-01-03 12:09:37 -05:00
Brad Warren
12edbb53db Fixes #3954 and adds a test to prevent regressions (#3957)
* fixes #3954 and adds test to prevent regressions

* assure pylint I know what I'm doing

* Test FileDisplay methods take force_interactive
2016-12-23 10:49:51 -08:00
Peter Eckersley
f4baf1fc39 Fix test 2016-12-23 10:48:14 -08:00
Peter Eckersley
c29878ace9 lint 2016-12-23 01:03:38 -08:00
Peter Eckersley
c5bda903f2 Another instance of overlogging 2016-12-23 00:42:17 -08:00
Peter Eckersley
2fdbb8430a Don't log errors twice
- They're already being logged down in util.run_script
2016-12-23 00:40:10 -08:00
Peter Eckersley
21287b414f Finish unit tests for OCSP warning states 2016-12-23 00:24:47 -08:00
Peter Eckersley
b02ce53354 Test farm tests for openssl-based revocation checking 2016-12-23 00:20:38 -08:00
Peter Eckersley
0bcbf1d0a7 WIP 2016-12-22 23:07:00 -08:00
Peter Eckersley
97081452e9 fixup 2016-12-22 18:52:20 -08:00
Peter Eckersley
0011a3b7d8 Start handling some weirder OCSP states 2016-12-22 18:51:17 -08:00
Peter Eckersley
839ff7a265 Merge pull request #3941 from certbot/ocsp
OCSP checking and other cool "certbot certificates" features
2016-12-22 16:21:29 -08:00
Peter Eckersley
aaffe2f9ca Add openssl installation to some bootstrappers
- The others seem to either be platforms where openssl is part of the
   base system, or where I can't quickly confirm that it's safe to ask
   for installation of something called "openssl".

 - If we miss any platforms, the OCSP checking code in "certbot
   certificates" should fail gracefully.
2016-12-22 15:53:32 -08:00
Peter Eckersley
9aa93c05c1 Simplify the ocsp_revoked() return type
- we weren't reacting to None, so call it False instead
2016-12-22 15:35:29 -08:00
Peter Eckersley
19143d8303 Increase test coverage 2016-12-22 13:07:00 -08:00
Brad Warren
39f5551305 Merge the manual and script plugins (#3890)
* Start of combined manual/script plugin

* Return str from hooks.execute, not bytes

* finish manual/script rewrite

* delete old manual and script plugins

* manually specify we want chall.token

* use consistent quotes

* specify chall for uri

* s/script/hook

* fix spacing on instructions

* remove unneeded response argument

* make achall more helpful

* simplify perform

* remove old test files

* add start of manual_tests

* fix ParseTest.test_help

* stop using manual_test_mode in cli tests

* Revert "make achall more helpful"

This reverts commit 54b01cea30.

* use bad response/validation methods on achalls

* simplify perform and cleanup environment

* finish manual tests

* Add HTTP manual hook integration test

* add manual http scripts

* Add manual DNS script integration test

* remove references to the script plugin

* they're hooks, not scripts

* add --manual-public-ip-logging-ok to integration tests

* use --pref-chall for dns integration

* does dns work?

* validate hooks

* test hook validation

* Revert "does dns work?"

This reverts commit 1224cc2961.

* busy wait in manual-http-auth

* remove DNS script test for now

* Fix challenge prefix and add trailing .

* Add comment about universal_newlines

* Fix typo from 0464ba2c4

* fix nits and typos

* Generalize HookCOmmandNotFound error

* Add verify_exe_exists

* Don't duplicate code in hooks.py

* Revert changes to hooks.py

* Use consistent hook error messages
2016-12-22 08:24:08 -08:00
Peter Eckersley
7014ab5fd0 lint 2016-12-21 23:20:19 -08:00
Peter Eckersley
ac17f98b0c Refactor post_hook storage during "renew" 2016-12-21 23:02:27 -08:00
Peter Eckersley
61e822a897 Add a few more tests 2016-12-21 21:50:19 -08:00
Brad Warren
efad646960 add restore_required_config_elements test 2016-12-21 16:49:24 -08:00
Brad Warren
5119d09966 save allow_subset_of_names in renew conf 2016-12-21 16:24:28 -08:00
Brad Warren
36c9c49ab9 restore allow_subset_of_names 2016-12-21 16:12:41 -08:00
Brad Warren
2bbf28b4b9 refactor _restore_required_config_elements 2016-12-21 15:49:46 -08:00