Brad Warren
364a6d8a2d
Release 0.10.0 ( #4022 )
...
* Release 0.10.0
* Bump version to 0.11.0
2017-01-11 12:01:33 -08:00
Guillaume Boudreau
c1e106baf9
Added Heroku to the list of third-party plugins ( #4020 )
2017-01-11 09:58:47 -08:00
Erica Portnoy
c00568a518
Break on failure to deploy cert ( #4003 )
...
* Break on failure to deploy cert
* Add error message for unable to install cert
* Add unit test
2017-01-10 17:27:09 -08:00
Brad Warren
9c9004aff1
Stop IDisplay AssertionErrors ( #4010 )
...
Fixes #3996 .
I'm pretty confident this PR solves the problem. I've audited all calls to IDisplay methods and the assertions done in certbot.display.util are now done in all our unit tests.
With that said, it wouldn't hurt to have someone else double check I didn't miss anything. The easiest way to do this is to grep for IDisplay in our code and ensure all calls to IDisplay methods are valid. This means every method call other than notification (because a notification call is always OK) either provides a value for default or force_interactive. This is defined in interfaces.py.
I've also been considering removing the assertion that's been causing us trouble here from our release. The only argument I have for not doing so is it may hinder 3rd party plugin development. When they use IDisplay, they have the same problem as we do with prompting users without a TTY. Not keeping this assertion in makes it more likely they won't notice the issue and Certbot will crash on an unsuspecting user.
With that said, none of our known 3rd party plugins use IDisplay at all.
* Provide force_interactive in _get_certname
* Use force_interactive when asking for webroot
* Factor IDisplay assertion into it's own function
* Add util.patch_get_utility()
* Allow custom path to patch_get_utiity
* Change GetEmailTest to use patch_get_utility
* Use new_callable to create new objects
* Modify tests to use patch_get_utility
* Improve FreezableMock documentation
* Add user facing error to TTY magic
* Comment out assert_valid_call
* Add test_input_assertion_fail2()
2017-01-10 16:25:33 -08:00
Peter Eckersley
d8e72ee3bf
Add update_symlinks to "--help manage" ( #4008 )
2017-01-10 12:31:27 -08:00
Lipis
bba5d7d950
Rename OS X -> macOS ( #3965 )
...
* Rename OS X -> macOS
* Revert *-auto
2017-01-10 12:24:15 -08:00
Nick Fong
a146102c73
Remove extra space introduced by #3994 ( #4012 )
...
Resolves #4011
The commits from PR #3994 failed to mention that they resolve #3347
2017-01-10 11:49:11 -08:00
Ondřej Surý
379807bf0d
Add workaround for platforms where injecting pyopenssl to urllib3 ( #3990 )
...
fails with requests package (Ubuntu Trusty)
2017-01-10 11:39:40 -08:00
Noah Swartz
30acc5cf47
added basic manual instructions ( #3975 )
...
* added basic manual instructions
* take peter's edits
2017-01-09 19:01:15 -08:00
Nick Fong
31d7b5f6d7
Fix Error Message for invalid FQDNs ( #3994 )
...
* Add better error handling for invalid FQDNs
Add explicit error handling for labels that are empty. Also add test
cases to test invalid domains.
* Add more thorough tests
2017-01-09 18:59:48 -08:00
Erica Portnoy
8c14de13a5
Hide rename command ( #4007 )
2017-01-09 18:42:47 -08:00
Ondřej Surý
06e07ca49b
pyparsing.restOfLine is not a function, don't call it ( #3989 )
2017-01-09 18:29:02 -08:00
Nick Fong
b0e4054b53
Add information on updating [certbot|letsencrypt]-auto ( #3983 )
...
* Add information on updating [certbot|letsencrypt]-auto
See #3703
* Add more information about when [le|cb]-auto is updated
2017-01-07 16:45:44 -08:00
osirisinferi
f9b8933f37
Add line number to Augeas syntax error message ( #3974 )
...
* Add line number to Augeas syntax error message
* Use `format()` for message formatting
* Pleasing Python 2.6
2017-01-06 12:58:51 -08:00
Brad Warren
1125b4924d
Remove quotes so tilde is expanded ( #3978 )
2017-01-05 20:27:39 -05:00
Brad Warren
dc16013abe
Correctly report when we skip hooks during renewal ( #3977 )
...
* Remove incorrect hook message
* Add generalized msg about skipping hooks
* Properly report when hooks were skipped
* Also print message about renew hook
* Change quotes to help OCD
2017-01-05 19:47:10 -05:00
Brad Warren
13ed5c06ea
Merge pull request #3956 from certbot/ocsp
...
Further OCSP improvements
2017-01-05 16:05:19 -05:00
Peter Eckersley
e05d537ff5
Avoid code repetition
2017-01-05 12:16:03 -08:00
Peter Eckersley
707b27418f
Explicitly handle "unknown" responses from openssl
2017-01-05 12:06:51 -08:00
Peter Eckersley
3c757aec9b
Merge remote-tracking branch 'origin/ocsp' into ocsp
2017-01-05 11:57:28 -08:00
Peter Eckersley
abd062cb94
Handle warnings in "revoked" responses too
2017-01-05 11:55:19 -08:00
Brad Warren
2e23a295d3
Use sudo...
2017-01-05 11:47:28 -08:00
Peter Eckersley
bc2d875ce7
Merge pull request #3918 from certbot/save-more-hooks
...
Save --pre and --post hooks in renewal conf files, and run them in a sophisticated way
2017-01-05 11:43:03 -08:00
Brad Warren
3b460cea71
cleanup test scripts
2017-01-05 11:40:59 -08:00
Brad Warren
6923e2eb03
change != to -ne
2017-01-05 11:17:20 -08:00
Brad Warren
f6289dbba8
Correct path to venv
2017-01-05 11:12:36 -08:00
Peter Eckersley
b1be49c14f
Openssl black magic
...
* With _some_ versions of openssl, when checking OCSP for staging certs
only, we need this -trust_other flag
2017-01-05 11:04:01 -08:00
Peter Eckersley
4d312d8ffe
Better logging
2017-01-05 11:03:53 -08:00
Peter Eckersley
3e7f64dfe8
Pre-release variant of OCSP testing
2017-01-04 17:53:41 -08:00
schoen
2cddd2f1b6
Merge pull request #3849 from thomaszbz/dev/3844-preserve-must-staple
...
Preserve --must-staple in configuration for renewal (#3844 )
together with updated version of PR #3948 Save allow_subset_of_names in renewal conf files
2017-01-04 17:46:44 -08:00
Seth Schoen
f238781c10
Add must_staple config test to parallel allow_subset_of_names test
2017-01-04 17:30:34 -08:00
Peter Eckersley
7f686b15c7
Merge remote-tracking branch 'origin/subset-renewal' into dev/3844-preserve-must-staple
2017-01-04 17:22:09 -08:00
Brad Warren
05afb54522
Fix and cleanup CheckHooks
2017-01-04 13:39:46 -08:00
Brad Warren
7fb4e6627c
HOOK_TEST++
2017-01-04 13:12:50 -08:00
Brad Warren
beb5db805b
Fix docstring
2017-01-04 12:59:43 -08:00
Brad Warren
dae9eee7d4
bool(len([])) == bool([])
2017-01-04 12:58:59 -08:00
Brad Warren
458c7c8131
Use a set for pre_hook.already
2017-01-04 12:57:54 -08:00
Brad Warren
b748f1afe4
Undo changes to certbot.util
2017-01-04 12:55:55 -08:00
Brad Warren
d08cf89ad2
Remove all calls to which
2017-01-04 12:54:51 -08:00
Brad Warren
42b0188519
Merge branch 'master' into save-more-hooks
2017-01-04 12:24:53 -08:00
Erica Portnoy
3b233df2b1
Update docs/contributing.rst to match display behavior during release. ( #3674 )
2017-01-04 14:42:52 -05:00
Peter Eckersley
8794c4fd41
Document some particularities of the revoke subcommand ( #3923 )
...
* Document some particularities of the revoke subcommand
* Add --test-cert to "run" help topic
2017-01-03 13:49:59 -08:00
Spencer Bliven
1946af289f
Minor typo fix ( #3966 )
2017-01-03 12:09:37 -05:00
Brad Warren
12edbb53db
Fixes #3954 and adds a test to prevent regressions ( #3957 )
...
* fixes #3954 and adds test to prevent regressions
* assure pylint I know what I'm doing
* Test FileDisplay methods take force_interactive
2016-12-23 10:49:51 -08:00
Peter Eckersley
f4baf1fc39
Fix test
2016-12-23 10:48:14 -08:00
Peter Eckersley
c29878ace9
lint
2016-12-23 01:03:38 -08:00
Peter Eckersley
c5bda903f2
Another instance of overlogging
2016-12-23 00:42:17 -08:00
Peter Eckersley
2fdbb8430a
Don't log errors twice
...
- They're already being logged down in util.run_script
2016-12-23 00:40:10 -08:00
Peter Eckersley
21287b414f
Finish unit tests for OCSP warning states
2016-12-23 00:24:47 -08:00
Peter Eckersley
b02ce53354
Test farm tests for openssl-based revocation checking
2016-12-23 00:20:38 -08:00
