Jakub Warmuz
4cc0610679
Remove serve_forever2/shutdown2 (reduces probability of #1085 ).
...
I'm not even sure why `serve_forever2` and `shutdown2` were introduced
in the first place... It probably follows from my misconception about
the SocketServer module. After having studied the module again, I come
to the conclusion that we can get rid of my crap, simultanously
reducing probability of #1085 (hopefully down to 0)!
`server_forever` is used throughout tests instead of `handle_request`,
because `shutdown`, following docs, "must be called while
serve_forever() is running in another thread, or it will deadlock",
and our `probe_sni` HTTP request is already enough to kill single
`handle_request`.
We don't need to use any busy waiting block or `sleep` between serve
and shutdown; studying CPython source code leads to the conclusion
that the following construction is non-blocking:
```python
import threading, SocketServer
s = SocketServer.TCPServer(("", 0), None)
t = threading.Thread(target=s.shutdown)
t.start()
s.serve_forever() # returns immediately
t.join() # returns immediately
```
2015-10-29 21:02:21 +00:00
Brad Warren
de30a28555
Another shot at a description
2015-10-29 13:20:52 -07:00
James Kasten
6124571f34
Merge pull request #1188 from neffs/master
...
Add -t to apache2ctl -D DUMP_RUN_CFG
2015-10-29 15:04:24 -04:00
bmw
206ee072db
Merge pull request #1186 from xtaran/master
...
Use git instead of git-core in bootstrapping on Debian and friends
2015-10-29 10:55:42 -07:00
Brad Warren
faa61da2a6
manual_description += kuba_feedback
2015-10-29 10:46:39 -07:00
schoen
8e7c8ad31a
Merge pull request #1182 from letsencrypt/standalone_description
...
Update standalone description
2015-10-29 09:32:49 -07:00
schoen
09775989e6
Merge pull request #1144 from devnsec-com/pr2
...
use more accurate method to calculate time interval
2015-10-29 09:30:21 -07:00
David Kreitschmann
39c83d17d7
Add -t to apache2ctl -D DUMP_RUN_CFG
...
Calling apache2ctl -D DUMP_RUN_CFG on Debian Wheezy (Apache 2.2) will
open a socket which breaks standalone auth. letsencrypt still won’t
work with apache 2.2 because it only returns „Syntax OK“.
Apache 2.4 works the same with or without -t.
2015-10-29 10:06:32 +01:00
Jakub Warmuz
c3fbed1f81
Offline unittest v2.
...
Supersedes https://github.com/letsencrypt/letsencrypt/pull/1183 .
2015-10-29 08:19:54 +00:00
Axel Beckert
7fdea8dd1a
Use git instead of git-core in bootstrapping on Debian and friends
...
Fixes #1179 .
2015-10-29 09:19:38 +01:00
Brad Warren
e9661c9634
Fixed tests
2015-10-28 19:57:56 -07:00
Peter Eckersley
0d12ded6fe
Alias "everything" correctly
2015-10-28 19:19:06 -07:00
Peter Eckersley
28071a3e72
Fix stray ref
2015-10-28 19:19:06 -07:00
Peter Eckersley
8476efe86b
Inversion: make certonly the real verb, and "auth" an alias for it
2015-10-28 19:19:06 -07:00
Peter Eckersley
7e717a7a15
lint
2015-10-28 19:19:06 -07:00
Peter Eckersley
60a0b01d59
Don't initialise plugins super early
...
Also extra unit testing
2015-10-28 19:19:06 -07:00
Peter Eckersley
01fabbe893
Also make apache docs conditional?
2015-10-28 19:19:06 -07:00
Peter Eckersley
ed69ae0292
Don't suggest that --nginx is available if it isn't
...
Fixes : #932
2015-10-28 19:19:05 -07:00
Peter Eckersley
00dcff6de9
Also slip in some extra conditional plugin cli unit tests
2015-10-28 19:19:05 -07:00
Peter Eckersley
9a6ecbe669
Test case for new verb variant
2015-10-28 19:19:05 -07:00
Peter Eckersley
84dad86d61
Update the help for modern verbiage
2015-10-28 19:19:05 -07:00
Peter Eckersley
ec25612d60
For now, use the absolutely minimal implementation of verb synonyms
...
Under the hood, everything can remain "run" and "auth" for now.
2015-10-28 19:19:05 -07:00
Peter Eckersley
585e6cee6c
Make "everything" a synonym for "run"
2015-10-28 19:19:05 -07:00
Peter Eckersley
c93512d2e1
Make "certonly" a synonym for "auth", and document it
...
Closes : #657
2015-10-28 19:19:05 -07:00
Brad Warren
df2ba1ba46
standalone_description += pde_feedback
2015-10-28 19:13:41 -07:00
bmw
64073b234a
Merge pull request #1170 from kuba/bugs/1165
...
No newlines in JWK thumbprint (fixes #1165 )
2015-10-28 18:18:17 -07:00
bmw
4f64a6bd81
Merge pull request #1079 from SwartzCr/issue_611
...
Fixed nits with plugin choice
2015-10-28 16:43:28 -07:00
Noah Swartz
989c4d9514
fixed tests to match updated description string
2015-10-28 15:37:43 -07:00
Noah Swartz
09f9b6a348
added back docstring to manual
2015-10-28 11:16:23 -07:00
Noah Swartz
358c7b11f4
changed Standalone description
2015-10-28 11:05:11 -07:00
Noah Swartz
e404961a76
took into account bmw's suggestions
2015-10-28 10:49:05 -07:00
bmw
4009da2e22
Merge pull request #1168 from letsencrypt/listenbuddy
...
Install listenbuddy
2015-10-28 09:16:06 -07:00
Christoph Kisfeld
eb41678bcd
Fix one more readthedocs Intersphinx URL
2015-10-28 11:49:32 +01:00
Christoph Kisfeld
f8da08e6a2
Fix readthedocs Intersphinx URLs, fix #1140
2015-10-28 11:37:24 +01:00
Jakub Warmuz
d5a5224dbd
No newlines in JWK thumbprint ( fixes #1165 )
2015-10-28 08:20:58 +00:00
Jakub Warmuz
323f9a10a1
Update example ACME client to work with Boulder
2015-10-28 07:27:52 +00:00
Jakub Warmuz
f42515ebe4
Include example ACME client in docs
2015-10-28 07:16:40 +00:00
Jakub Warmuz
e8cfedb34d
Move example ACME client to acme subpkg
2015-10-28 07:10:53 +00:00
Brad Warren
6906f293e5
Install listenbuddy
2015-10-27 22:35:17 -07:00
bmw
767203a770
Merge pull request #1160 from kuba/bugs/1149
...
Standalone verifies ports for supported challenges only (fixes #1149 ).
2015-10-27 16:38:36 -07:00
Peter Eckersley
524f46d7f0
Merge pull request #1161 from pritambaral/bootstrap-msg-cleanup
...
Make message printed after bootstrap slightly less confusing
2015-10-27 15:52:51 -07:00
Peter Eckersley
55ae52e719
Merge pull request #1159 from pritambaral/arch-gcc
...
Respect pre-installed gcc package on Arch Linux
2015-10-27 15:38:55 -07:00
Christopher Manning
3ecf38b401
Vagrantfile: use recommended bootstrap scripts for provisioning
...
Also remove an incorrect command from the Vagrant instructions in
`docs/contributing.rst`.
2015-10-27 17:34:18 -05:00
Chhatoi Pritam Baral
7b5f20a31c
Make message printed after bootstrap slightly less confusing
2015-10-28 04:03:44 +05:30
Chhatoi Pritam Baral
8c7d0614e5
Respect pre-installed gcc package on Arch Linux
2015-10-28 03:55:44 +05:30
Jakub Warmuz
5d11691de7
Standalone verifies ports for suported challenges only ( fixes #1149 ).
2015-10-27 22:19:21 +00:00
Thom Wiggers
e9a2180d16
Add gitattributes file to mark bat file as CRLF
...
Gitattributes files can be used to mark files as crlf, which is useful for the `.bat` files in case people use eol=lf in their git config.
2015-10-27 22:53:20 +01:00
bmw
e9fcaea4bc
Merge pull request #1156 from tyll/docs
...
Minor bug fixes
2015-10-27 14:02:51 -07:00
bmw
df81812452
Merge pull request #1155 from tyll/BITS
...
Actually use BITS constant in example client
2015-10-27 14:01:02 -07:00
Till Maas
e5f06bacbd
Add missing newline to standalone README
2015-10-27 20:12:34 +01:00
