Brad Warren
2ae187b1d6
Update config_test method
2017-08-25 13:55:21 -07:00
Brad Warren
b4b5c44750
Check postfix executable is found.
2017-08-25 13:38:07 -07:00
Brad Warren
a29a99fb6f
Add --postfix-ctl flag.
2017-08-25 13:34:03 -07:00
Brad Warren
0f4c5c2305
Use common installer base
2017-08-25 11:41:30 -07:00
Josh Soref
b2b3285bf5
Add the word instead to renew error ( #5053 )
...
Closes #4118
2017-08-25 10:25:59 -07:00
r5d
b43bf8f94a
Stop using print in certbot.cli module. ( #5028 )
...
* Update cerbot.tests.util.patch_get_utility (#3720 )
* Add new arg `stdout_notification` to
`cerbot.tests.util.patch_get_utility` function.
If `stdout_notification` is True, then the mock
interfaces.IDisplay.notification function will print out to stdout.
* Add new arg `stdout_notification` to _create_get_utility_mock
function.
* Add new function `_stdout_notification`.
* Stop using print in certbot.cli (#3720 )
* certbot/cli.py (HelpfulArgumentParser._usage_string)
(HelpfulArgumentParser.__init__): Update methods.
* certbot/tests/cli_test.py (test_cli_ini_domains, test_no_args)
(test_install_abspath, test_help, test_help_no_dashes)
(test_parse_domains, test_preferred_challenges, test_server_flag)
(test_must_staple_flag, test_no_gui, test_staging_flag)
(test_dry_run_flag, test_option_was_set)
(test_encode_revocation_reason, test_force_interactive)
(test_deploy_hook_conflict, test_deploy_hook_matches_renew_hook)
(test_deploy_hook_sets_renew_hook, test_renew_hook_conflict)
(test_renew_hook_matches_deploy_hook)
(test_renew_hook_does_not_set_renew_hook, test_max_log_backups_error)
(test_max_log_backups_success, test_webroot_map)
(test_report_config_interaction_str)
(test_report_config_interaction_iterable): Update tests.
* certbot/tests/main_test.py (test_certificates)
(test_certonly_abspath, test_certonly_bad_args)
(test_agree_dev_preview_config): Update tests.
* certbot: Refactor cli_test.ParseTest.
* certbot/tests/cli_test.py (ParseTest._unmocked_parse): Rename parse
to _unmocked_parse.
(parse): New method.
(ParseTest._help_output, ParseTest.test_cli_ini_domains)
(ParseTest.test_no_args, ParseTest.test_install_abspath)
(ParseTest.test_help, ParseTest.test_help_no_dashes)
(ParseTest.test_parse_domains, ParseTest.test_preferred_challenges)
(ParseTest.test_server_flag, ParseTest.test_must_staple_flag)
(ParseTest.test_no_gui, ParseTest.test_staging_flag)
(ParseTest.test_dry_run_flag, ParseTest.test_option_was_set)
(ParseTest.test_encode_revocation_reason)
(ParseTest.test_force_interactive)
(ParseTest.test_deploy_hook_conflict)
(ParseTest.test_deploy_hook_matches_renew_hook)
(ParseTest.test_deploy_hook_sets_renew_hook)
(ParseTest.test_renew_hook_conflict)
(ParseTest.test_renew_hook_matches_deploy_hook)
(ParseTest.test_renew_hook_does_not_set_renew_hook)
(ParseTest.test_max_log_backups_error)
(ParseTest.test_max_log_backups_success): Update methods.
* certbot: Refactor cli_test.SetByCliTest
* certbot/tests/cli_test.py (SetByCliTest.test_webroot_map)
(SetByCliTest.test_report_config_interaction_str)
(SetByCliTest.test_report_config_interaction_iteratable)
(_call_set_by_cli): Update methods.
* certbot: cli: Fix style.
* certbot/cli.py (HelpfulArgumentParser.__init__): Update method.
* certbot: Revert changes to tests.util.patch_get_utility
* certbot/tests/util.py (patch_get_utility): Remove
`stdout_notification` arg.
(_creat_get_utility_mock): Remove `stdout_notification` arg.
(_stdout_notification): Remove function.
* certbot: Revert changes to MainTest.
* certbot/tests/main_test.py
(MainTest.test_certificates, MainTest.test_certonly_abspath)
(MainTest.test_certonly_bad_args): Update methods.
* certbot: cli_test.py: Remove 'pylint: disable' lines.
* certbot/tests/cli_test.py (ParseTest.parse): Update method.
(_call_set_by_cli): Update function.
2017-08-25 10:05:58 -07:00
Brad Warren
60c6cc5f2a
Write enhance()
2017-08-24 15:26:52 -07:00
Brad Warren
00e28592b6
Add supported_enhancements
2017-08-24 15:18:40 -07:00
Brad Warren
b92df1b71c
Remove unused find_postfix_cf
2017-08-24 15:15:41 -07:00
Brad Warren
baf0d3343a
Remove postfix version notes
2017-08-24 15:13:02 -07:00
Brad Warren
cc3896d5d4
Add test_lock_error
2017-08-24 15:12:11 -07:00
Brad Warren
b94e268f83
Remove unused certs_only_config
2017-08-24 15:05:39 -07:00
Brad Warren
b9177948d3
Remove _write_config
2017-08-24 15:05:24 -07:00
Brad Warren
3b2e9e49be
Remove unneeded instance variables
2017-08-24 15:04:36 -07:00
Brad Warren
0efc02d6ee
Lock the Postfix config dir
2017-08-24 15:03:11 -07:00
Brad Warren
967a1830e6
Rewrite get_all_names
2017-08-24 14:59:25 -07:00
Brad Warren
90ffe2aac0
Remove legacy get_all_certs_and_keys() method
2017-08-24 09:04:57 -07:00
Brad Warren
b342f40c2b
remove old comments
2017-08-23 15:16:36 -07:00
Brad Warren
83e37acc8b
group IPlugin methods
2017-08-23 15:16:07 -07:00
Brad Warren
d1f3a2deef
move _get_version
2017-08-23 15:13:06 -07:00
Brad Warren
a5fae7eab5
certbot-auto OS dependency update system ( #4971 )
...
* Add version number to bootstrap scripts.
* Always determine Bootstrap function and version.
* Write bootstrap version into venv.
* Add PrevBootstrapVersion function.
* Add OS bootstrapping check to phase 2.
* Differentiate -n and renew when rebootstrapping.
* Quote all environment variables.
* Correct test condition
* Add loud warning about hardcoded version list.
* s/VENV_BOOTSTRAP_VERSION/BOOTSTRAP_VERSION_PATH
* Properly handle noop bootstrap functions.
2017-08-23 11:01:20 -07:00
Winston Smith
8ca36a0b62
Organize + document certbot/tests/testdata directory ( #4983 )
...
* wp organize keys documentation start
* oganized testdata directory + readme
* clean up doc
* del acme change
2017-08-23 10:32:27 -07:00
Noah Swartz
c33ee0e2df
add warnings and clarity to config documentation ( #4991 )
2017-08-21 12:30:04 -07:00
Brad Warren
56db211367
Change certbot-auto's installation path to /opt ( #4970 )
...
* Update comment about root usage.
* run all of certbot-auto as root
* remove other $SUDO uses from template
* remove $SUDO usage from bootstrappers
* default venv path = /opt/eff.org/certbot/venv
* Create symlinks from old default venvs
* Delete old venv path when it exists.
Also, quote expansion of paths.
* fix typo
* Separate venv_dir and le_auto_path
* Deduplicate code with test_dirs()
* Ignore cleanup errors.
This is caused by subdirectories being owned by root.
* Split test into test_phase2_upgrade.
* Rename test_dirs to temp_paths for clarity.
* Check both venvs before bootstrapping again.
* Use OLD_VENV_PATH/bin
* Preserve environment with sudo.
* Remove "esp. under sudo" comment.
* Export *VENV_PATH.
* Change check for OLD_VENV installation.
This approach better handles manually set VENV_PATH values.
* Remove SUDO_ENV.
* Print message before requesting root privileges.
* Make a function for selecting root auth method.
* Address @erikrose's feedback.
2017-08-21 12:23:09 -07:00
Nicolas Duchon
cd2e70e9cd
Redirect to zenhack/simp_le ( #5025 )
...
Kuba's simp_le has been unmaintained for more than a year and is starting to break.
zenhack's fork is actively maintained and available through PyPI.
2017-08-21 11:27:24 -07:00
Noah Swartz
2c9e072a9f
link to nginx documentation
2017-08-15 17:39:23 -07:00
Noah Swartz
4d72fa42e3
expand nginx no name error
2017-08-15 17:00:03 -07:00
Winston Smith
16ed141301
Include plugin selection at the info logging level ( #5010 )
...
* Plugin selection on INFO
* Fixed lint errors
* Fixed lint errors
* record_chosen_plugin log plugin
2017-08-10 16:51:19 -07:00
Brad Warren
c9813a44d7
protect get_version()
2017-08-10 16:42:48 -07:00
Brad Warren
b98f541b91
clean up prepare()
2017-08-10 16:41:59 -07:00
Brad Warren
50a1f6340f
Add _check_version.
2017-08-10 16:38:27 -07:00
Brad Warren
8c4ff5cb63
Use context manager to read conf file.
2017-08-10 16:36:08 -07:00
Brad Warren
290f5b8ce7
add test_set_config_dir
2017-08-10 16:35:21 -07:00
Brad Warren
48c5731a6b
Write out temp config instead of mocking.
2017-08-10 16:29:08 -07:00
Brad Warren
749f758adb
use a temporary directory
2017-08-10 16:25:30 -07:00
Brad Warren
2e8a8dfed5
add _set_config_dir
2017-08-10 16:17:46 -07:00
Brad Warren
25d1f6ec75
Test all branches of test_get_config_var
2017-08-10 16:11:09 -07:00
Brad Warren
4c4b63437f
Test building of get_config_var command
2017-08-10 15:28:17 -07:00
Brad Warren
02c7eca6da
Rename test classes and methods.
2017-08-10 15:08:41 -07:00
Brad Warren
b72dfc0c08
Add get_config_var
2017-08-10 15:07:32 -07:00
Brad Warren
7334fc3066
Rename postfix_dir to config_dir
2017-08-10 14:29:56 -07:00
Brad Warren
4e5740615c
Use util.check_output in Postfix installer
2017-08-10 14:25:08 -07:00
Brad Warren
5a1d031f07
Rename util to certbot_util
2017-08-10 14:19:44 -07:00
Brad Warren
4715b2b12c
Further document check_output
2017-08-10 14:18:27 -07:00
Brad Warren
5beaae3b65
Add check_output function and tests.
2017-08-10 14:17:13 -07:00
Brad Warren
dfd1cceb9b
Test prepare() failure due to missing postconf
2017-08-10 12:26:47 -07:00
Brad Warren
192f0f60da
test add_parser_arguments
2017-08-10 12:19:59 -07:00
Brad Warren
b395b72d1b
Don't hardcode postconf path.
2017-08-10 11:51:01 -07:00
Brad Warren
a2dbf2fe4c
Fix spacing
2017-08-10 11:20:21 -07:00
Brad Warren
86fe5ad362
Move calls to postconf to prepare().
2017-08-10 11:16:46 -07:00