Test coverage & fix

certbot-apache/certbot_apache/display_ops.py

@@ -86,7 +86,7 @@ def _vhost_menu(domain, vhosts):
             "like to choose?\n(note: conf files with multiple "
             "vhosts are not yet supported)".format(domain, os.linesep),
             choices, help_label="More Info", ok_label="Select")
-    except errors.MissingCommandlineFlag as e:
+    except errors.MissingCommandlineFlag:
         msg = ("Encountered vhost ambiguity but unable to ask for user guidance in "
                "non-interactive mode. Currently Certbot needs each vhost to be "
                "in its own conf file, and may need vhosts to be explicitly "

certbot-apache/certbot_apache/tests/display_ops_test.py

@@ -38,7 +38,7 @@ class SelectVhostTest(unittest.TestCase):
         try:
             self._call(self.vhosts)
         except errors.MissingCommandlineFlag as e:
-            self.assertTrue("VirtualHost directives" in e.message)
+            self.assertTrue("vhost ambiguity" in e.message)
 
     @mock.patch("certbot_apache.display_ops.zope.component.getUtility")
     def test_more_info_cancel(self, mock_util):

certbot-apache/certbot_apache/tests/obj_test.py

@@ -22,6 +22,9 @@ class VirtualHostTest(unittest.TestCase):
         self.vhost2 = VirtualHost(
             "fp", "vhp", set([self.addr2]), False, False, "localhost")
 
+    def test_repr(self):
+        self.assertEqual(repr(self.addr2), "certbot_apache.obj.Addr(('127.0.0.1', '443'))")
+
     def test_eq(self):
         self.assertTrue(self.vhost1b == self.vhost1)
         self.assertFalse(self.vhost1 == self.vhost2)

certbot-apache/certbot_apache/tls_sni_01.py

@@ -124,7 +124,7 @@ class ApacheTlsSni01(common.TLSSNI01):
 
         try:
             vhost = self.configurator.choose_vhost(achall.domain, temp=True)
-        except (PluginError, MissingCommandlineFlag), e:
+        except (PluginError, MissingCommandlineFlag):
             # We couldn't find the virtualhost for this domain, possibly
             # because it's a new vhost that's not configured yet (GH #677),
             # or perhaps because there were multiple <VirtualHost> sections