mirror of
https://github.com/certbot/certbot.git
synced 2026-06-08 00:02:14 -04:00
Now validating most of the config json
This commit is contained in:
parent
839c523048
commit
c033905b16
1 changed files with 52 additions and 6 deletions
|
|
@ -3,6 +3,8 @@
|
|||
import sys
|
||||
import json
|
||||
from datetime import datetime
|
||||
import string
|
||||
|
||||
|
||||
def parse_timestamp(ts):
|
||||
try:
|
||||
|
|
@ -12,14 +14,30 @@ def parse_timestamp(ts):
|
|||
except:
|
||||
raise ValueError, "Invalid timestamp integer: " + `ts`
|
||||
|
||||
legal = string.letters + string.digits + ".-"
|
||||
known_tlds =["com","org","net","biz","info",] # xxx make me from an ICANN list
|
||||
def looks_like_a_domain(s):
|
||||
"Return true if string looks like a domain, as best we can tell..."
|
||||
global known_tlds
|
||||
try:
|
||||
domain = s.lower()
|
||||
assert domain[0].islower()
|
||||
assert all([c in legal for c in domain])
|
||||
tld = s.split(".")[-1]
|
||||
if tld not in known_tlds:
|
||||
# XXX perform DNS query to determine that this TLD exists
|
||||
pass
|
||||
return True
|
||||
except:
|
||||
return False
|
||||
|
||||
class Config:
|
||||
def __init__(self, cfg_file_name = "config.json"):
|
||||
f = open(cfg_file_name)
|
||||
cfg = json.loads(f.read())
|
||||
for atr, val in cfg.items():
|
||||
self.cfg = json.loads(f.read())
|
||||
for atr, val in self.cfg.items():
|
||||
#print atr,val
|
||||
# Parse and verify each attribute of the structure
|
||||
# Verify each attribute of the structure
|
||||
if atr.startswith("comment"):
|
||||
continue
|
||||
if atr == "author":
|
||||
|
|
@ -29,11 +47,39 @@ class Config:
|
|||
self.timestamp = parse_timestamp(val)
|
||||
elif atr == "expires":
|
||||
self.expires = parse_timestamp(val)
|
||||
elif atr == "address-domains":
|
||||
if type(val) != dict:
|
||||
raise TypeError, "address-domains " + `val`
|
||||
elif atr == "tls-policies":
|
||||
self.tls_policies = {}
|
||||
for domain,policies in self.check_tls_policy_domains(val):
|
||||
if type(policies) != dict:
|
||||
raise TypeError, domain + "'s policies should be a dict: " + `policies`
|
||||
self.tls_policies[domain] = {} # being here enforces TLS at all
|
||||
for policy, value in policies.items():
|
||||
if policy == "min-tls-version":
|
||||
reasonable = ["TLS", "TLSv1.1", "TLSv1.2", "TLSv1.3"]
|
||||
if not value in reasonable:
|
||||
raise ValueError, "Not a valid TLS version string: " + `value`
|
||||
self.tls_policies[domain]["min-tls-version"] = str(value)
|
||||
elif atr == "acceptable-mxs":
|
||||
pass
|
||||
else:
|
||||
sys.stderr.write("Uknown attribute: " + `atr` + "\n")
|
||||
print self.tls_policies
|
||||
|
||||
def check_tls_policy_domains(self, val):
|
||||
if type(val) != dict:
|
||||
raise TypeError, "tls-policies should be a dict" + `val`
|
||||
for domain, policies in val.items():
|
||||
try:
|
||||
assert type(domain) == unicode
|
||||
d = str(domain) # convert from unicode
|
||||
except:
|
||||
raise TypeError, "tls-policy domain not a string" + `domain`
|
||||
if not d.startswith("*."):
|
||||
raise ValueError, "tls-policy domains must start with *.; try *."+d
|
||||
d = d.partition("*.")[2]
|
||||
if not looks_like_a_domain(d):
|
||||
raise ValueError, "tls-policy for something that a domain? " + d
|
||||
yield (d, policies)
|
||||
|
||||
if __name__ == "__main__":
|
||||
c = Config()
|
||||
|
|
|
|||
Loading…
Reference in a new issue