From bd610e40574cce85bf24dea74862ec3a9f7fa095 Mon Sep 17 00:00:00 2001 From: Adrien Ferrand Date: Tue, 4 Feb 2020 22:20:56 +0100 Subject: [PATCH] Explicit dependency on a log output --- certbot-ci/windows_installer_integration_tests/test_main.py | 2 +- certbot/certbot/_internal/renewal.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/certbot-ci/windows_installer_integration_tests/test_main.py b/certbot-ci/windows_installer_integration_tests/test_main.py index f86fdbb23..c8c347aa8 100644 --- a/certbot-ci/windows_installer_integration_tests/test_main.py +++ b/certbot-ci/windows_installer_integration_tests/test_main.py @@ -42,7 +42,7 @@ def test_it(request): with open(log_path) as file_h: data = file_h.read() - assert 'DEBUG:certbot._internal.renewal:no renewal failures' in data, 'Renew task did not execute properly.' + assert 'no renewal failures' in data, 'Renew task did not execute properly.' finally: # Sadly this command cannot work in non interactive mode: uninstaller will ask explicitly permission in an UAC prompt diff --git a/certbot/certbot/_internal/renewal.py b/certbot/certbot/_internal/renewal.py index 930f6c1a9..bf30404f5 100644 --- a/certbot/certbot/_internal/renewal.py +++ b/certbot/certbot/_internal/renewal.py @@ -471,4 +471,7 @@ def handle_renewal_request(config): if renew_failures or parse_failures: raise errors.Error("{0} renew failure(s), {1} parse failure(s)".format( len(renew_failures), len(parse_failures))) + + # Windows installer integration tests rely on handle_renewal_request behavior here. + # If the text below changes, these tests will need to be updated accordingly. logger.debug("no renewal failures")