upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-08 16:22:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

comments on protocol compliance enforcement

Browse source
This commit is contained in:
Seth Schoen 2012-07-02 17:46:06 -07:00
parent 5e44ccba90
commit bca9360449
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
client-webserver/chocolate.py
View file

@ -127,6 +127,12 @@ class session(object):
def handlesession(self, m, r):
if r.failure.IsInitialized(): return
# TODO: perhaps some code belongs here to enforce rules about which
# combinations of protocol messages can occur together. I think the
# rules are: Client must send either nothing (polling for updates)
# or exactly one of request, failure, or completedchallenge. Client
# may not send proceed, challenge, or success. If the rules are
# violated, we should self.die(r, r.BadRequest) and return.
if m.session == "":
# New session
r.session = random()
@ -282,6 +288,16 @@ class session(object):
self.handlesession(m, r)
# TODO: perhaps some code belongs here to enforce rules about which
# combinations of protocol messages can occur together in the reply.
# I think the rules are: server must send exactly one of failure,
# proceed, challenge, or success; server may not send request or
# completedchallenge [although we know it never attempts to].
# If, for some reason, the server is trying to send more than one
# of these messages, or no message at all, that's an error and the
# response should be cleared and we should self.die(r, r.BadRequest)
# or similar.
# Send reply
if m.debug:
web.header("Content-type", "text/plain")