From a5e927c657a127a4079c17470a5b3f211c8460fb Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Sun, 10 May 2015 14:56:44 +0000 Subject: [PATCH] name_with_description -> description_with_name --- letsencrypt/client/display/ops.py | 2 +- letsencrypt/client/plugins/disco.py | 6 +++--- letsencrypt/client/plugins/disco_test.py | 7 ++++--- letsencrypt/client/tests/display/ops_test.py | 4 ++-- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/letsencrypt/client/display/ops.py b/letsencrypt/client/display/ops.py index dc6992c8c..706e8bd7c 100644 --- a/letsencrypt/client/display/ops.py +++ b/letsencrypt/client/display/ops.py @@ -22,7 +22,7 @@ def choose_plugin(prepared, question): :rtype: `~.PluginEntryPoint` """ - opts = [plugin_ep.name_with_description + opts = [plugin_ep.description_with_name + (" [Misconfigured]" if plugin_ep.misconfigured else "") for plugin_ep in prepared] diff --git a/letsencrypt/client/plugins/disco.py b/letsencrypt/client/plugins/disco.py index 50e0bce50..6ab110a20 100644 --- a/letsencrypt/client/plugins/disco.py +++ b/letsencrypt/client/plugins/disco.py @@ -39,9 +39,9 @@ class PluginEntryPoint(object): return self.plugin_cls.description @property - def name_with_description(self): - """Name with description. Handy for UI.""" - return "{0} ({1})".format(self.name, self.description) + def description_with_name(self): + """Description with name. Handy for UI.""" + return "{0} ({1})".format(self.description, self.name) def ifaces(self, *ifaces_groups): """Does plugin implements specified interface groups?""" diff --git a/letsencrypt/client/plugins/disco_test.py b/letsencrypt/client/plugins/disco_test.py index f5ea9e6ee..88aa1275c 100644 --- a/letsencrypt/client/plugins/disco_test.py +++ b/letsencrypt/client/plugins/disco_test.py @@ -52,9 +52,10 @@ class PluginEntryPointTest(unittest.TestCase): def test_description(self): self.assertEqual("Standalone Authenticator", self.plugin_ep.description) - def test_name_with_description(self): - self.assertTrue( - self.plugin_ep.name_with_description.startswith("sa (")) + def test_description_with_name(self): + self.plugin_ep.plugin_cls = mock.MagicMock(description="Desc") + self.assertEqual( + "Desc (sa)", self.plugin_ep.description_with_name) def test_ifaces(self): self.assertTrue(self.plugin_ep.ifaces((interfaces.IAuthenticator,))) diff --git a/letsencrypt/client/tests/display/ops_test.py b/letsencrypt/client/tests/display/ops_test.py index 7c5c1f74f..4716a5b11 100644 --- a/letsencrypt/client/tests/display/ops_test.py +++ b/letsencrypt/client/tests/display/ops_test.py @@ -20,9 +20,9 @@ class ChoosePluginTest(unittest.TestCase): def setUp(self): zope.component.provideUtility(display_util.FileDisplay(sys.stdout)) self.mock_apache = mock.Mock( - name_with_description="a", misconfigured=True) + description_with_name="a", misconfigured=True) self.mock_stand = mock.Mock( - name_with_description="s", misconfigured=False) + description_with_name="s", misconfigured=False) self.mock_stand.init().more_info.return_value = "standalone" self.plugins = [ self.mock_apache,