name_with_description -> description_with_name

This commit is contained in:
Jakub Warmuz 2015-05-10 14:56:44 +00:00
parent 771ddf0aaf
commit a5e927c657
No known key found for this signature in database
GPG key ID: 2A7BAD3A489B52EA
4 changed files with 10 additions and 9 deletions

View file

@ -22,7 +22,7 @@ def choose_plugin(prepared, question):
:rtype: `~.PluginEntryPoint`
"""
opts = [plugin_ep.name_with_description
opts = [plugin_ep.description_with_name
+ (" [Misconfigured]" if plugin_ep.misconfigured else "")
for plugin_ep in prepared]

View file

@ -39,9 +39,9 @@ class PluginEntryPoint(object):
return self.plugin_cls.description
@property
def name_with_description(self):
"""Name with description. Handy for UI."""
return "{0} ({1})".format(self.name, self.description)
def description_with_name(self):
"""Description with name. Handy for UI."""
return "{0} ({1})".format(self.description, self.name)
def ifaces(self, *ifaces_groups):
"""Does plugin implements specified interface groups?"""

View file

@ -52,9 +52,10 @@ class PluginEntryPointTest(unittest.TestCase):
def test_description(self):
self.assertEqual("Standalone Authenticator", self.plugin_ep.description)
def test_name_with_description(self):
self.assertTrue(
self.plugin_ep.name_with_description.startswith("sa ("))
def test_description_with_name(self):
self.plugin_ep.plugin_cls = mock.MagicMock(description="Desc")
self.assertEqual(
"Desc (sa)", self.plugin_ep.description_with_name)
def test_ifaces(self):
self.assertTrue(self.plugin_ep.ifaces((interfaces.IAuthenticator,)))

View file

@ -20,9 +20,9 @@ class ChoosePluginTest(unittest.TestCase):
def setUp(self):
zope.component.provideUtility(display_util.FileDisplay(sys.stdout))
self.mock_apache = mock.Mock(
name_with_description="a", misconfigured=True)
description_with_name="a", misconfigured=True)
self.mock_stand = mock.Mock(
name_with_description="s", misconfigured=False)
description_with_name="s", misconfigured=False)
self.mock_stand.init().more_info.return_value = "standalone"
self.plugins = [
self.mock_apache,