From 9ab344b31e22e9feae83eaf96ec6a0659cbbc5f2 Mon Sep 17 00:00:00 2001 From: Erica Portnoy Date: Wed, 11 Mar 2020 13:09:31 -0700 Subject: [PATCH] warn thoroughly and consistently in openssl_version function --- certbot-apache/certbot_apache/_internal/configurator.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/certbot-apache/certbot_apache/_internal/configurator.py b/certbot-apache/certbot_apache/_internal/configurator.py index c154c5ab8..9068b1543 100644 --- a/certbot-apache/certbot_apache/_internal/configurator.py +++ b/certbot-apache/certbot_apache/_internal/configurator.py @@ -245,16 +245,18 @@ class ApacheConfigurator(common.Installer): try: ssl_module_location = self.parser.modules['ssl_module'] except KeyError: + logger.warning("Could not find ssl_module; not disabling session tickets.") return None if not ssl_module_location: + logger.warning("Could not find ssl_module; not disabling session tickets.") return None # Step 2. Grep in the .so for openssl version try: with open(ssl_module_location) as f: contents = f.read() except IOError as error: - logger.debug(str(error), exc_info=True) - raise errors.PluginError("Unable to open ssl_module file") + logger.warning("Unable to read ssl_module file; not disabling session tickets.") + return None # looks like: OpenSSL 1.0.2s 28 May 2019 matches = re.findall(r"OpenSSL ([0-9]\.[^ ]+) ", contents) if not matches: