upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-06-04 14:26:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Add docstring for acme.crypto_util.get_names_from_subject_and_extensions (#10115)

Browse source 
It was my oversight to not request this when this function was made
public in https://github.com/certbot/certbot/pull/10111.
This commit is contained in:
ohemorange 2025-01-06 14:37:29 -08:00 committed by GitHub
parent 4004589cbf
commit 985457e57b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
acme/acme/crypto_util.py
View file

@ -307,6 +307,14 @@ def get_names_from_subject_and_extensions(
subject: x509.Name, exts: x509.Extensions
) -> List[str]:
"""Gets all DNS SAN names as well as the first Common Name from subject.
:param subject: Name of the x509 object, which may include Common Name
:type subject: `cryptography.x509.Name`
:param exts: Extensions of the x509 object, which may include SANs
:type exts: `cryptography.x509.Extensions`
:returns: List of DNS Subject Alternative Names and first Common Name
:rtype: `list` of `str`
"""
# We know these are always `str` because `bytes` is only possible for
# other OIDs.