From 9084fd7b74299cc97078c4a1d110e6bd8e75eb57 Mon Sep 17 00:00:00 2001 From: sydneyli Date: Tue, 10 Dec 2019 14:04:53 -0800 Subject: [PATCH] Specify how find_ancestors is intended to work --- certbot-apache/certbot_apache/interfaces.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/certbot-apache/certbot_apache/interfaces.py b/certbot-apache/certbot_apache/interfaces.py index 9762974a8..e8e1b2351 100644 --- a/certbot-apache/certbot_apache/interfaces.py +++ b/certbot-apache/certbot_apache/interfaces.py @@ -199,8 +199,10 @@ class ParserNode(object): Traverses the ancestor tree up, searching for BlockNodes with a specific name. - When a node has multiple lineages (when it is included by multiple files), - this method should search through all possible ancestor paths. + .. note:: To maintain consistency with the original parser, this search + function currently only traverses nodes in the same file. Due + to this, we also don't run into the multiple-includes + ambiguity that the `ancestors` property has, for the time being. :param str name: Name of the ancestor BlockNode to search for