Ready for review

This commit is contained in:
Adrien Ferrand 2019-11-12 00:55:11 +01:00
parent 7cc0a02a7c
commit 8f1380a90a
2 changed files with 10 additions and 10 deletions

View file

@ -12,7 +12,7 @@ trap {
$ErrorActionPreference = 'Stop'
$installerAuthenticodeCertificateThumbprint = "74B2E146A82F2B71F8EB4B13EBBB6F951757D8C2"
$installerAuthenticodeCertificateThumbprint = "CHANGEME"
# Get current local certbot version
try {
@ -60,15 +60,15 @@ if ([System.Version]"$currentVersion" -ge [System.Version]"$latestVersion") {
$webClient.DownloadFile($installerUrl, $installerPath)
# Check installer has a valid signature from the Certbot release team
$signature = Get-AuthenticodeSignature "C:\Dev\Firefox Installer.exe"
if ($signature.Status -ne 'Valid') {
throw "Downloaded installer has no or invalid Authenticode signature."
}
$signature = Get-AuthenticodeSignature $installerPath
if ($signature.SignerCertificate.Thumbprint -ne $installerAuthenticodeCertificateThumbprint) {
throw "Downloaded installer has not been signed by Certbot development team."
}
# Uncomment the following lines of code once the Certbot installer is correctly signed.
# if ($signature.Status -ne 'Valid') {
# throw "Downloaded installer has no or invalid Authenticode signature."
# }
# if ($signature.SignerCertificate.Thumbprint -ne $installerAuthenticodeCertificateThumbprint) {
# throw "Downloaded installer has not been signed by Certbot development team."
# }
# Install new version of Certbot
"Running the installer ..."

View file

@ -11,7 +11,7 @@ $taskName = "Certbot Renew & Auto-Update Task"
$actionRenew = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument '-NoProfile -WindowStyle Hidden -Command "certbot renew"'
$actionPreUpgrade = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument "-NoProfile -WindowStyle Hidden -Command ""Copy-Item '$InstallDir\auto-update.ps1' ""`$env:TMP\auto-update.ps1"""""
$actionUpgrade = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument "-NoProfile -WindowStyle Hidden -File ""`$env:TMP\auto-update.ps1"" -InstallDir '$InstallDir'"
$actionUpgrade = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument "-NoProfile -WindowStyle Hidden -File ""%TMP%\auto-update.ps1"" -InstallDir ""$InstallDir"""
$actionPostUpgrade = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument '-NoProfile -WindowStyle Hidden -Command "Remove-Item "$env:TMP\auto-update.ps1" -ErrorAction "Ignore""'
$delay = New-TimeSpan -Hours 12