From 91b36e3b7f80b4b9c9724c9aa661ab9cdc1b6b90 Mon Sep 17 00:00:00 2001
From: Brad Warren <bmw@eff.org>
Date: Wed, 15 May 2019 18:45:10 -0700
Subject: [PATCH 1/2] Fix cleanup on failure.

---
 tests/letstest/multitester.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/letstest/multitester.py b/tests/letstest/multitester.py
index 430acb634..bc2178c6b 100644
--- a/tests/letstest/multitester.py
+++ b/tests/letstest/multitester.py
@@ -377,7 +377,10 @@ def test_client_process(inqueue, outqueue):
 
 def cleanup(cl_args, instances, targetlist):
     print('Logs in ', LOGDIR)
-    if not cl_args.saveinstances:
+    # If lengths of instances and targetlist aren't equal, instances failed to
+    # start before running tests so leaving instances running for debugging
+    # isn't very useful. Let's cleanup after ourselves instead.
+    if len(instances) == len(targetlist) or not cl_args.save_instances:
         print('Terminating EC2 Instances')
         if cl_args.killboulder:
             boulder_server.terminate()
@@ -488,6 +491,7 @@ else:
                                    security_group_id=security_group_id,
                                    subnet_id=subnet_id)
 
+instances = []
 try:
     if not cl_args.boulderonly:
         instances = create_client_instances(targetlist, security_group_id, subnet_id)

From 8d898a7183dd1159f6515663d64a7ef47cec7b3e Mon Sep 17 00:00:00 2001
From: Brad Warren <bmw@eff.org>
Date: Wed, 15 May 2019 20:11:46 -0700
Subject: [PATCH 2/2] Incrementally build instances list.

---
 tests/letstest/multitester.py | 53 +++++++++++++++++------------------
 1 file changed, 26 insertions(+), 27 deletions(-)

diff --git a/tests/letstest/multitester.py b/tests/letstest/multitester.py
index bc2178c6b..c1299da01 100644
--- a/tests/letstest/multitester.py
+++ b/tests/letstest/multitester.py
@@ -314,31 +314,27 @@ def grab_certbot_log():
     sudo('if [ -f ./certbot.log ]; then \
     cat ./certbot.log; else echo "[nolocallog]"; fi')
 
-def create_client_instances(targetlist, security_group_id, subnet_id):
-    "Create a fleet of client instances"
-    instances = []
-    print("Creating instances: ", end="")
-    for target in targetlist:
-        if target['virt'] == 'hvm':
-            machine_type = 't2.medium' if cl_args.fast else 't2.micro'
-        else:
-            # 32 bit systems
-            machine_type = 'c1.medium' if cl_args.fast else 't1.micro'
-        if 'userdata' in target.keys():
-            userdata = target['userdata']
-        else:
-            userdata = ''
-        name = 'le-%s'%target['name']
-        print(name, end=" ")
-        instances.append(make_instance(name,
-                                       target['ami'],
-                                       KEYNAME,
-                                       machine_type=machine_type,
-                                       security_group_id=security_group_id,
-                                       subnet_id=subnet_id,
-                                       userdata=userdata))
-    print()
-    return instances
+
+def create_client_instance(target, security_group_id, subnet_id):
+    """Create a single client instance for running tests."""
+    if target['virt'] == 'hvm':
+        machine_type = 't2.medium' if cl_args.fast else 't2.micro'
+    else:
+        # 32 bit systems
+        machine_type = 'c1.medium' if cl_args.fast else 't1.micro'
+    if 'userdata' in target.keys():
+        userdata = target['userdata']
+    else:
+        userdata = ''
+    name = 'le-%s'%target['name']
+    print(name, end=" ")
+    return make_instance(name,
+                         target['ami'],
+                         KEYNAME,
+                         machine_type=machine_type,
+                         security_group_id=security_group_id,
+                         subnet_id=subnet_id,
+                         userdata=userdata)
 
 
 def test_client_process(inqueue, outqueue):
@@ -380,7 +376,7 @@ def cleanup(cl_args, instances, targetlist):
     # If lengths of instances and targetlist aren't equal, instances failed to
     # start before running tests so leaving instances running for debugging
     # isn't very useful. Let's cleanup after ourselves instead.
-    if len(instances) == len(targetlist) or not cl_args.save_instances:
+    if len(instances) == len(targetlist) or not cl_args.saveinstances:
         print('Terminating EC2 Instances')
         if cl_args.killboulder:
             boulder_server.terminate()
@@ -494,7 +490,10 @@ else:
 instances = []
 try:
     if not cl_args.boulderonly:
-        instances = create_client_instances(targetlist, security_group_id, subnet_id)
+        print("Creating instances: ", end="")
+        for target in targetlist:
+            instances.append(create_client_instance(target, security_group_id, subnet_id))
+        print()
 
     # Configure and launch boulder server
     #-------------------------------------------------------------------------------