From fd1103ccda1c6c69bec57e868d508d433293df4c Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Fri, 16 Oct 2015 21:25:18 +0000 Subject: [PATCH 1/5] Tox tests detect downstream deps errors. --- tox.ini | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tox.ini b/tox.ini index b10558077..4eddc0e9d 100644 --- a/tox.ini +++ b/tox.ini @@ -10,13 +10,14 @@ envlist = py27,cover,lint [testenv] commands = - pip install -r requirements.txt -e acme -e .[testing] -e letsencrypt-apache -e letsencrypt-nginx -e letshelp-letsencrypt - # -q does not suppress errors - python setup.py test -q - python setup.py test -q -s acme - python setup.py test -q -s letsencrypt_apache - python setup.py test -q -s letsencrypt_nginx - python setup.py test -q -s letshelp_letsencrypt + pip install -e acme[testing] + nosetests acme + pip install -r requirements.txt -e .[testing] + nosetests letsencrypt + pip install letsencrypt-apache + nosetests letsencrypt_apache + pip install letsencrypt-nginx + nosetests letsencrypt_nginx setenv = PYTHONPATH = {toxinidir} From 2f3b6251c70beacbe4bc72fb64a3fbfcebe64f7e Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Fri, 16 Oct 2015 21:28:23 +0000 Subject: [PATCH 2/5] Tox: verbose nosetests --- tox.ini | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tox.ini b/tox.ini index 4eddc0e9d..0bd085975 100644 --- a/tox.ini +++ b/tox.ini @@ -8,16 +8,19 @@ skipsdist = true envlist = py27,cover,lint +# nosetest -v => more verbose output, allows to detect busy waiting +# loops, especially on Travis + [testenv] commands = pip install -e acme[testing] - nosetests acme + nosetests -v acme pip install -r requirements.txt -e .[testing] - nosetests letsencrypt + nosetests -v letsencrypt pip install letsencrypt-apache - nosetests letsencrypt_apache + nosetests -v letsencrypt_apache pip install letsencrypt-nginx - nosetests letsencrypt_nginx + nosetests -v letsencrypt_nginx setenv = PYTHONPATH = {toxinidir} @@ -27,12 +30,12 @@ setenv = [testenv:py33] commands = pip install -e acme[testing] - nosetests acme + nosetests -v acme [testenv:py34] commands = pip install -e acme[testing] - nosetests acme + nosetests -v acme [testenv:cover] basepython = python2.7 From fd4528baa39452aa38357cc87a2476646fd63e85 Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Fri, 16 Oct 2015 22:04:18 +0000 Subject: [PATCH 3/5] tox: pip install -e --- tox.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index 0bd085975..4818a7998 100644 --- a/tox.ini +++ b/tox.ini @@ -17,9 +17,9 @@ commands = nosetests -v acme pip install -r requirements.txt -e .[testing] nosetests -v letsencrypt - pip install letsencrypt-apache + pip install -e letsencrypt-apache nosetests -v letsencrypt_apache - pip install letsencrypt-nginx + pip install -e letsencrypt-nginx nosetests -v letsencrypt_nginx setenv = From 408903b7326a61212032582a5c84a377fd44d9d4 Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Fri, 16 Oct 2015 22:04:52 +0000 Subject: [PATCH 4/5] tox: bring back test for letshelp_letsencrypt --- tox.ini | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tox.ini b/tox.ini index 4818a7998..e45c1c125 100644 --- a/tox.ini +++ b/tox.ini @@ -21,6 +21,8 @@ commands = nosetests -v letsencrypt_apache pip install -e letsencrypt-nginx nosetests -v letsencrypt_nginx + pip install -e letshelp-letsencrypt + nosetests -v letshelp_letsencrypt setenv = PYTHONPATH = {toxinidir} From 86cd5af76e2fa532d8dbb1f0026078d3894fffd3 Mon Sep 17 00:00:00 2001 From: Jakub Warmuz Date: Fri, 16 Oct 2015 22:17:31 +0000 Subject: [PATCH 5/5] Add comment about downstream deps fix --- tox.ini | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tox.ini b/tox.ini index e45c1c125..febf1a2d0 100644 --- a/tox.ini +++ b/tox.ini @@ -12,6 +12,8 @@ envlist = py27,cover,lint # loops, especially on Travis [testenv] +# packages installed separately to ensure that dowstream deps problems +# are detected, c.f. #1002 commands = pip install -e acme[testing] nosetests -v acme